From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F86C433F5 for ; Sun, 5 Sep 2021 14:38:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FD7060F14 for ; Sun, 5 Sep 2021 14:38:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FD7060F14 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DaZcVx9z8nUjF+1xcT1p2pM8/oSiUksHVVomAC1iAkA=; b=vGFICkWWaGhg6Czyvd1JN84VzR eg1zIR9pgcCNMBuPq5td1SlRb0Si0khR6WRE4zJjF5ylIRmGeht4nLwWD8eUI7NAq6uSMbzcW+Ule ZAJUlaSlatDnfJFor7qeycdV93NDWN6Nz8DZMza/xBwJ4orVoCS6L+5J8dq+AajZsvmJeUmE9Qb7N dn4cd1pbItRHr6BlK7W09ynu1ClO92eLeydZcXj5cafvCwZPf8VqckRG7Awu6z7yb5a2fnWxfARJ3 nYRJ+bHPpzmCkS2ULg13KFrF9lH2z0Ma2MwXyzEmxawdyo9b3YFA/vxkRB0N5/DbBB6gLTBHMeTpM Q56HAlQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMtGc-00Fy6h-Mb; Sun, 05 Sep 2021 14:37:06 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMtGZ-00Fy5r-1Y for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 14:37:04 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A53BC82BDC; Sun, 5 Sep 2021 16:36:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1630852619; bh=kE6VsstF+dA7mJIdmYjXuF8pUJ9JpFTiIMrAYPERefQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XW3WAtzPgZsSdwmvQADaYYloD/lTOwR3E1FW5oul5sIvspqS0TwucN2n3lpK1hqMn nh4l9+2iKXnd5kFORNU3lJA9Mus7sgB+Hqu9T9dWPGl1BEYpgBeLRz7N5j5QYhNxsg xHOy2qLv6iP0kDBt//PodNXbq17zjdmYSMO64sCvN075t3s2i91CQFGXfd/qbbJvX5 SfE57mzNYxv1v9JAlUPgUjj67FxVkyPVgD8H0QKV1cxnX2PPJ5kjt6jHhwM3KcQyq7 QtcQ+vfJcTw3zPzxkvz4Ya3T364E5egbBbClnftixHj4odZ2baeF6fXowPuLllCwtr boDhO64MFK6Ng== Subject: Re: [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo To: Fabio Estevam Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Shawn Guo , NXP Linux Team References: <20210905000137.95438-1-marex@denx.de> <92d00e82-737b-7380-00aa-fb49656ff8e7@denx.de> From: Marek Vasut Message-ID: Date: Sun, 5 Sep 2021 16:35:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210905_073703_341607_9F3ED49A X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/5/21 2:00 PM, Fabio Estevam wrote: > Hi Marek, Hi, > On Sat, Sep 4, 2021 at 11:57 PM Marek Vasut wrote: > >> No, the GPIO flags are ignored by gpiolib-of and the signal is active >> low. That's why there is that zero, no flags, and no enable-active-high >> property. > > Yes, correct. The GPIO flag is ignored by "regulator-fixed". > > As you removed the 'enable-active-high' property, you turned the > regulator to active low as needed. > > This is correct. > > gpio = <&gpio1 2 0> is the same as gpio = <&gpio1 2 GPIO_ACTIVE_HIGH> > > I just suggested gpio = <&gpio1 2 GPIO_ACTIVE_LOW> to make it clearer > what is the real polarity. > > The GPIO flag is ignored, I know. No issues if you want to keep it as > gpio = <&gpio1 2 0>. We had the same discussion before around this patch :) [PATCH V6 01/15] ARM: dts: imx6q-dhcom: Add the parallel system bus Message-ID: The 0 is correct as the field is ignored, please keep it. Any other variants (like GPIO_ACTIVE_LOW = 1) interact badly with drivers/gpio/gpiolib-of.c of_gpio_flags_quirks() which is already a total compatibility attempt mess and lead to odd misbehavior of the regulator where the polarity of the GPIO is randomly interpreted as low or high dependent on the kernel version. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel