All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: networking: switchdev: Update port parent ID section
@ 2019-02-20 22:58 Florian Fainelli
  2019-02-22 19:58 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2019-02-20 22:58 UTC (permalink / raw)
  To: netdev; +Cc: andrew, vivien.didelot, idosch, jiri, Florian Fainelli

Update the section about switchdev drivers having to implement a
switchdev_port_attr_get() function to return
SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
commit bccb30254a4a ("net: Get rid of
SWITCHDEV_ATTR_ID_PORT_PARENT_ID").

Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/networking/switchdev.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
index f3244d87512a..ea90243340a9 100644
--- a/Documentation/networking/switchdev.txt
+++ b/Documentation/networking/switchdev.txt
@@ -92,11 +92,11 @@ device.
 Switch ID
 ^^^^^^^^^
 
-The switchdev driver must implement the switchdev op switchdev_port_attr_get
-for SWITCHDEV_ATTR_ID_PORT_PARENT_ID for each port netdev, returning the same
-physical ID for each port of a switch.  The ID must be unique between switches
-on the same system.  The ID does not need to be unique between switches on
-different systems.
+The switchdev driver must implement the net_device operation
+ndo_get_port_parent_id for each port netdev, returning the same physical ID for
+each port of a switch. The ID must be unique between switches on the same
+system. The ID does not need to be unique between switches on different
+systems.
 
 The switch ID is used to locate ports on a switch and to know if aggregated
 ports belong to the same switch.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section
  2019-02-20 22:58 [PATCH] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli
@ 2019-02-22 19:58 ` David Miller
  2019-02-24 16:46   ` Florian Fainelli
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2019-02-22 19:58 UTC (permalink / raw)
  To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, idosch, jiri

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 20 Feb 2019 14:58:50 -0800

> Update the section about switchdev drivers having to implement a
> switchdev_port_attr_get() function to return
> SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
> commit bccb30254a4a ("net: Get rid of
> SWITCHDEV_ATTR_ID_PORT_PARENT_ID").
> 
> Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section
  2019-02-22 19:58 ` David Miller
@ 2019-02-24 16:46   ` Florian Fainelli
  2019-02-24 19:26     ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2019-02-24 16:46 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, andrew, vivien.didelot, idosch, jiri

Le 2/22/19 à 11:58 AM, David Miller a écrit :
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Wed, 20 Feb 2019 14:58:50 -0800
> 
>> Update the section about switchdev drivers having to implement a
>> switchdev_port_attr_get() function to return
>> SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
>> commit bccb30254a4a ("net: Get rid of
>> SWITCHDEV_ATTR_ID_PORT_PARENT_ID").
>>
>> Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")
>> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
>> Acked-by: Jiri Pirko <jiri@mellanox.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Applied.
> 

Looks like you applied this to the "net" tree, and I missed prefixing
the patch to indicate this was targeted at the "net-next" tree. Are you
planning a merge from "net" to "net-next" anytime soon?

Thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section
  2019-02-24 16:46   ` Florian Fainelli
@ 2019-02-24 19:26     ` David Miller
  2019-02-24 20:13       ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2019-02-24 19:26 UTC (permalink / raw)
  To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, idosch, jiri

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sun, 24 Feb 2019 08:46:59 -0800

> Looks like you applied this to the "net" tree, and I missed prefixing
> the patch to indicate this was targeted at the "net-next" tree. Are you
> planning a merge from "net" to "net-next" anytime soon?

Yes, I am working on that right now.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section
  2019-02-24 19:26     ` David Miller
@ 2019-02-24 20:13       ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-02-24 20:13 UTC (permalink / raw)
  To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, idosch, jiri

From: David Miller <davem@davemloft.net>
Date: Sun, 24 Feb 2019 11:26:30 -0800 (PST)

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Sun, 24 Feb 2019 08:46:59 -0800
> 
>> Looks like you applied this to the "net" tree, and I missed prefixing
>> the patch to indicate this was targeted at the "net-next" tree. Are you
>> planning a merge from "net" to "net-next" anytime soon?
> 
> Yes, I am working on that right now.

This is now done.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-02-24 20:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 22:58 [PATCH] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli
2019-02-22 19:58 ` David Miller
2019-02-24 16:46   ` Florian Fainelli
2019-02-24 19:26     ` David Miller
2019-02-24 20:13       ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.