From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCB1C63793 for ; Thu, 22 Jul 2021 08:55:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2810961378 for ; Thu, 22 Jul 2021 08:55:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2810961378 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 348BA82C4D; Thu, 22 Jul 2021 10:55:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626944115; bh=xulDmJ0yI7jIMzqio8RMyOAhw4ZQ2ztC+go+PgW34Oo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jqjj0YpaI6bQtKOEV6AbKJYP91lrK+Hcydd3Ng8kNQEnsbEUT+Gkm3PTUgY1bCMLX 3qLl4AKO5mskhCe6eCN0R9GqA4jJZcAs/neBKuthjhOgJsK9TSNezRmLky6cClzEVa e8HjLCg4cf+tM0bRH0lJFNN4a/3IPIM2Tyw3qDx3O7MGxXZIiuoAfPTPtMVtuHaEHK 4mWcKrn2I8DZ+d8HKdmM/xYYXjlICyFmpp/wyOw0FAid206oapm58+erHsov1fnSK5 bvU8rpT6lT8ZO5pm+lpsAi6T6QD7SfrtDc/PxlnGa4yWARI4ezLBSy1W8/KqK4T0X1 FILiR8XUg9Jig== Received: by phobos.denx.de (Postfix, from userid 109) id DB4A782C4D; Thu, 22 Jul 2021 10:55:13 +0200 (CEST) Received: from mout-u-205.mailbox.org (mout-u-205.mailbox.org [IPv6:2001:67c:2050:1::465:205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 843AE829FC for ; Thu, 22 Jul 2021 10:55:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-205.mailbox.org (Postfix) with ESMTPS id 4GVmVk2Cs9zQkGX; Thu, 22 Jul 2021 10:55:10 +0200 (CEST) Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id 9oEXZCcmZyHU; Thu, 22 Jul 2021 10:55:07 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu v2 39/41] arm: mvebu: gdsys: Remove custom spl_board_init() To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham , Mario Six Cc: Dennis Gilmore , Jon Nettleton , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210719122104.29698-1-marek.behun@nic.cz> <20210719122104.29698-40-marek.behun@nic.cz> From: Stefan Roese Message-ID: Date: Thu, 22 Jul 2021 10:55:03 +0200 MIME-Version: 1.0 In-Reply-To: <20210719122104.29698-40-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 513C418CC X-Rspamd-UID: d0b7e3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Mario, On 19.07.21 14:21, Marek Behún wrote: > From: Pali Rohár > > Now it is possible to use BootROM to load and boot main U-Boot binary. It > is just required to disable config option CONFIG_SPL_SPI_FLASH_SUPPORT. > > gdsys a38x config file (controlcenterdc_defconfig) does not have that > option enabled so there is no need to provide custom spl_board_init() > function which calls return_to_bootrom(). > > Remove it. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún > Reviewed-by: Chris Packham Mario, could you please do some tests on your Marvell platforms with this series? Reviewed-by: Stefan Roese Thanks, Stefan > --- > board/gdsys/a38x/Makefile | 2 +- > board/gdsys/a38x/spl.c | 20 -------------------- > 2 files changed, 1 insertion(+), 21 deletions(-) > delete mode 100644 board/gdsys/a38x/spl.c > > diff --git a/board/gdsys/a38x/Makefile b/board/gdsys/a38x/Makefile > index 32fffab467..4b13859fed 100644 > --- a/board/gdsys/a38x/Makefile > +++ b/board/gdsys/a38x/Makefile > @@ -4,7 +4,7 @@ > # Copyright (C) 2015 Reinhard Pfau > # Copyright (C) 2016 Mario Six > > -obj-$(CONFIG_TARGET_CONTROLCENTERDC) += controlcenterdc.o hre.o spl.o keyprogram.o dt_helpers.o > +obj-$(CONFIG_TARGET_CONTROLCENTERDC) += controlcenterdc.o hre.o keyprogram.o dt_helpers.o > > ifeq ($(CONFIG_SPL_BUILD),) > obj-$(CONFIG_TARGET_CONTROLCENTERDC) += hydra.o ihs_phys.o > diff --git a/board/gdsys/a38x/spl.c b/board/gdsys/a38x/spl.c > deleted file mode 100644 > index 84864d1974..0000000000 > --- a/board/gdsys/a38x/spl.c > +++ /dev/null > @@ -1,20 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0+ > -/* > - * (C) Copyright 2016 > - * Mario Six, Guntermann & Drunck GmbH, mario.six@gdsys.cc > - */ > - > -#include > -#include > -#include > - > -void spl_board_init(void) > -{ > -#if CONFIG_SPL_BOOT_DEVICE == SPL_BOOT_SPI_NOR_FLASH > - u32 *bootrom_save = (u32 *)CONFIG_SPL_BOOTROM_SAVE; > - u32 *regs = (u32 *)(*bootrom_save); > - > - printf("Returning to BootROM (return address %08x)...\n", regs[13]); > - return_to_bootrom(); > -#endif > -} > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de