From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbeBSC6H (ORCPT ); Sun, 18 Feb 2018 21:58:07 -0500 Received: from icp-osb-irony-out1.external.iinet.net.au ([203.59.1.210]:48501 "EHLO icp-osb-irony-out1.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbeBSC6F (ORCPT ); Sun, 18 Feb 2018 21:58:05 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2CnAAA7OYpa/zXSMGcNTxkBAQEBAQEBA?= =?us-ascii?q?QEBAQEHAQEBAQGFTYNnmGoBAQEBAQEGgQ0ngReYX4VFAoMeFAECAQEBAQEBAoY?= =?us-ascii?q?2AQEBAQIBI1YFCwsNAQoCAiYCAlcGAQwGAgEBihEFqVtugichhGCDc4ITAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEhgQ+DfIM3glkMgnmIOoJlBaQ1CAGiXYd0mVs2gXMzGgg?= =?us-ascii?q?oCIJ9hQhmjkcBAQE?= X-IPAS-Result: =?us-ascii?q?A2CnAAA7OYpa/zXSMGcNTxkBAQEBAQEBAQEBAQEHAQEBAQG?= =?us-ascii?q?FTYNnmGoBAQEBAQEGgQ0ngReYX4VFAoMeFAECAQEBAQEBAoY2AQEBAQIBI1YFC?= =?us-ascii?q?wsNAQoCAiYCAlcGAQwGAgEBihEFqVtugichhGCDc4ITAQEBAQEBAQEBAQEBAQE?= =?us-ascii?q?BAQEhgQ+DfIM3glkMgnmIOoJlBaQ1CAGiXYd0mVs2gXMzGggoCIJ9hQhmjkcBA?= =?us-ascii?q?QE?= X-IronPort-AV: E=Sophos;i="5.46,533,1511798400"; d="scan'208";a="74053760" Subject: Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies To: Finn Thain , "David S. Miller" Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven References: From: Greg Ungerer Message-ID: Date: Mon, 19 Feb 2018 12:47:09 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finn, On 19/02/18 12:39, Finn Thain wrote: > The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and > have no need for 8390.o. modinfo confirms no dependency on 8390.ko. > Drop the redundant dependency from the Makefile. objdump confirms > that this patch has no effect on the module binaries. > > The superfluous additions of 8390.o were introduced in > commit 644570b83026 ("8390: Move the 8390 related drivers"). > > Cc: Greg Ungerer Looks right for mcf8390.c. Acked-by: Greg Ungerer Regards Greg > Cc: Geert Uytterhoeven > Signed-off-by: Finn Thain > Acked-by: Geert Uytterhoeven > --- > drivers/net/ethernet/8390/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/8390/Makefile b/drivers/net/ethernet/8390/Makefile > index f975c2fc88a3..1d650e66cc6e 100644 > --- a/drivers/net/ethernet/8390/Makefile > +++ b/drivers/net/ethernet/8390/Makefile > @@ -7,8 +7,8 @@ obj-$(CONFIG_MAC8390) += mac8390.o > obj-$(CONFIG_APNE) += apne.o 8390.o > obj-$(CONFIG_ARM_ETHERH) += etherh.o > obj-$(CONFIG_AX88796) += ax88796.o > -obj-$(CONFIG_HYDRA) += hydra.o 8390.o > -obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o > +obj-$(CONFIG_HYDRA) += hydra.o > +obj-$(CONFIG_MCF8390) += mcf8390.o > obj-$(CONFIG_NE2000) += ne.o 8390p.o > obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o > obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o > @@ -16,4 +16,4 @@ obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o > obj-$(CONFIG_STNIC) += stnic.o 8390.o > obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o > obj-$(CONFIG_WD80x3) += wd.o 8390.o > -obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o > +obj-$(CONFIG_ZORRO8390) += zorro8390.o > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies To: Finn Thain , "David S. Miller" Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven References: From: Greg Ungerer Message-ID: Date: Mon, 19 Feb 2018 12:47:09 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Finn, On 19/02/18 12:39, Finn Thain wrote: > The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and > have no need for 8390.o. modinfo confirms no dependency on 8390.ko. > Drop the redundant dependency from the Makefile. objdump confirms > that this patch has no effect on the module binaries. > > The superfluous additions of 8390.o were introduced in > commit 644570b83026 ("8390: Move the 8390 related drivers"). > > Cc: Greg Ungerer Looks right for mcf8390.c. Acked-by: Greg Ungerer Regards Greg > Cc: Geert Uytterhoeven > Signed-off-by: Finn Thain > Acked-by: Geert Uytterhoeven > --- > drivers/net/ethernet/8390/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/8390/Makefile b/drivers/net/ethernet/8390/Makefile > index f975c2fc88a3..1d650e66cc6e 100644 > --- a/drivers/net/ethernet/8390/Makefile > +++ b/drivers/net/ethernet/8390/Makefile > @@ -7,8 +7,8 @@ obj-$(CONFIG_MAC8390) += mac8390.o > obj-$(CONFIG_APNE) += apne.o 8390.o > obj-$(CONFIG_ARM_ETHERH) += etherh.o > obj-$(CONFIG_AX88796) += ax88796.o > -obj-$(CONFIG_HYDRA) += hydra.o 8390.o > -obj-$(CONFIG_MCF8390) += mcf8390.o 8390.o > +obj-$(CONFIG_HYDRA) += hydra.o > +obj-$(CONFIG_MCF8390) += mcf8390.o > obj-$(CONFIG_NE2000) += ne.o 8390p.o > obj-$(CONFIG_NE2K_PCI) += ne2k-pci.o 8390.o > obj-$(CONFIG_PCMCIA_AXNET) += axnet_cs.o 8390.o > @@ -16,4 +16,4 @@ obj-$(CONFIG_PCMCIA_PCNET) += pcnet_cs.o 8390.o > obj-$(CONFIG_STNIC) += stnic.o 8390.o > obj-$(CONFIG_ULTRA) += smc-ultra.o 8390.o > obj-$(CONFIG_WD80x3) += wd.o 8390.o > -obj-$(CONFIG_ZORRO8390) += zorro8390.o 8390.o > +obj-$(CONFIG_ZORRO8390) += zorro8390.o >