All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Nathan Chancellor <nathan@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	"kernelci.org bot" <bot@kernelci.org>
Subject: Re: [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer
Date: Tue, 24 May 2022 08:09:04 -0700	[thread overview]
Message-ID: <c7a804ed-e00c-8a32-db21-c689312e0073@redhat.com> (raw)
In-Reply-To: <20220524145655.869822-1-nathan@kernel.org>


On 5/24/22 7:56 AM, Nathan Chancellor wrote:
> Clang does not support this option so the build fails:
>
>    error: unknown warning option '-Wno-dangling-pointer' [-Werror,-Wunknown-warning-option]
>
> Use cc-disable-warning so that the option is only added when it is
> supported.
>
> Fixes: bd1d129daa3e ("wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12")
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Tom Rix <trix@redhat.com>

Thanks

Tom

> ---
>   drivers/net/wireless/ath/ath6kl/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/Makefile b/drivers/net/wireless/ath/ath6kl/Makefile
> index 01cc0d50fee6..a75bfa9fd1cf 100644
> --- a/drivers/net/wireless/ath/ath6kl/Makefile
> +++ b/drivers/net/wireless/ath/ath6kl/Makefile
> @@ -38,7 +38,7 @@ ath6kl_core-y += recovery.o
>   
>   # FIXME: temporarily silence -Wdangling-pointer on non W=1+ builds
>   ifndef KBUILD_EXTRA_WARN
> -CFLAGS_htc_mbox.o += -Wno-dangling-pointer
> +CFLAGS_htc_mbox.o += $(call cc-disable-warning, dangling-pointer)
>   endif
>   
>   ath6kl_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
>
> base-commit: 677fb7525331375ba2f90f4bc94a80b9b6e697a3


  reply	other threads:[~2022-05-24 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 14:56 [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer Nathan Chancellor
2022-05-24 15:09 ` Tom Rix [this message]
2022-05-24 15:38 ` Alexander Lobakin
2022-05-24 18:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7a804ed-e00c-8a32-db21-c689312e0073@redhat.com \
    --to=trix@redhat.com \
    --cc=bot@kernelci.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.