From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-f182.google.com ([209.85.192.182]:34879 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754949AbcETHxu (ORCPT ); Fri, 20 May 2016 03:53:50 -0400 Received: by mail-pf0-f182.google.com with SMTP id b66so18084655pfb.2 for ; Fri, 20 May 2016 00:53:50 -0700 (PDT) Subject: Re: [PATCH] brcmfmac: use kmemdup To: Muhammad Falak R Wani , Kalle Valo References: <1463666357-16719-1-git-send-email-falakreyaz@gmail.com> Cc: Brett Rudley , Arend van Spriel , "Franky (Zhenhui) Lin" , Hante Meuleman , Pieter-Paul Giesberts , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arend Van Spriel Message-ID: (sfid-20160520_095427_847050_FAB3EF7B) Date: Fri, 20 May 2016 09:53:42 +0200 MIME-Version: 1.0 In-Reply-To: <1463666357-16719-1-git-send-email-falakreyaz@gmail.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19-5-2016 15:59, Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. Acked-by: Arend van Spriel > Signed-off-by: Muhammad Falak R Wani > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > index d0631b6..705adaa 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -6699,11 +6699,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr, > return NULL; > } > > - ops = kzalloc(sizeof(*ops), GFP_KERNEL); > + ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL); > if (!ops) > return NULL; > > - memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops)); > ifp = netdev_priv(ndev); > #ifdef CONFIG_PM > if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK)) >