Re: [PATCH v3 02/22] drm/fb-cma-helper: Use drm_gem_framebuffer_helper

From: "Noralf Trønnes" <noralf@tronnes.org>
To: Eric Anholt <eric@anholt.net>, dri-devel@lists.freedesktop.org
Cc: narmstrong@baylibre.com, daniel.vetter@ffwll.ch,
	liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com,
	marex@denx.de, boris.brezillon@free-electrons.com,
	abrodkin@synopsys.com, z.liuxinliang@hisilicon.com,
	kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com,
	puck.chen@hisilicon.com, jsarha@ti.com, vincent.abriou@st.com,
	alison.wang@freescale.com, philippe.cornu@st.com,
	yannick.fertre@st.com, zourongrong@gmail.com,
	maxime.ripard@free-electrons.com, shawnguo@kernel.org
Subject: Re: [PATCH v3 02/22] drm/fb-cma-helper: Use drm_gem_framebuffer_helper
Date: Wed, 16 Aug 2017 21:53:05 +0200	[thread overview]
Message-ID: <c7dccb2d-a27d-5b0b-a741-81a4b2249405@tronnes.org> (raw)
In-Reply-To: <87pobvquxs.fsf@eliezer.anholt.net>

Den 16.08.2017 19.33, skrev Eric Anholt:
> Noralf Trønnes <noralf@tronnes.org> writes:
>
>> Use the new drm_gem_framebuffer_helper who's code was copied
>> from this helper.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> ---
>>   drivers/gpu/drm/drm_fb_cma_helper.c | 181 ++++++------------------------------
>>   1 file changed, 30 insertions(+), 151 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
>> index ade319d..e1befee 100644
>> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
>> @@ -250,12 +143,14 @@ EXPORT_SYMBOL_GPL(drm_fb_cma_create);
>>   struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct drm_framebuffer *fb,
>>   						  unsigned int plane)
>>   {
>> -	struct drm_fb_cma *fb_cma = to_fb_cma(fb);
>> +	struct drm_gem_object *gem;
>>   
>> -	if (plane >= 4)
>> +	gem = drm_gem_fb_get_obj(fb, plane);
>> +	if (!gem)
>>   		return NULL;
>>   
>> -	return fb_cma->obj[plane];
>> +	return to_drm_gem_cma_obj(gem);
>> +
>>   }
> Stray whitespace.  Other than that,
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> Feel free to push vc4 and pl111 with this patch.

Thanks Eric, this patch, vc4 and pl111 applied to drm-misc.

Noralf.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel