All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86/asm: Use ASM_FLAG_OUT() to simplify atomic and bitop stubs
Date: Wed, 15 Feb 2017 14:25:23 +0000	[thread overview]
Message-ID: <c7e1e2a8-5a2b-57e1-de42-a2c37b1fd79c@citrix.com> (raw)
In-Reply-To: <1487168556-29987-1-git-send-email-andrew.cooper3@citrix.com>

On 15/02/17 14:22, Andrew Cooper wrote:
> bitops.h cannot include asm_defns.h, because the static inlines in cpumasks.h
> result in forward declarations of the bitops.h contents.  Move ASM_FLAG_OUT()
> to a new asm/compiler.h to compensate.
>
> While making changes, switch bool_t to bool and use named asm parameters.
>
> No (intended) functional change.  Without GCC flags, the disassembly is
> identical before and after this patch.  With GCC flags however, this patch
> seems to cause GCC to make instruction scheduling decisions.

This is supposed to read "make better instruction...".

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-15 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 14:22 [PATCH] x86/asm: Use ASM_FLAG_OUT() to simplify atomic and bitop stubs Andrew Cooper
2017-02-15 14:25 ` Andrew Cooper [this message]
2017-02-15 14:55 ` Jan Beulich
2017-02-15 15:13   ` Jan Beulich
2017-02-15 16:00   ` Andrew Cooper
2017-02-15 16:08     ` Jan Beulich
2017-02-15 16:53 ` Andrew Cooper
2017-02-15 16:59   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7e1e2a8-5a2b-57e1-de42-a2c37b1fd79c@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.