From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/3 v3] xen: Refactor 16550 UART code Date: Fri, 24 Nov 2017 16:04:30 +0000 Message-ID: References: <1511523552-23628-1-git-send-email-bhupinder.thakur@linaro.org> <1511523552-23628-2-git-send-email-bhupinder.thakur@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIGSw-0005nA-3a for xen-devel@lists.xenproject.org; Fri, 24 Nov 2017 16:04:34 +0000 Received: by mail-wm0-f65.google.com with SMTP id y82so20813903wmg.1 for ; Fri, 24 Nov 2017 08:04:32 -0800 (PST) In-Reply-To: <1511523552-23628-2-git-send-email-bhupinder.thakur@linaro.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Bhupinder Thakur , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGkgQmh1cGluZGVyLAoKT24gMjQvMTEvMTcgMTE6MzksIEJodXBpbmRlciBUaGFrdXIgd3JvdGU6 Cj4gVGhpcyBwYXRjaCByZWZhY3RvcnMgdGhlIDgyNTAgVUFSVCBjb2RlIHNvIHRoYXQgY29kZSBj YW4gYmUgcmV1c2VkCj4gYnkgbGF0ZXIgcGF0Y2hlcywgd2hpY2ggYWRkIHN1cHBvcnQgZm9yIEFD UEkgYmFzZWQgVUFSVAo+IGluaXRpYWxpemF0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJodXBp bmRlciBUaGFrdXIgPGJodXBpbmRlci50aGFrdXJAbGluYXJvLm9yZz4KPiAtLS0KPiBDaGFuZ2Vz IHNpbmNlIHYyOgo+IC0gUmVmYWN0b3JlZCB0aGUgY29kZSB0byBwcmVwYXJlIGZvciBsYXRlciBw YXRjaGVzLgo+IAo+IENDOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pgo+IENDOiBHZW9yZ2UgRHVubGFwIDxHZW9yZ2UuRHVubGFwQGV1LmNpdHJpeC5jb20+Cj4gQ0M6 IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXguY29tPgo+IENDOiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+Cj4gQ0M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFk LndpbGtAb3JhY2xlLmNvbT4KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPgo+IENDOiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KPiBDQzogV2VpIExpdSA8 d2VpLmxpdTJAY2l0cml4LmNvbT4KPiBDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJt LmNvbT4KPiAKPiAgIHhlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jIHwgNTMgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQw IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vZHJp dmVycy9jaGFyL25zMTY1NTAuYyBiL3hlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jCj4gaW5kZXgg ZTBmODE5OS4uYzVkZmMxZSAxMDA2NDQKPiAtLS0gYS94ZW4vZHJpdmVycy9jaGFyL25zMTY1NTAu Ywo+ICsrKyBiL3hlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jCj4gQEAgLTE0NjIsMTYgKzE0NjIs MzIgQEAgdm9pZCBfX2luaXQgbnMxNjU1MF9pbml0KGludCBpbmRleCwgc3RydWN0IG5zMTY1NTBf ZGVmYXVsdHMgKmRlZmF1bHRzKQo+ICAgICAgIG5zMTY1NTBfcGFyc2VfcG9ydF9jb25maWcodWFy dCwgKGluZGV4ID09IDApID8gb3B0X2NvbTEgOiBvcHRfY29tMik7Cj4gICB9Cj4gICAKPiArI2lm ZGVmIENPTkZJR19BUk0KPiArc3RhdGljIHZvaWQgbnMxNjU1MF92dWFydF9pbml0KHN0cnVjdCBu czE2NTUwICp1YXJ0KQoKX19pbml0LgoKPiArewo+ICsgICAgdWFydC0+dnVhcnQuYmFzZV9hZGRy ICAgPSB1YXJ0LT5pb19iYXNlOwo+ICsgICAgdWFydC0+dnVhcnQuc2l6ZSAgICAgICAgPSB1YXJ0 LT5pb19zaXplOwo+ICsgICAgdWFydC0+dnVhcnQuZGF0YV9vZmYgICAgPSBVQVJUX1RIUiA8PCB1 YXJ0LT5yZWdfc2hpZnQ7Cj4gKyAgICB1YXJ0LT52dWFydC5zdGF0dXNfb2ZmICA9IFVBUlRfTFNS IDw8IHVhcnQtPnJlZ19zaGlmdDsKPiArICAgIHVhcnQtPnZ1YXJ0LnN0YXR1cyAgICAgID0gVUFS VF9MU1JfVEhSRSB8IFVBUlRfTFNSX1RFTVQ7Cj4gK30KPiArI2VuZGlmCj4gKwo+ICtzdGF0aWMg dm9pZCBuczE2NTUwX3JlZ2lzdGVyX3VhcnQoc3RydWN0IG5zMTY1NTAgKnVhcnQpCgpfX2luaXQK Cj4gK3sKPiArICAgIC8qIFJlZ2lzdGVyIHdpdGggZ2VuZXJpYyBzZXJpYWwgZHJpdmVyLiAqLwo+ ICsgICAgc2VyaWFsX3JlZ2lzdGVyX3VhcnQodWFydCAtIG5zMTY1NTBfY29tLCAmbnMxNjU1MF9k cml2ZXIsIHVhcnQpOwo+ICt9CgpJIGRvbid0IHRoaW5rIHRoaXMgZnVuY3Rpb24gc2hvdWxkIGV4 aXN0LiBBcm0gaXMgdXNpbmcgb25seSBvbmUgcG9ydCwgCmJ1dCB0aGlzIGlzIG5vdCB0cnVlIGZv ciB4ODYuIEl0IHdvdWxkIGJlIGJldHRlciB0byBmb2xkIHRoaXMgaW50byBlYWNoIAppbXBsZW1l bnRhdGlvbiAoZS5nIEFDUEkgYW5kIERUKS4KCj4gKwo+ICAgI2lmZGVmIENPTkZJR19IQVNfREVW SUNFX1RSRUUKPiAtc3RhdGljIGludCBfX2luaXQgbnMxNjU1MF91YXJ0X2R0X2luaXQoc3RydWN0 IGR0X2RldmljZV9ub2RlICpkZXYsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHZvaWQgKmRhdGEpCj4gKwo+ICtzdGF0aWMgaW50IG5zMTY1NTBfaW5pdF9k dChzdHJ1Y3QgbnMxNjU1MCAqKnB1YXJ0LAoKX19pbml0Cgo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldikgPiAgIHsKPiAtICAgIHN0 cnVjdCBuczE2NTUwICp1YXJ0Owo+ICAgICAgIGludCByZXM7Cj4gICAgICAgdTMyIHJlZ19zaGlm dCwgcmVnX3dpZHRoOwo+ICAgICAgIHU2NCBpb19zaXplOwo+IC0KPiAtICAgIHVhcnQgPSAmbnMx NjU1MF9jb21bMF07Cj4gKyAgICBzdHJ1Y3QgbnMxNjU1MCAqdWFydCA9ICZuczE2NTUwX2NvbVsw XTsKPiAgIAo+ICAgICAgIG5zMTY1NTBfaW5pdF9jb21tb24odWFydCk7Cj4gICAKPiBAQCAtMTUx MCwxOCArMTUyNiwyOSBAQCBzdGF0aWMgaW50IF9faW5pdCBuczE2NTUwX3VhcnRfZHRfaW5pdChz dHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldiwKPiAgIAo+ICAgICAgIHVhcnQtPmR3X3Vzcl9ic3kg PSBkdF9kZXZpY2VfaXNfY29tcGF0aWJsZShkZXYsICJzbnBzLGR3LWFwYi11YXJ0Iik7Cj4gICAK PiAtICAgIHVhcnQtPnZ1YXJ0LmJhc2VfYWRkciA9IHVhcnQtPmlvX2Jhc2U7Cj4gLSAgICB1YXJ0 LT52dWFydC5zaXplID0gdWFydC0+aW9fc2l6ZTsKPiAtICAgIHVhcnQtPnZ1YXJ0LmRhdGFfb2Zm ID0gVUFSVF9USFIgPDx1YXJ0LT5yZWdfc2hpZnQ7Cj4gLSAgICB1YXJ0LT52dWFydC5zdGF0dXNf b2ZmID0gVUFSVF9MU1I8PHVhcnQtPnJlZ19zaGlmdDsKPiAtICAgIHVhcnQtPnZ1YXJ0LnN0YXR1 cyA9IFVBUlRfTFNSX1RIUkV8VUFSVF9MU1JfVEVNVDsKPiArICAgICpwdWFydCA9IHVhcnQ7Cj4g ICAKPiAtICAgIC8qIFJlZ2lzdGVyIHdpdGggZ2VuZXJpYyBzZXJpYWwgZHJpdmVyLiAqLwo+IC0g ICAgc2VyaWFsX3JlZ2lzdGVyX3VhcnQodWFydCAtIG5zMTY1NTBfY29tLCAmbnMxNjU1MF9kcml2 ZXIsIHVhcnQpOwo+ICsgICAgcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgX19pbml0 IG5zMTY1NTBfdWFydF9kdF9pbml0KHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCB2b2lkICpkYXRhKQo+ICt7 Cj4gKyAgICBzdHJ1Y3QgbnMxNjU1MCAqdWFydDsKPiArICAgIGludCByZXQ7Cj4gKwo+ICsgICAg cmV0ID0gbnMxNjU1MF9pbml0X2R0KCZ1YXJ0LCBkYXRhKTsKCldoeSBkbyB5b3UgbmVlZCB0byBj cmVhdGUgbnMxNjU1MF9pbml0X2R0PyBJdCBpcyBvbmx5IHVzZWQgaGVyZSwKCj4gKwo+ICsgICAg aWYgKCByZXQgKQo+ICsgICAgICAgIHJldHVybiByZXQ7Cj4gKwo+ICsgICAgbnMxNjU1MF92dWFy dF9pbml0KHVhcnQpOwo+ICsKPiArICAgIG5zMTY1NTBfcmVnaXN0ZXJfdWFydCh1YXJ0KTsKPiAg IAo+ICAgICAgIGR0X2RldmljZV9zZXRfdXNlZF9ieShkZXYsIERPTUlEX1hFTik7Cj4gICAKPiAt ICAgIHJldHVybiAwOwo+ICsgICAgcmV0dXJuIHJldDsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGNv bnN0IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggbnMxNjU1MF9kdF9tYXRjaFtdIF9faW5pdGNvbnN0 ID0KPiAKCkNoZWVycywKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby94ZW4tZGV2ZWw=