All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Wang Qing <wangqing@vivo.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 2/2] doc: mtk-wdt: support pre-timeout when the bark irq is available
Date: Wed, 21 Apr 2021 20:32:24 -0700	[thread overview]
Message-ID: <c7ec61dc-ae04-6c09-ab26-d432f1d5f13a@roeck-us.net> (raw)
In-Reply-To: <1619059532-17805-3-git-send-email-wangqing@vivo.com>

On 4/21/21 7:45 PM, Wang Qing wrote:
> Add description of pre-timeout in mtk-wdt.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index e36ba60..ae57d6c
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -1,5 +1,8 @@
>  Mediatek SoCs Watchdog timer
>  
> +The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> +before the expiry.
> +

Seems to me the interrupt should be listed as optional property.

Guenter

>  Required properties:
>  
>  - compatible should contain:
> 


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Wang Qing <wangqing@vivo.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	 Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 2/2] doc: mtk-wdt: support pre-timeout when the bark irq is available
Date: Wed, 21 Apr 2021 20:32:24 -0700	[thread overview]
Message-ID: <c7ec61dc-ae04-6c09-ab26-d432f1d5f13a@roeck-us.net> (raw)
In-Reply-To: <1619059532-17805-3-git-send-email-wangqing@vivo.com>

On 4/21/21 7:45 PM, Wang Qing wrote:
> Add description of pre-timeout in mtk-wdt.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index e36ba60..ae57d6c
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -1,5 +1,8 @@
>  Mediatek SoCs Watchdog timer
>  
> +The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> +before the expiry.
> +

Seems to me the interrupt should be listed as optional property.

Guenter

>  Required properties:
>  
>  - compatible should contain:
> 


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Wang Qing <wangqing@vivo.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	 Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 2/2] doc: mtk-wdt: support pre-timeout when the bark irq is available
Date: Wed, 21 Apr 2021 20:32:24 -0700	[thread overview]
Message-ID: <c7ec61dc-ae04-6c09-ab26-d432f1d5f13a@roeck-us.net> (raw)
In-Reply-To: <1619059532-17805-3-git-send-email-wangqing@vivo.com>

On 4/21/21 7:45 PM, Wang Qing wrote:
> Add description of pre-timeout in mtk-wdt.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index e36ba60..ae57d6c
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -1,5 +1,8 @@
>  Mediatek SoCs Watchdog timer
>  
> +The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> +before the expiry.
> +

Seems to me the interrupt should be listed as optional property.

Guenter

>  Required properties:
>  
>  - compatible should contain:
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-22  3:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  2:45 [PATCH V6 0/2] watchdog: mtk: support pre-timeout when the bark irq is available Wang Qing
2021-04-22  2:45 ` Wang Qing
2021-04-22  2:45 ` Wang Qing
2021-04-22  2:45 ` [PATCH V6 1/2] " Wang Qing
2021-04-22  2:45   ` Wang Qing
2021-04-22  2:45   ` Wang Qing
2021-04-22  3:31   ` Guenter Roeck
2021-04-22  3:31     ` Guenter Roeck
2021-04-22  3:31     ` Guenter Roeck
2021-04-22  3:46     ` 王擎
2021-04-22  3:46       ` 王擎
2021-04-22  3:46       ` 王擎
2021-04-22  4:02       ` Guenter Roeck
2021-04-22  4:02         ` Guenter Roeck
2021-04-22  4:02         ` Guenter Roeck
2021-04-22  7:05         ` 王擎
2021-04-22  7:05           ` 王擎
2021-04-22  7:05           ` 王擎
2021-04-22 13:56           ` Guenter Roeck
2021-04-22 13:56             ` Guenter Roeck
2021-04-22 13:56             ` Guenter Roeck
2021-04-22  2:45 ` [PATCH V6 2/2] doc: mtk-wdt: " Wang Qing
2021-04-22  2:45   ` Wang Qing
2021-04-22  2:45   ` Wang Qing
2021-04-22  3:32   ` Guenter Roeck [this message]
2021-04-22  3:32     ` Guenter Roeck
2021-04-22  3:32     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7ec61dc-ae04-6c09-ab26-d432f1d5f13a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wangqing@vivo.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.