From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbdC0Nrj (ORCPT ); Mon, 27 Mar 2017 09:47:39 -0400 Received: from mail-ve1eur01on0103.outbound.protection.outlook.com ([104.47.1.103]:44576 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752892AbdC0NrK (ORCPT ); Mon, 27 Mar 2017 09:47:10 -0400 Authentication-Results: windriver.com; dkim=none (message not signed) header.d=none;windriver.com; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero To: Johan Hovold , Greg Kroah-Hartman References: <1490617069-13119-1-git-send-email-peda@axentia.se> <1490617069-13119-12-git-send-email-peda@axentia.se> <20170327130653.GA15708@localhost> CC: Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , , , , , , Andrew Morton , Colin Ian King , Paul Gortmaker From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Mon, 27 Mar 2017 15:46:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170327130653.GA15708@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: DB6PR0601CA0029.eurprd06.prod.outlook.com (10.169.209.15) To DB6PR0202MB2552.eurprd02.prod.outlook.com (10.169.211.10) X-MS-Office365-Filtering-Correlation-Id: 7590fc1b-c082-477e-94b4-08d47517b92b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423045);SRVR:DB6PR0202MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;3:rx8LOBJLnFp1TjwTdhxkQSAs40MNgkB+CAoFIxae+lBtATZD2oYjfjWgQInNMGNcfmyP1PckHLsHDzzlW9c8PEh24uVFqyylxwsotGeRSWNmraV+2cIiTW4pB2PVjWPprK5cB9SpXsag9K7o9o638biaIWVUMnCOXVIUHUEXaT8486O7+f4awUoo989ptYxbBItu3XCP0bf4JpnlKQ6z7Cd7Vw70SueboWdstGLmR3KxjhDQLk8q2gBqlxUePVlgaEQRLI2TQb/luYELK4ABKZahi/oWNM2jnHpGDqw1tYorMp7HmRMPAK3o3FVyf5+4;25:lNjvRSfoeMn6o21qOha1GvDNAtfUFNe+q4ovJMNSvL3GZ/UvyIciasIqr1+IkLNrGlHkHwfPMAvYl39lLqLg3an8OCpSitpC7HOq71pJ2+9HLU9fnxl71JSoc2mF+/YQRl/qtQIWqfaxP22+roNkkBtJflkDp1o2sisOYGT2kEx7yKCCa682rama14YxwoNFyTdMIEBeZJIDsSptFvLCo0zTfqfL5QDIE4O8QRv3EE1+uGF0uiovYUEPn7Bylx7jI/megSvXuHoChIuJGfoPZXi5ehQo9kFxYRtFbDEfV1xdV23uVD9PBpKTj0FQ0cJUTeKOdRrAFRz+kOmLoUW2Zm0IFB+5EyDWU38PK62Uc/W2084SkbKFq/jdfONHBcqbG0qBvxU6PIO59bE/z2ryBYuUwwAgnLshQVCUzy5bdsC2EBDj/Le8LI57b6w18/VKijAzeHpW/tYZmPKp53DSpw== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;31:hN1H1yiqah/CpEA/eAIBQ1nPVuO8egksJQh+NkpyIyqbsxk/M6O8lToFxPATv0Au761iB4CXOmlEvY+bOgI3xOKKGhyr+F+k8cEqIojGvf8rZPB+h2gc40dQgWyqsyUUvARlJMqOb9bPHEJxkZHP0AtEsPjyr7Bhb2BPVRAABmaU+OtF6YWVpoIcQiSloHwr1Fpb6CKdsyHwxR+OFTk6d0UuGYhtrcVLY5vIZdAbuSNLflgMzS+ONxM6vhuw+Epp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040420)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(2016111802025)(20161123560025)(20161123558025)(201703131423045)(201702281528045)(201703061421045)(201703061406045)(20161123562025)(20161123555025)(20161123564025)(6072148)(6043046);SRVR:DB6PR0202MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0202MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;4:iQDbjJv5ofhMCbI12RFHoyk9RjCB5ijf48HimruMiyiMPx9ZnRKkHXwMAAZsGVuIJWiewOGnMRpIvsGlOvlbz7LQKP9xR+vpxrYceNKaiuTBqJjqnFdKSYpcBmSLXoEetxmy/Vb89GG8mue8GctWZymM4eOx7PRb+21vp+50AUWiZJpCHcUAJMq4lg/Tl+GxQqficdCC8lGVZMXcUAFesnHsVRVFT+83tQpSNfjIavnJWH4F/qpIdlC+wcGdR2SQZX+cIJDoHgs/LHRAdo1QEbF8ogGN670CkESHScWRUg3/IpYNirIPZgpSuh7WcReziXSYMNkOlqqe5WK83tluIGlaFXt73ChtX3Rtu2nE5WMU9Hnp/BTjfdYiyvOpnFRNHnBslkqNPSooDYq/2sHbNtcj+fn+DaNQjJPBaotilG3uxVglRLM8coI3cJZPqJvx7bVMyXG7cIpC+VnjygDnePaB50zkbXJTJCMfcxYww+MYRk8IujSfs7IkkqzP+z6F9LhhY4VkysgXij8yPsPcmFQ6ToH6f3xHRqBj6IwuLrwAOEphS8VS5ONqJ9+kntdf9bUA+mVdgX20nelCAjyNOwiODA3tFmOtFeaapPcbIcKpR+mrYxO+3LjnzXJucHCVZPdcft4YNSiOIpRPwFRYdR3Uc51TfaSk4aZEvoFXf0YcGoZJzdxv3xpzUDYt/oKcYPYQrB7lCMOIX5ce8DAWNhhz2WDCrmxKTxhQyRaqA6A3xdBaOpE14ogAAn0qd/W4bnXtNPt3e+WfQ031O0o4Kf+dmaYK0xeezCdrF5pv/eA= X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39410400002)(39830400002)(39450400003)(377424004)(24454002)(50466002)(7416002)(31696002)(53546009)(65956001)(6246003)(38730400002)(36756003)(47776003)(23746002)(189998001)(83506001)(8666007)(53936002)(2906002)(229853002)(6486002)(4326008)(65806001)(117156001)(77096006)(305945005)(4001350100001)(33646002)(2950100002)(64126003)(42186005)(230700001)(65826007)(7736002)(81166006)(3846002)(31686004)(25786009)(54906002)(54356999)(76176999)(86362001)(6116002)(74482002)(8676002)(50986999)(6666003)(5660300001)(66066001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0202MB2552;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0202MB2552;23:G7mYx1b8yng16q0zoDvJ+BDNYKeOZxGNsv1?= =?Windows-1252?Q?XcmQiK77AZKazBiiSrjGN1GSic/YEpuEaQmXNDTwWgkGCSjuEvCVwQAG?= =?Windows-1252?Q?h16vQcXfxI9yidzG/F683cdE7xiHnw+MoPgBeAWCQL0PaWSeg5fc6zcS?= =?Windows-1252?Q?3+DlPhoOZ6oDdaAvq+G40lOfeU4rfjkurVuILn4kNgEEtHoT0TGgJc7B?= =?Windows-1252?Q?XFkaJ8CblmtO70Ww2xlNulRGrDl3R3JtZlvW7nIbl/2oRAbVdfnQpZhA?= =?Windows-1252?Q?OGIuQYxcEnb3JsxJSh1i3oESNeVaSoBeqF04DP83efhwqT3+JF4t4oon?= =?Windows-1252?Q?KHxfPT4WqGq2rVj/bxg6h1NXKaZkazhapWq9hdwLc7/k45XUFkm9j7Cy?= =?Windows-1252?Q?4D4BYBbYA80mofPwT3wtwylRC1bJB2ijPdZbptjNIRERXt994VSgMrwl?= =?Windows-1252?Q?pNb+sfLngj9NzWPGP10cxp5C/dY/KOH+AIkxIXitZDwVJPP0FTXIYj53?= =?Windows-1252?Q?STjWXUn2KujlG7uz30CFV/+9hgSy50aTpdtVRvRcoafkNldKx/bqAcOd?= =?Windows-1252?Q?Ha2ev+XQqpGKr5XC73/jVU23sKqw3mHH5co2A3tMKfhqzzSihVUd639W?= =?Windows-1252?Q?g+o2YXqRzpbZnNx/wzJrSSRA6fAOUAQzhBggIrbLCmrHMroW2DXhYM/D?= =?Windows-1252?Q?KdZftQvx2tJ21eNbz4vyMrwSFvIw6Px5COaCwhpazDtrJ8aXOpX4WgbR?= =?Windows-1252?Q?u/6Rw2P+IzUIb/XZI+Lkkh/m0h7t6C+9qRFhgtiV5stpLMKcQ3XhINOf?= =?Windows-1252?Q?QVffKfWT5LoPY13MoZeRyRsw43t+JrRfuzYQ8e9gX2EMoDpOh3WYFW44?= =?Windows-1252?Q?Lc731zoPHkjqmzlwi4akmInKR0++zOlfJKp9DAhscvW3ILoz66/Wcozl?= =?Windows-1252?Q?JPDODGyFibwQhNJJN4GVPS/oBJtCr7cnT4hYOkU8Qs5oAyiNml1zOhmg?= =?Windows-1252?Q?knSwPObLIrTtsLqv4o0NhleK9fpgSG2TtkrI16rkAKWYc5GIruAOSyNT?= =?Windows-1252?Q?JO0dgCbQ2PQjt9rKsPe4YyXsHvTB5XBeGLQVcExz/s5sIpG4w2jHFdLi?= =?Windows-1252?Q?d0jtBloWhuZxQ5ppj8ux8xYNEoEXUZsSNsc1VRO3mram4OmBZSxi7c5C?= =?Windows-1252?Q?FIx+8N1NcJkAhRXBvwKNFzrljdjieC7JHna7SPu0IZNNAP4I56KHq7Os?= =?Windows-1252?Q?+dDAxkc+icHSAVEzAEmWu/hrYo+psRHIV2ZoLQfWwiQB4jXtdiv0Rozr?= =?Windows-1252?Q?2cjhDs/uSrd1/vg2NdMm4+QdugtiAFT5f8RLOY4rYQkZx3Y5yukGY3dp?= =?Windows-1252?Q?X1HbT/Wbm5CeofWNfDM/Pl1vVIx2/yqSqjaT/jBrh0dvrCJ7F3jHPKpW?= =?Windows-1252?Q?1FRQIYdq6MFrNtH9OJ/4p?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;6:NIAL+ZqWIZfz+A3NW/3Dq9+5r6X/mD6b62AAd9nARzKDDCOrw9IZmL09Z2OBqJ5nH4kZROPoVI/P6ZOOGUCmoiLSFNmIfCox48b+yTI/ufVuewqSkY1ESeNjYlaPh9BQVuZAr7W6I5/88k5spJ158LFhCU/o6YlOO0Qg2E7qbKE+eY7MAcBxLXMHn0pL8O3JL6dfb1IgxVscg5q0HT0U0KUoiVSIGPPnSoonq1h56PgLKPfzvyf5zQBGdU3ix401Rsc9pG7lfXDKqC3AI3zj/huKt+9ItcqzqcPHHrZbEEM9jqejinlfUAEWWKGmo2DZYLw4foIWm+eo+B1BQPEqrq5VDegW03VjWK66ZnyuzzQruTyL7dqA03BGiZYlRp2E03LR4wf4l7Gj+tOAJ6O9JQ==;5:lcPS0LLD9oz51gmMWxKbJryv8zcMO/fz1CVVbP+kMB611k9Imzsmpj6QaqUB1CxS1E0l62p8qfPIc+JAX9E22d0DOiItVD1CPhII86IMc6/T1mkqZ+Y2jaVCdTjXvL4CO3ZSAGLJQc1VNjaEmncGhA==;24:lqVjUkk2NyLzQsrYqJBUwHgWnxtYiJHqy9jaWWlprN9MnWibPjLI03/YbsjlFf23ND2SK91KCR6inbr7W0jwiFbRAVrAS26Tb2PcHVqgmSM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;7:/ebNOZ1HnFMmxMTuyTaneWO4L5xao2mTSfWwVoKw0NeG8La4wzT+zXA88wr2vkW+jUQbfpww+4/fBU6XPIByItIP4n+Y6xlT5OROkIgbm/rVH0Au2cUjkKxOk2je0koC+PcpVIXayX3xkYyg7glIEZ3U8dnzPfzPMl7iQt26isNCRVF/AF1IJ2VVOBaEL6dzwj4wqDkUOgXsuope/QpCrxLLm5ofap9BsqgyqrhYRD9NibQPNB52YNz4+n4+SyMkYk0NHkyvK7JrQeSA/2EDmPW23vowrVxpvIK8dUpXrhCEW3ZevSYUB7mXg1mwCDOq3L8Shhw984GF5QYz5xpbcg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 13:46:50.0817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0202MB2552 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-03-27 15:06, Johan Hovold wrote: > On Mon, Mar 27, 2017 at 02:17:48PM +0200, Peter Rosin wrote: >> Comparing a size_t with less than zero is always false as size_t >> is unsigned. So, change the type of the variable to ssize_t and >> replicate the size check from mux_configure_channel() into >> mux_write_ext_info() thus ensuring that the size will fit in the >> ssize_t variable. >> >> Detected by CoverityScan, CID#1415278 ("Unsigned compared against 0") >> >> Fixes: 1da8e16d2812 ("iio: multiplexer: new iio category and iio-mux driver") > > You should fold this one and the next patch into the patches that they > fix up instead fixing stuff that's not yet merged incrementally like you > do here (specifically, the SHA id above will have no matching commit). > > Johan I forgot about that. And similar for the next patch. But how do you propose that I attribute the reporters and CoverityScan? Crap, it would have been so much easier if the series was just pulled they way I expected it... Greg, how do you want to play this? Can you perhaps update the fixes tag here and in 12/12 if/when you apply the series? Cheers, peda From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Rosin Subject: Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero Date: Mon, 27 Mar 2017 15:46:47 +0200 Message-ID: References: <1490617069-13119-1-git-send-email-peda@axentia.se> <1490617069-13119-12-git-send-email-peda@axentia.se> <20170327130653.GA15708@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170327130653.GA15708@localhost> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Hovold , Greg Kroah-Hartman Cc: Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Colin Ian King , Paul Gortmaker List-Id: devicetree@vger.kernel.org On 2017-03-27 15:06, Johan Hovold wrote: > On Mon, Mar 27, 2017 at 02:17:48PM +0200, Peter Rosin wrote: >> Comparing a size_t with less than zero is always false as size_t >> is unsigned. So, change the type of the variable to ssize_t and >> replicate the size check from mux_configure_channel() into >> mux_write_ext_info() thus ensuring that the size will fit in the >> ssize_t variable. >> >> Detected by CoverityScan, CID#1415278 ("Unsigned compared against 0") >> >> Fixes: 1da8e16d2812 ("iio: multiplexer: new iio category and iio-mux driver") > > You should fold this one and the next patch into the patches that they > fix up instead fixing stuff that's not yet merged incrementally like you > do here (specifically, the SHA id above will have no matching commit). > > Johan I forgot about that. And similar for the next patch. But how do you propose that I attribute the reporters and CoverityScan? Crap, it would have been so much easier if the series was just pulled they way I expected it... Greg, how do you want to play this? Can you perhaps update the fixes tag here and in 12/12 if/when you apply the series? Cheers, peda -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html