From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C70C433EF for ; Mon, 31 Jan 2022 00:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235231AbiAaAs0 (ORCPT ); Sun, 30 Jan 2022 19:48:26 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:18959 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233273AbiAaAsZ (ORCPT ); Sun, 30 Jan 2022 19:48:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1643590103; x=1675126103; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SCkBzve2s8PzHUJlrNqkRFHShNqLksqCk6FrPrsuKd8=; b=CDncSClAr9I7QqUEywZldn1DbLDWlYYB7MwuS63ctmbJqz1wQGnDGO8o 3QmwHd5lOUa0c3uOP1drfWJbCfBA+idn3qBL5wK88ZET8E2Vwt9Hx82eF TadUJZ53m5ANkysLBL29zm7kODkqnTrUl/dotgcD6f6AWBeCKzbNulQnU XfqZ77clacg/DG9Av+lYkeKJIXRTdNqB1IQHpKE4vTVLxHfg8Ss0rGNtG nm9hJPocYUvYy+ygASKf5qJa4npVEXlu5OyZd6DK3xnTTfSP8we0uEpvF rLLu++4dE1MAjGCnaPF4V886jyRCKmyyv0UqhyllhZ2u9HEAHvTPYw5o5 Q==; X-IronPort-AV: E=Sophos;i="5.88,329,1635177600"; d="scan'208";a="191761532" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 31 Jan 2022 08:48:23 +0800 IronPort-SDR: KWUFW7nS8Rw2SsQO1HZ8Oz5H/j6tcnrws3TbA7Ffs+CRkndQwLuikdpfWPeKJ8Ay+tqc8IfJpY XYu4zisHFEX1b4UEu30qEVvwY2zfOGLwi+MJmdmE7tOTpdhg47XKbQT8xVrB9MsqhlWkmbcR5x OOU9WMyPxwPyCVfOz5X/WcR7qjkhVjZVYwS2ICqxgU56W9xxC8sRc9K99RZE04dfNnLd+6GoXG R5gwG3giIxUQun/IWDaSiZi1E5UwUZBxP8tl2W9g6EH+tj1aRX/pP4OM3uzj9LbV12ElbYGX9S qL4P5FIU/BeOm8338fZ9BI/x Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2022 16:20:25 -0800 IronPort-SDR: 0sKEvkqkSMIucQ1v5gZI4SAagxYn2GHwd+5zzXAfq9W+xvAn/WPjmNZRGlvte9XzFdOUIaRmFE xUIg5rgW8qbflHubi5XKryExR/yWou0/bdlDfcEHufbJTRjOWnJRGIMkPCLdZHr+BjFfb+8QUx AnUVyvNk0d+P1yYvhdr8R8ouvdqytK9GgFEctIeVCAsBIVn53w059TzSJZUID+N7uWPtwBJxxj 7fepPaWOERfSjkrwTfCbtEWgpQbnWrbbpMF/4j2P8srrR3w4JkGfwO561Zwj+k4C5pwbK/b+ZK VYc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2022 16:48:25 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Jn8Z02sypz1SVp1 for ; Sun, 30 Jan 2022 16:48:24 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1643590103; x=1646182104; bh=SCkBzve2s8PzHUJlrNqkRFHShNqLksqCk6F rPrsuKd8=; b=lJ3tOCc4tZpbgFtTON19O0WRIzoWBC2gp0MAnacpLYhTYmRm1O3 K9XNo9avga72zSwYUbprWkIwPhINGmPhp3lb5+qv3hVSNC9XPycC8COFeMrHg8mz /9v4xNeGc0ymG0XLwy79neGEKGBaARU/nwj5UqA51jRl59f3MfKBnxevs1W3Q50W 8DL7Hztnaea9Rxy2E3uAa2gQumJwxCDMxqfuL2+t8prMJaQQwbJBXIomQTiMpOTR gbZ1CZaq8Jscnsbo8XjRLNWKXoxe9b/hHv+IawMTigGannSyHVAK/Pd4PQyBOh/L iMhePZlf16qc7jzMe0UTBzi8+vnTF+XY8dA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xj6svorPklFo for ; Sun, 30 Jan 2022 16:48:23 -0800 (PST) Received: from [10.225.54.48] (unknown [10.225.54.48]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Jn8Yy2yw8z1RvlN; Sun, 30 Jan 2022 16:48:22 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 09:48:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] dt-bindings: ata: convert ata/cortina,gemini-sata-bridge to yaml Content-Language: en-US To: Corentin Labbe , linus.walleij@linaro.org, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220129204004.1009571-1-clabbe@baylibre.com> From: Damien Le Moal Organization: Western Digital In-Reply-To: <20220129204004.1009571-1-clabbe@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2022/01/30 5:40, Corentin Labbe wrote: > This patch converts ata/cortina,gemini-sata-bridge binding to yaml > > Signed-off-by: Corentin Labbe > --- > .../ata/cortina,gemini-sata-bridge.txt | 55 ---------- > .../ata/cortina,gemini-sata-bridge.yaml | 100 ++++++++++++++++++ > 2 files changed, 100 insertions(+), 55 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt > create mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml > > diff --git a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt > deleted file mode 100644 > index 1c3d3cc70051..000000000000 > --- a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt > +++ /dev/null > @@ -1,55 +0,0 @@ > -* Cortina Systems Gemini SATA Bridge > - > -The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that > -takes two Faraday Technology FTIDE010 PATA controllers and bridges > -them in different configurations to two SATA ports. > - > -Required properties: > -- compatible: should be > - "cortina,gemini-sata-bridge" > -- reg: registers and size for the block > -- resets: phandles to the reset lines for both SATA bridges > -- reset-names: must be "sata0", "sata1" > -- clocks: phandles to the compulsory peripheral clocks > -- clock-names: must be "SATA0_PCLK", "SATA1_PCLK" > -- syscon: a phandle to the global Gemini system controller > -- cortina,gemini-ata-muxmode: tell the desired multiplexing mode for > - the ATA controller and SATA bridges. Values 0..3: > - Mode 0: ata0 master <-> sata0 > - ata1 master <-> sata1 > - ata0 slave interface brought out on IDE pads > - Mode 1: ata0 master <-> sata0 > - ata1 master <-> sata1 > - ata1 slave interface brought out on IDE pads > - Mode 2: ata1 master <-> sata1 > - ata1 slave <-> sata0 > - ata0 master and slave interfaces brought out > - on IDE pads > - Mode 3: ata0 master <-> sata0 > - ata0 slave <-> sata1 > - ata1 master and slave interfaces brought out > - on IDE pads > - > -Optional boolean properties: > -- cortina,gemini-enable-ide-pins: enables the PATA to IDE connection. > - The muxmode setting decides whether ATA0 or ATA1 is brought out, > - and whether master, slave or both interfaces get brought out. > -- cortina,gemini-enable-sata-bridge: enables the PATA to SATA bridge > - inside the Gemnini SoC. The Muxmode decides what PATA blocks will > - be muxed out and how. > - > -Example: > - > -sata: sata@46000000 { > - compatible = "cortina,gemini-sata-bridge"; > - reg = <0x46000000 0x100>; > - resets = <&rcon 26>, <&rcon 27>; > - reset-names = "sata0", "sata1"; > - clocks = <&gcc GEMINI_CLK_GATE_SATA0>, > - <&gcc GEMINI_CLK_GATE_SATA1>; > - clock-names = "SATA0_PCLK", "SATA1_PCLK"; > - syscon = <&syscon>; > - cortina,gemini-ata-muxmode = <3>; > - cortina,gemini-enable-ide-pins; > - cortina,gemini-enable-sata-bridge; > -}; > diff --git a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml > new file mode 100644 > index 000000000000..ff27e4884e21 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/cortina,gemini-sata-bridge.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cortina Systems Gemini SATA Bridge > + > +maintainers: > + - Linus Walleij > + > +description: | > + The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that > + takes two Faraday Technology FTIDE010 PATA controllers and bridges > + them in different configurations to two SATA ports. > + > +properties: > + compatible: > + const: "cortina,gemini-sata-bridge" > + reg: > + minItems: 1 > + resets: > + minItems: 2 > + description: phandles to the reset lines for both SATA bridges > + reset-names: > + items: > + - const: "sata0" > + - const: "sata1" > + clocks: > + minItems: 2 > + description: phandles to the compulsory peripheral clocks > + clock-names: > + items: > + - const: "SATA0_PCLK" > + - const: "SATA1_PCLK" > + syscon: > + minItems: 1 > + $ref: /schemas/types.yaml#/definitions/phandle > + description: a phandle to the global Gemini system controller s/a phandle/phandle ? Saying "a phandle" seems to imply that there may be many. I am not sure here though. > + cortina,gemini-ata-muxmode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 > + - 1 > + - 2 > + - 3 > + description: | > + tell the desired multiplexing mode for the ATA controller and SATA bridges. Values 0..3: Nit: Start the sentence with an uppercase "Tell...". > + Mode 0: ata0 master <-> sata0 > + ata1 master <-> sata1 > + ata0 slave interface brought out on IDE pads > + Mode 1: ata0 master <-> sata0 > + ata1 master <-> sata1 > + ata1 slave interface brought out on IDE pads > + Mode 2: ata1 master <-> sata1 > + ata1 slave <-> sata0 > + ata0 master and slave interfaces brought out on IDE pads > + Mode 3: ata0 master <-> sata0 > + ata0 slave <-> sata1 > + ata1 master and slave interfaces brought out on IDE pads > + > + cortina,gemini-enable-ide-pins: > + type: boolean > + description: enables the PATA to IDE connection. Same here. > + The muxmode setting decides whether ATA0 or ATA1 is brought out, > + and whether master, slave or both interfaces get brought out. > + cortina,gemini-enable-sata-bridge: > + type: boolean > + description: enables the PATA to SATA bridge Ditto. And the line break is a little early. The first line could be longer so that everything fits in 2 lines. > + inside the Gemnini SoC. The Muxmode decides what PATA blocks will > + be muxed out and how. > + > +required: > + - clocks > + - clock-names > + - cortina,gemini-ata-muxmode > + - resets > + - reset-names > + - compatible > + - reg > + - syscon > + > +additionalProperties: false > + > +examples: > + - | > + #include > + sata: sata@46000000 { > + compatible = "cortina,gemini-sata-bridge"; > + reg = <0x46000000 0x100>; > + resets = <&rcon 26>, <&rcon 27>; > + reset-names = "sata0", "sata1"; > + clocks = <&gcc GEMINI_CLK_GATE_SATA0>, > + <&gcc GEMINI_CLK_GATE_SATA1>; > + clock-names = "SATA0_PCLK", "SATA1_PCLK"; > + syscon = <&syscon>; > + cortina,gemini-ata-muxmode = <3>; > + cortina,gemini-enable-ide-pins; > + cortina,gemini-enable-sata-bridge; > + }; With the above cosmetic nits addressed (if necessary): Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research