From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5831C07E9B for ; Mon, 19 Jul 2021 15:32:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D16C61222 for ; Mon, 19 Jul 2021 15:32:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D16C61222 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5VFQ-0001ce-IZ for qemu-devel@archiver.kernel.org; Mon, 19 Jul 2021 11:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5VDQ-00007y-Hj for qemu-devel@nongnu.org; Mon, 19 Jul 2021 11:29:56 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:40386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5VDO-0000Hn-AG for qemu-devel@nongnu.org; Mon, 19 Jul 2021 11:29:55 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E02821FD40; Mon, 19 Jul 2021 15:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626708589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P/V+9QA1VKLocz2g4TdM+Mw9IKFJ80s2pl2HqvARNl0=; b=f0kRVOiIWLZeyyMmtTZLJ4WZsj4U7CNDgw/8xaEnP5xd9N8gOLuWg/S4I/xDvS+im7ReCl qNMv11C62Bx1TZuQLEZ6dE2lgXdS+DM5pjeOeJICLoEqEwK8uD3pZ9mDftAx2xNptkD7NN vMnkjuz4cMqKDbEvC9Aw1+oh2XxcdKM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626708589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P/V+9QA1VKLocz2g4TdM+Mw9IKFJ80s2pl2HqvARNl0=; b=EBdeDWRDK+21Y/aemYu7PbbfxbnamZA29Doh1mrWlS8r9AI5LFldOi7AvWA3wezeiqUp8N UMym2sDPZAWe/DBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1D2A13D37; Mon, 19 Jul 2021 15:29:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yxqoJW2a9WDKHwAAMHmgww (envelope-from ); Mon, 19 Jul 2021 15:29:49 +0000 Subject: Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name() To: "Jose R. Ziviani" , qemu-devel@nongnu.org References: <20210630232749.21873-1-jziviani@suse.de> <20210630232749.21873-4-jziviani@suse.de> From: Claudio Fontana Message-ID: Date: Mon, 19 Jul 2021 17:29:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210630232749.21873-4-jziviani@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, berrange@redhat.com, ehabkost@redhat.com, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/1/21 1:27 AM, Jose R. Ziviani wrote: > module_object_class_by_name() calls module_load_qom_one if the object > is provided by a dynamically linked library. Such library might not be > available at this moment - for instance, it can be a package not yet > installed. Thus, instead of assert error messages, this patch outputs > more friendly messages. > > Current error messages: > $ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz > ... > ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion failed: (ops != NULL) > Bail out! ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion failed: (ops != NULL) > [1] 31964 IOT instruction (core dumped) ./qemu-system-x86_64 ... > > New error message: > $ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz > accel-tcg-x86_64 module is missing, install the package or config the library path correctly. > > $ make check > ... > Running test qtest-x86_64/test-filter-mirror > Running test qtest-x86_64/endianness-test > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-qtest-x86_64 module is missing, install the package or config the library path correctly. > accel-tcg-x86_64 module is missing, install the package or config the library path correctly. > ... > > Signed-off-by: Jose R. Ziviani > --- > qom/object.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/qom/object.c b/qom/object.c > index 6a01d56546..2d40245af9 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -1024,6 +1024,24 @@ ObjectClass *object_class_by_name(const char *typename) > return type->class; > } > > +char *get_accel_module_name(const char *ac_name); > + > +char *get_accel_module_name(const char *ac_name) > +{ > + size_t len = strlen(ac_name); > + char *module_name = NULL; > + > + if (strncmp(ac_name, "tcg-accel-ops", len) == 0) { > +#ifdef CONFIG_TCG_MODULAR > + module_name = g_strdup_printf("%s%s", "accel-tcg-", "x86_64"); > +#endif > + } else if (strncmp(ac_name, "qtest-accel-ops", len) == 0) { > + module_name = g_strdup_printf("%s%s", "accel-qtest-", "x86_64"); > + } > + > + return module_name; > +} > + > ObjectClass *module_object_class_by_name(const char *typename) > { > ObjectClass *oc; > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_class_by_name(const char *typename) > oc = object_class_by_name(typename); > #ifdef CONFIG_MODULES > if (!oc) { > + char *module_name; > module_load_qom_one(typename); > oc = object_class_by_name(typename); > + module_name = get_accel_module_name(typename); > + if (module_name) { > + if (!module_is_loaded(module_name)) { > + fprintf(stderr, "%s module is missing, install the " > + "package or config the library path " > + "correctly.\n", module_name); > + g_free(module_name); > + exit(1); > + } > + g_free(module_name); > + } > } > #endif > return oc; > Hi Jose, this inserts accel logic into module_object_class_by_name, maybe some other place would be better to insert this check, like when trying to select an accelerator? Thanks, CLaudio