All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Hillf Danton <hdanton@sina.com>,
	syzbot <syzbot+c18f2f6a7b08c51e3025@syzkaller.appspotmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] possible deadlock in ovl_maybe_copy_up
Date: Tue, 22 Jun 2021 07:40:53 -0400	[thread overview]
Message-ID: <c8306569f880021bae853caf9f347e7c806ffaaa.camel@linux.ibm.com> (raw)
In-Reply-To: <CAOQ4uxjYJTG3p2ALXAWnAY+6Kmoi_L0=Z42okT6R+ovzQ7dQoQ@mail.gmail.com>

> > Should annotating the iint be limited to files on overlay filesystems?
> >
> 
> Not to overlay files specifically but to files on stacked fs,
> i.e. (inode->i_sb->s_stack_depth > 0)
> Assuming that this patch is tested(?), how come it did not hit the
> WARN_ON_ONCE(depth < 0... above?

Thanks, Amir!

As per the overlayfs comment, the depth can never be 0.  It sounds like
in this case we only want to annotate the iint mutex for regular files,
if the stacking depth is greater than 0, but less than the max depth.

(I'm still trying to reproduce the lockdep.)

Mimi


  reply	other threads:[~2021-06-22 11:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 10:05 possible deadlock in ovl_maybe_copy_up syzbot
2021-04-03 19:18 ` [syzbot] " syzbot
2021-04-04  8:10   ` Amir Goldstein
     [not found]   ` <20210618040135.950-1-hdanton@sina.com>
2021-06-22  2:32     ` Mimi Zohar
2021-06-22  4:51       ` Amir Goldstein
2021-06-22 11:40         ` Mimi Zohar [this message]
     [not found]       ` <20210622065340.1322-1-hdanton@sina.com>
2021-06-22  8:53         ` Amir Goldstein
2023-06-06  9:30 ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8306569f880021bae853caf9f347e7c806ffaaa.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=amir73il@gmail.com \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+c18f2f6a7b08c51e3025@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.