From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pankaj.dubey" Subject: Re: [PATCH v9 04/12] soc: samsung: add exynos chipid driver support Date: Mon, 3 Apr 2017 14:51:33 +0530 Message-ID: References: <1490879826-16754-1-git-send-email-pankaj.dubey@samsung.com> <1490879826-16754-5-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:61023 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751952AbdDCJSV (ORCPT ); Mon, 3 Apr 2017 05:18:21 -0400 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by epoutp01.samsung.com (KnoxPortal) with ESMTP id 20170403091819epoutp011b59ba8eeb1951cecc91c5e5104b1252~x2JgUp-vr3046130461epoutp01X for ; Mon, 3 Apr 2017 09:18:19 +0000 (GMT) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Arnd Bergmann Cc: linux-samsung-soc@vger.kernel.org, Linux ARM , Krzysztof Kozlowski , Marek Szyprowski , Kukjin Kim , m.reichl@fivetechno.de, a.hajda@samsung.com, cwchoi00@gmail.com, Javier Martinez Canillas , Grant Likely , Rob Herring , Linus Walleij On Friday 31 March 2017 01:39 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 7:36 AM, pankaj.dubey wrote: >> Hi Arnd, >> >> On Thursday 30 March 2017 07:20 PM, Arnd Bergmann wrote: >>> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey wrote: >>>> >>>> +config EXYNOS_CHIPID >>>> + bool "Exynos Chipid controller driver" if COMPILE_TEST >>>> + depends on ARCH_EXYNOS || COMPILE_TEST >>>> + select SOC_BUS >>> >>> This lets you disable the driver when COMPILE_TEST is set on exynos, >>> which is probably not what you wanted. >>> >> >> Sorry I could not get this point. EXYNOS_CHIPID is invisible menu >> option, when I enabled COMPILE_TEST, option is visible in make >> menuconfig but it does not allow to disable this driver. I have adopted >> this config same as EXYNOS_PMU in the same file. > > I wrote my comment before I saw the 'select' statement in the later > patch. With that select, it is not a problem. > >>> bool "Exynos Chipid controller driver" if COMPILE_TEST && !ARCHEXYNOS >>> default ARCH_EXYNOS >> >> I can adopt, default ARCH_EXYNOS, which will allow me to drop patch 5/12 >> and 6/12. > > Either way (select or default) is fine, just do the same thing for both chipid > and pmu. If you keep the 'select' and the 'if COMPILE_TEST', you can > drop the line 'depends on ARCH_EXYNOS || COMPILE_TEST'. > OK, I understood your point. Thanks. Pankaj Dubey > Arnd > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: pankaj.dubey@samsung.com (pankaj.dubey) Date: Mon, 3 Apr 2017 14:51:33 +0530 Subject: [PATCH v9 04/12] soc: samsung: add exynos chipid driver support In-Reply-To: References: <1490879826-16754-1-git-send-email-pankaj.dubey@samsung.com> <1490879826-16754-5-git-send-email-pankaj.dubey@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 31 March 2017 01:39 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 7:36 AM, pankaj.dubey wrote: >> Hi Arnd, >> >> On Thursday 30 March 2017 07:20 PM, Arnd Bergmann wrote: >>> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey wrote: >>>> >>>> +config EXYNOS_CHIPID >>>> + bool "Exynos Chipid controller driver" if COMPILE_TEST >>>> + depends on ARCH_EXYNOS || COMPILE_TEST >>>> + select SOC_BUS >>> >>> This lets you disable the driver when COMPILE_TEST is set on exynos, >>> which is probably not what you wanted. >>> >> >> Sorry I could not get this point. EXYNOS_CHIPID is invisible menu >> option, when I enabled COMPILE_TEST, option is visible in make >> menuconfig but it does not allow to disable this driver. I have adopted >> this config same as EXYNOS_PMU in the same file. > > I wrote my comment before I saw the 'select' statement in the later > patch. With that select, it is not a problem. > >>> bool "Exynos Chipid controller driver" if COMPILE_TEST && !ARCHEXYNOS >>> default ARCH_EXYNOS >> >> I can adopt, default ARCH_EXYNOS, which will allow me to drop patch 5/12 >> and 6/12. > > Either way (select or default) is fine, just do the same thing for both chipid > and pmu. If you keep the 'select' and the 'if COMPILE_TEST', you can > drop the line 'depends on ARCH_EXYNOS || COMPILE_TEST'. > OK, I understood your point. Thanks. Pankaj Dubey > Arnd > > >