From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FC4C433E2 for ; Mon, 14 Sep 2020 14:30:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B552206C9 for ; Mon, 14 Sep 2020 14:30:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B552206C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kHpV4-0004VS-RB; Mon, 14 Sep 2020 14:30:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kHpV3-0004VK-Ga for xen-devel@lists.xenproject.org; Mon, 14 Sep 2020 14:30:33 +0000 X-Inumbo-ID: 640f21a1-6cc2-40c2-aeee-aba9e0e08735 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 640f21a1-6cc2-40c2-aeee-aba9e0e08735; Mon, 14 Sep 2020 14:30:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86EFFB39B; Mon, 14 Sep 2020 14:30:47 +0000 (UTC) Subject: Re: [RFC PATCH] efi: const correct EFI functions To: Trammell Hudson References: <20200914142528.897639-1-hudson@trmm.net> Cc: xen-devel@lists.xenproject.org From: Jan Beulich Message-ID: Date: Mon, 14 Sep 2020 16:30:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200914142528.897639-1-hudson@trmm.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 14.09.2020 16:25, Trammell Hudson wrote: > By defining IN as const, the EFI handler functions become almost > const-correct and allow most of the rest of the EFI boot code to > use constant strings. How does this work with combined "IN OUT"? I'm afraid there is a reason why things aren't done the way you suggest. > --- a/xen/include/efi/efidef.h > +++ b/xen/include/efi/efidef.h > @@ -50,7 +50,7 @@ typedef VOID *EFI_EVENT; > // > > #ifndef IN > - #define IN > + #define IN const > #define OUT > #define OPTIONAL > #endif I think the #ifdef here is precisely so you can override the three identifiers without having to touch this (imported) header. We try to keep imported headers as little modified as possible. Jan