From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs Date: Tue, 9 Oct 2018 23:03:49 +0200 Message-ID: References: <20181008211205.2900-1-vz@mleia.com> <20181008211205.2900-2-vz@mleia.com> <5631ac17-a1c1-af12-8b30-314880af42df@gmail.com> <4569f3e3-3812-f423-eda9-51e7a4d56a58@mleia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Vladimir Zapolskiy , Lee Jones , Linus Walleij , Rob Herring Cc: Laurent Pinchart , Wolfram Sang , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sandeep Jain , Vladimir Zapolskiy List-Id: linux-gpio@vger.kernel.org On 10/09/2018 10:55 PM, Vladimir Zapolskiy wrote: > On 10/09/2018 02:11 PM, Vladimir Zapolskiy wrote: >> Hi Marek, >> >> On 10/09/2018 03:13 AM, Marek Vasut wrote: >>> On 10/08/2018 11:11 PM, Vladimir Zapolskiy wrote: >>>> From: Sandeep Jain >>>> >>>> The change adds device tree binding description of TI DS90Ux9xx >>>> series of serializer and deserializer controllers which support video, >>>> audio and control data transmission over FPD-III Link connection. >>>> > > [snip] > >>>> +Optional properties: >>>> +- reg : Specifies the I2C slave address of a local de-/serializer. >>>> +- power-gpios : GPIO line to control supplied power to the device. >>> >>> Shouldn't this be regulator phandle ? >> >> It could be, right. I'll ponder upon it. >> > > No, it can not. > > The property describes PDB "Power-down Mode Input Pin", it is a control > pin with the predefined voltage, so regulator phandle is not applicable > here. Then the DT binding document needs updating, because this is completely unclear and confusing. -- Best regards, Marek Vasut