All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/lvm2: default standard install to y
Date: Thu, 17 Jun 2021 15:04:51 +0200	[thread overview]
Message-ID: <c8486320-9032-33c3-8227-b9baf90af341@mind.be> (raw)
In-Reply-To: <877disd5lk.fsf@dell.be.48ers.dk>



On 17/06/2021 14:43, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> 
>  > Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8
>  > BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the
>  > default read:
> 
>  >       default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11
> 
>  > Since the legacy symbol is normally not selected, this defaults to y.
> 
>  > Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the
>  > entire line instead of just the condition.
> 
>  > Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
>  > For-stable: 2021.02, 2021.05
>  > Cc: dominique.tronche at atos.net
>  > Cc: Yann E. MORIN <yann.morin.1998@free.fr>
>  > Cc: Peter Korsgaard <peter@korsgaard.com>
>  > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>  > --
>  > As an experiment, I added the For-stable tag (which I invented myself).
>  > Peter, is this useful? Should we propose this in the documentation?
> 
> It could be. Typically just mentioning that this is a fix and/or CC me
> is enough, but it cannot hurt certainly.

 I'm mostly thinking about finding out to which stable branches it applies.
Currently, contributors rarely go through the effort of checking that. So the
question is: is it worth your while to ask contributors to check to which stable
branches a fix is applicable?

 I've added "Fixes: <sha1>" tags a few times, but then I realized it doesn't
actually help a lot.

 Regards,
 Arnout

  reply	other threads:[~2021-06-17 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 17:33 Arnout Vandecappelle
2021-06-16 19:07 ` Yann E. MORIN
2021-06-17 12:43 ` Peter Korsgaard
2021-06-17 13:04   ` Arnout Vandecappelle [this message]
2021-06-21 19:59   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8486320-9032-33c3-8227-b9baf90af341@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    --subject='Re: [Buildroot] [PATCH] package/lvm2: default standard install to y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.