From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/10] char: move SpiceChardev and open_spice_port() to spice.h header
Date: Fri, 3 Aug 2018 13:20:51 -0500 [thread overview]
Message-ID: <c8490d50-216b-3c50-7e39-b87a218c48db@redhat.com> (raw)
In-Reply-To: <20180803173614.12358-8-marcandre.lureau@redhat.com>
On 08/03/2018 12:36 PM, Marc-André Lureau wrote:
> This will allow to subclass SpiceChardev easily.
Grammar - 'allow to ${verb}' is not idiomatic; better is 'allow
${verb}ing' or 'allow ${subject} to ${verb}'. Here, I'd write:
This will allow easier subclassing of SpiceChardev.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-08-03 18:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 17:36 [Qemu-devel] [PATCH 00/10] RFC: spice: add -display app to launch external UI Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 01/10] char/spice: trigger HUP event Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 02/10] char/spice: discard write() if backend is disconnected Marc-André Lureau
2018-08-07 15:25 ` Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 03/10] configure: bump spice-server required version to 0.12.6 Marc-André Lureau
2018-08-03 18:17 ` Eric Blake
2018-08-07 10:07 ` Daniel P. Berrangé
2018-08-03 17:36 ` [Qemu-devel] [PATCH 04/10] spice: avoid spice runtime assert Marc-André Lureau
2018-08-07 13:47 ` Gerd Hoffmann
2018-11-28 11:04 ` Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 05/10] spice: merge options lists Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 06/10] spice: do not stop spice if VM is paused Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 07/10] char: move SpiceChardev and open_spice_port() to spice.h header Marc-André Lureau
2018-08-03 18:20 ` Eric Blake [this message]
2018-08-03 17:36 ` [Qemu-devel] [PATCH 08/10] char: register spice ports after spice started Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 09/10] build-sys: add gio-2.0 check Marc-André Lureau
2018-08-03 17:36 ` [Qemu-devel] [PATCH 10/10] display: add -display app launching external application Marc-André Lureau
2018-08-03 18:22 ` Eric Blake
2018-08-07 10:15 ` Daniel P. Berrangé
2018-08-07 10:33 ` Marc-André Lureau
2018-08-07 14:30 ` Gerd Hoffmann
2018-08-07 14:43 ` Paolo Bonzini
2018-12-18 14:04 ` Marc-André Lureau
2018-12-19 7:13 ` Gerd Hoffmann
2018-12-19 7:44 ` Marc-André Lureau
2018-12-19 9:54 ` Gerd Hoffmann
2018-12-19 12:34 ` Marc-André Lureau
2018-12-19 12:55 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8490d50-216b-3c50-7e39-b87a218c48db@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.