From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpIXz-00043G-36 for qemu-devel@nongnu.org; Wed, 28 Sep 2016 13:21:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpIXx-0000Kk-7X for qemu-devel@nongnu.org; Wed, 28 Sep 2016 13:21:29 -0400 References: <1474958276-7715-1-git-send-email-famz@redhat.com> <1474958276-7715-4-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: Date: Wed, 28 Sep 2016 19:21:18 +0200 MIME-Version: 1.0 In-Reply-To: <1474958276-7715-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ck4eMFETQFqfqEVKq5mglpcWbdG5Wuhr6" Subject: Re: [Qemu-devel] [PATCH v2 3/5] block: Introduce and make use of blk_new_with_root List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , qemu-stable@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ck4eMFETQFqfqEVKq5mglpcWbdG5Wuhr6 From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , qemu-stable@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: Subject: Re: [PATCH v2 3/5] block: Introduce and make use of blk_new_with_root References: <1474958276-7715-1-git-send-email-famz@redhat.com> <1474958276-7715-4-git-send-email-famz@redhat.com> In-Reply-To: <1474958276-7715-4-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 27.09.2016 08:37, Fam Zheng wrote: > The idiom of "blk_new() + blk_insert_bs()" is common. Use a new > BB interface that does both things to make the coming transition that > adds AioContext to BB easier. Indeed. It was called blk_new_with_bs() before and I dropped it. :-) (The difference and the reason why I dropped it was that blk_new_with_bs() created the BDS, too.) ((And as a side note, this pattern does not come from me dropping blk_new_with_bs(). As far as I remember, I replaced most places where it was used by blk_new_open().)) > The added blk_new_with_ctx doesn't handle the passed ctx and is purely > here to avoid a small code churn. Maybe add a "yet" in there, i.e. "does not handle the passed ctx yet"? >=20 > Signed-off-by: Fam Zheng > --- > block/backup.c | 3 +-- > block/block-backend.c | 24 ++++++++++++++++++------ > block/commit.c | 12 ++++-------- > block/mirror.c | 3 +-- > blockjob.c | 3 +-- > hmp.c | 3 +-- > hw/core/qdev-properties-system.c | 3 +-- > include/sysemu/block-backend.h | 1 + > nbd/server.c | 3 +-- > tests/test-blockjob.c | 3 +-- > 10 files changed, 30 insertions(+), 28 deletions(-) Reviewed-by: Max Reitz --ck4eMFETQFqfqEVKq5mglpcWbdG5Wuhr6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX6/wOEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQKhA B/9pmyQ6Bm3z5jyO3LrjF3JWqoNFfwclRzbQprnakCBkL/aOP+GdHMaaCoGlT1El 1BODc+vbKDtKFgzrhomJctwLBqwv1JuHPmKMPLIH8szMpOfzbh74frI0OqaRd27W LZlkwSaUn7E3aRj1vh6iS+u0g5ImshfpEEnEIGU286JfgP+9AI67zS+h6c0TftHO SK2FEzuIPmLFAoqPRXfzZJjYIEL+x7uricDxfikrdMt7x5ObxO8yek17x4LXhgsG b/RWLP2kw6iTya4mY19jMx7MQdBuwSAjG8sOce18L6RhXVvBh17XNGwW7tRifv61 cy3PmND+/fTXscYJUTz+Lyw7 =mEMT -----END PGP SIGNATURE----- --ck4eMFETQFqfqEVKq5mglpcWbdG5Wuhr6--