Hi Paolo, Mat, Christoph

On 30/06/2020 20:28, Mat Martineau wrote:
> On Fri, 26 Jun 2020, Paolo Abeni wrote:
> 
>> The RFC 8684 mandates that no-data DATA FIN packets should carry
>> a DSS with 0 sequence number and data len equal to 1. Currently,
>> on FIN retransmission we re-use the existing mapping; if the previous
>> fin transmission was part of a partially acked data packet, we could
>> end-up writing in the egress packet a non-compliant DSS.
>>
>> The above will be detected by a "Bad mapping" warning on the receiver
>> side.
>>
>> This change addresses the issue explicitly checking for 0 len packet
>> when adding the DATA_FIN option.
>>
>> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data 
>> packets")
>> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> 
> Thanks Paolo, looks good.
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Thank you for the patch, the validation and the reviews!

@Christoph: it seems "Reviewed-and-tested-by" tag is not recognised by 
Patchwork so I split them :)

I added this patch at the end:

- aea4d1ebbc5f: mptcp: fix DSS map generation on fin retransmission
- d8ab2db3ac90..3813e7acdac2: result

Tests and export are in progress.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net