From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>, Wolfram Sang <wsa@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs
Date: Mon, 12 Apr 2021 23:26:18 +0000 [thread overview]
Message-ID: <c85dcf3e-f63e-8e9f-d977-18a4b6e21328@alliedtelesis.co.nz> (raw)
In-Reply-To: <c9af3c98-7680-b7d1-a23b-f09c90e19b91@alliedtelesis.co.nz>
On 13/04/21 11:21 am, Chris Packham wrote:
>
> On 13/04/21 10:52 am, Andy Shevchenko wrote:
>> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
>> <chris.packham@alliedtelesis.co.nz> wrote:
>>> Use device managed functions an clean up error handling.
>> For the god sake how have you tested this?
>> The patch is broken.
> I've clearly missed the remove path in my testing. I was focused on
> the interrupt bevhaviour not the probe/remove which I'll make sure to
> check for the next round.
Should I send a revert or leave it for Wolfram?
next prev parent reply other threads:[~2021-04-12 23:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 1:52 [PATCH v2 0/6] i2c: mpc: Refactor to improve responsiveness Chris Packham
2021-03-29 1:52 ` [PATCH v2 1/6] dt-bindings: i2c-mpc: Document interrupt property as required Chris Packham
2021-03-30 15:13 ` Rob Herring
2021-03-29 1:52 ` [PATCH v2 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema Chris Packham
2021-03-30 15:18 ` Rob Herring
2021-03-29 1:52 ` [PATCH v2 3/6] i2c: mpc: Make use of i2c_recover_bus() Chris Packham
2021-03-29 1:52 ` [PATCH v2 4/6] i2c: mpc: make interrupt mandatory and remove polling code Chris Packham
2021-04-10 20:16 ` Wolfram Sang
2021-04-11 23:57 ` Chris Packham
2021-03-29 1:52 ` [PATCH v2 5/6] i2c: mpc: use device managed APIs Chris Packham
2021-04-12 22:52 ` Andy Shevchenko
2021-04-12 22:55 ` Andy Shevchenko
2021-04-12 23:21 ` Chris Packham
2021-04-12 23:26 ` Chris Packham [this message]
2021-04-12 23:34 ` Andy Shevchenko
2021-03-29 1:52 ` [PATCH v2 6/6] i2c: mpc: Interrupt driven transfer Chris Packham
2021-04-10 20:13 ` Wolfram Sang
2021-04-11 21:31 ` Chris Packham
2021-04-12 18:17 ` Wolfram Sang
2021-04-12 22:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85dcf3e-f63e-8e9f-d977-18a4b6e21328@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.