From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enrDJ-0000fZ-E2 for qemu-devel@nongnu.org; Mon, 19 Feb 2018 14:35:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enrDF-0000ir-Hi for qemu-devel@nongnu.org; Mon, 19 Feb 2018 14:35:01 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:39463) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enrDF-0000ia-Ao for qemu-devel@nongnu.org; Mon, 19 Feb 2018 14:34:57 -0500 Received: by mail-pg0-x242.google.com with SMTP id w17so6232875pgv.6 for ; Mon, 19 Feb 2018 11:34:57 -0800 (PST) From: Richard Henderson References: <1518751105-17211-1-git-send-email-cota@braap.org> <1518751105-17211-2-git-send-email-cota@braap.org> Message-ID: Date: Mon, 19 Feb 2018 11:34:52 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] translator: pass max_insns to tb_start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: Aurelien Jarno On 02/19/2018 11:31 AM, Richard Henderson wrote: > On 02/15/2018 07:18 PM, Emilio G. Cota wrote: >> sh4 will need it. >> >> Signed-off-by: Emilio G. Cota >> --- >> accel/tcg/translator.c | 2 +- >> include/exec/translator.h | 3 ++- >> target/alpha/translate.c | 3 ++- >> target/arm/translate-a64.c | 4 +++- >> target/arm/translate.c | 4 +++- >> target/hppa/translate.c | 4 +++- >> target/i386/translate.c | 3 ++- >> 7 files changed, 16 insertions(+), 7 deletions(-) > > There is another possibility, which is to move max_insns into DisasContextBase > where it can be modified. This would allow the gusa sequence to be handled > differently as an instance of the translate_insn hook, which would allow a > breakpoint to be placed on the first insn of a gusa sequence. > > I guess I don't have strong feelings either way. Thinking some more, I *do* prefer max_insns in DisasContextBase. For ARM SVE, implementing MOVPRFX, I would like to be able to tell if we intend to break the TB between MOVPRFX and the instruction being prefixed. I can't do that if the data is private to translator.c. r~