From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH 2/5] arm64: only select PINCTRL_SUNXI for Allwinner platforms Date: Tue, 28 Feb 2017 18:19:15 +0000 Message-ID: References: <20170228172444.59655-1-icenowy@aosc.xyz> <20170228172444.59655-2-icenowy@aosc.xyz> Reply-To: andre.przywara-5wv7dgnIgG8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170228172444.59655-2-icenowy-ymACFijhrKM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: icenowy-ymACFijhrKM@public.gmane.org, Linus Walleij , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Catalin Marinas , Will Deacon Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-gpio@vger.kernel.org Hi, On 28/02/17 17:24, Icenowy Zheng wrote: > As the pinctrl driver selecting is refactored in Kconfig file of > pinctrl-sunxi, now we can select only PINCTRL_SUNXI for Allwinner > platform, and the default value of several pinctrl drivers useful on > ARM64 Allwinner SoCs will become Y. > > Drop the select of per-SoC pinctrl choices, but select PINCTRL_SUNXI. > > Signed-off-by: Icenowy Zheng > --- > arch/arm64/Kconfig.platforms | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 129cc5ae4091..f6db2a938b1e 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -4,7 +4,7 @@ config ARCH_SUNXI > bool "Allwinner sunxi 64-bit SoC Family" > select GENERIC_IRQ_CHIP > select PINCTRL > - select PINCTRL_SUN50I_A64 > + select PINCTRL_SUNXI Why do we need to add this generic PINCTRL_SUNXI here? This is selected already by the SoC specific PINCTRL symbols (see your previous patch). Cheers, Andre. > help > This enables support for Allwinner sunxi based SoCs like the A64. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdB1Uqt (ORCPT ); Tue, 28 Feb 2017 15:46:49 -0500 Received: from foss.arm.com ([217.140.101.70]:42028 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdB1Uqp (ORCPT ); Tue, 28 Feb 2017 15:46:45 -0500 Subject: Re: [linux-sunxi] [PATCH 2/5] arm64: only select PINCTRL_SUNXI for Allwinner platforms To: icenowy@aosc.xyz, Linus Walleij , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Catalin Marinas , Will Deacon References: <20170228172444.59655-1-icenowy@aosc.xyz> <20170228172444.59655-2-icenowy@aosc.xyz> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com From: Andre Przywara Message-ID: Date: Tue, 28 Feb 2017 18:19:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170228172444.59655-2-icenowy@aosc.xyz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28/02/17 17:24, Icenowy Zheng wrote: > As the pinctrl driver selecting is refactored in Kconfig file of > pinctrl-sunxi, now we can select only PINCTRL_SUNXI for Allwinner > platform, and the default value of several pinctrl drivers useful on > ARM64 Allwinner SoCs will become Y. > > Drop the select of per-SoC pinctrl choices, but select PINCTRL_SUNXI. > > Signed-off-by: Icenowy Zheng > --- > arch/arm64/Kconfig.platforms | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 129cc5ae4091..f6db2a938b1e 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -4,7 +4,7 @@ config ARCH_SUNXI > bool "Allwinner sunxi 64-bit SoC Family" > select GENERIC_IRQ_CHIP > select PINCTRL > - select PINCTRL_SUN50I_A64 > + select PINCTRL_SUNXI Why do we need to add this generic PINCTRL_SUNXI here? This is selected already by the SoC specific PINCTRL symbols (see your previous patch). Cheers, Andre. > help > This enables support for Allwinner sunxi based SoCs like the A64. > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: andre.przywara@arm.com (Andre Przywara) Date: Tue, 28 Feb 2017 18:19:15 +0000 Subject: [linux-sunxi] [PATCH 2/5] arm64: only select PINCTRL_SUNXI for Allwinner platforms In-Reply-To: <20170228172444.59655-2-icenowy@aosc.xyz> References: <20170228172444.59655-1-icenowy@aosc.xyz> <20170228172444.59655-2-icenowy@aosc.xyz> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 28/02/17 17:24, Icenowy Zheng wrote: > As the pinctrl driver selecting is refactored in Kconfig file of > pinctrl-sunxi, now we can select only PINCTRL_SUNXI for Allwinner > platform, and the default value of several pinctrl drivers useful on > ARM64 Allwinner SoCs will become Y. > > Drop the select of per-SoC pinctrl choices, but select PINCTRL_SUNXI. > > Signed-off-by: Icenowy Zheng > --- > arch/arm64/Kconfig.platforms | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 129cc5ae4091..f6db2a938b1e 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -4,7 +4,7 @@ config ARCH_SUNXI > bool "Allwinner sunxi 64-bit SoC Family" > select GENERIC_IRQ_CHIP > select PINCTRL > - select PINCTRL_SUN50I_A64 > + select PINCTRL_SUNXI Why do we need to add this generic PINCTRL_SUNXI here? This is selected already by the SoC specific PINCTRL symbols (see your previous patch). Cheers, Andre. > help > This enables support for Allwinner sunxi based SoCs like the A64. > >