From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03CD1C4338F for ; Mon, 26 Jul 2021 15:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE8BB60F92 for ; Mon, 26 Jul 2021 15:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236350AbhGZPH4 (ORCPT ); Mon, 26 Jul 2021 11:07:56 -0400 Received: from mga11.intel.com ([192.55.52.93]:44731 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236179AbhGZPGO (ORCPT ); Mon, 26 Jul 2021 11:06:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10057"; a="209151258" X-IronPort-AV: E=Sophos;i="5.84,270,1620716400"; d="scan'208";a="209151258" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 08:46:05 -0700 X-IronPort-AV: E=Sophos;i="5.84,270,1620716400"; d="scan'208";a="455807917" Received: from jwconner-mobl1.amr.corp.intel.com (HELO [10.209.169.36]) ([10.209.169.36]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 08:46:03 -0700 Subject: Re: [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard To: Brent Lu , alsa-devel@alsa-project.org Cc: Guennadi Liakhovetski , Cezary Rojewski , Kuninori Morimoto , linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Liam Girdwood , Mark Brown , Paul Olaru , Zou Wei , Rander Wang References: <20210726094525.5748-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 26 Jul 2021 09:08:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210726094525.5748-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/21 4:45 AM, Brent Lu wrote: > The default codec for speaker amp's DAI Link is max98373 and will be > overwritten in probe function if the board id is sof_da7219_mx98360a. > However, the probe function does not do it because the board id is > changed in earlier commit. > > Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters") > Signed-off-by: Brent Lu Nice catch indeed. Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/sof_da7219_max98373.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c > index 896251d742fe..b7b3b0bf994a 100644 > --- a/sound/soc/intel/boards/sof_da7219_max98373.c > +++ b/sound/soc/intel/boards/sof_da7219_max98373.c > @@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev) > return -ENOMEM; > > /* By default dais[0] is configured for max98373 */ > - if (!strcmp(pdev->name, "sof_da7219_max98360a")) { > + if (!strcmp(pdev->name, "sof_da7219_mx98360a")) { > dais[0] = (struct snd_soc_dai_link) { > .name = "SSP1-Codec", > .id = 0, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46808C4338F for ; Mon, 26 Jul 2021 15:47:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C051360F91 for ; Mon, 26 Jul 2021 15:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C051360F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AD4516CA; Mon, 26 Jul 2021 17:46:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AD4516CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627314468; bh=9T6a7+7pH1LfAmmy8DjEj2+MFaA+P1f5yXJG7hxGanM=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DvNguYxljSwO8oyj7SfkK3QOXTAluX0VUjcq0dq/WjOZWPzuZxQrFmLv+DvIa8ax1 6nYX8WWesYTFEgUHl3DOwXIcSnZe8sEVEH5nN+hGQN9daaAGuig1E80ur3GCRm4eWn WkRnhJolEJyXht4ckIWjAaZaZOUZuB/6XoMjLJV8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0F01DF80130; Mon, 26 Jul 2021 17:46:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87F24F8025A; Mon, 26 Jul 2021 17:46:55 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1F4C3F80130 for ; Mon, 26 Jul 2021 17:46:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1F4C3F80130 X-IronPort-AV: E=McAfee;i="6200,9189,10057"; a="209151259" X-IronPort-AV: E=Sophos;i="5.84,270,1620716400"; d="scan'208";a="209151259" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 08:46:05 -0700 X-IronPort-AV: E=Sophos;i="5.84,270,1620716400"; d="scan'208";a="455807917" Received: from jwconner-mobl1.amr.corp.intel.com (HELO [10.209.169.36]) ([10.209.169.36]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 08:46:03 -0700 Subject: Re: [PATCH] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard To: Brent Lu , alsa-devel@alsa-project.org References: <20210726094525.5748-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 26 Jul 2021 09:08:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210726094525.5748-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , Cezary Rojewski , Kuninori Morimoto , Jie Yang , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Paul Olaru , Zou Wei , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/26/21 4:45 AM, Brent Lu wrote: > The default codec for speaker amp's DAI Link is max98373 and will be > overwritten in probe function if the board id is sof_da7219_mx98360a. > However, the probe function does not do it because the board id is > changed in earlier commit. > > Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters") > Signed-off-by: Brent Lu Nice catch indeed. Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/sof_da7219_max98373.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c > index 896251d742fe..b7b3b0bf994a 100644 > --- a/sound/soc/intel/boards/sof_da7219_max98373.c > +++ b/sound/soc/intel/boards/sof_da7219_max98373.c > @@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev) > return -ENOMEM; > > /* By default dais[0] is configured for max98373 */ > - if (!strcmp(pdev->name, "sof_da7219_max98360a")) { > + if (!strcmp(pdev->name, "sof_da7219_mx98360a")) { > dais[0] = (struct snd_soc_dai_link) { > .name = "SSP1-Codec", > .id = 0, >