From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD678C5DF60 for ; Fri, 8 Nov 2019 06:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6924321D6C for ; Fri, 8 Nov 2019 06:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=themaw.net header.i=@themaw.net header.b="o7oqq6mo"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SRU8MFUP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725730AbfKHGaF (ORCPT ); Fri, 8 Nov 2019 01:30:05 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52481 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfKHGaF (ORCPT ); Fri, 8 Nov 2019 01:30:05 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2709B5A2; Fri, 8 Nov 2019 01:30:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Nov 2019 01:30:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm1; bh= 9AWth8NtH6iy/A3w/xpNONmPLTZreNK3+86K5me1qgE=; b=o7oqq6monJnK7udh CK/M9HGVxLM50jG1RxAXDOyD10rl/wiCaDV6feans4P2I58hg9+2YfrZOY8NAt9c Jwc4OE1x3WthILck5jNJH88cWn/TJCNzcUJTg6CZO8+gQBM3HwYJpAhF+E/a2w5i 9hBLPmEOfqURp7Sw5BSLm+CoPQHLwBWqI1iOqQUsYlDKhONiTySyZauFDHbYh3x8 qLS29Q5SqV4cqvBx7WpM/Zg0mLcevtqfgHtQa07bTULUHIn7c4+cTAoMjGdKnbOr ssmp/+u24kfcA6qEIy3qpoc4Y/gI9ktBdCSUaNJQH9iriZ1rKIch2mYn+CSI/b8l 4drFlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=9AWth8NtH6iy/A3w/xpNONmPLTZreNK3+86K5me1q gE=; b=SRU8MFUPK9Ls4vEG1BkhythbN6gZqlKyIOeNDP+CSxnwDDYKHj8D2IOqd yGtF79mEovTcj3nCbWPUhWPEftgssOJ2aQ3uobNuBpPCk+AAurw/Zh1ciJrI3z9G BsitiQ0yJYAaR6ktNczuymmEn51URMLEJmvqF2sqAVXRmN5xWtLazDPjKp10h11J jxPjf2lrMEgpLkQRZyrbGGTZDZda6PPNBX+A1NEWQFpQimlbIwMwfzVDDqxSucfr ae+fNj6h+Op5eg2KhFb/Y+Z7H0DOD2FbxmUCtOCNxwYxsNFt9uFxOrIOCteP5GCV 8toFsogRmFfr1AuvRR5idCnuaHXUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddvtddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthejredttderjeenucfhrhhomhepkfgrnhcu mfgvnhhtuceorhgrvhgvnhesthhhvghmrgifrdhnvghtqeenucfkphepuddukedrvddtke drudekledrudeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrghvvghnsehthhgvmhgr fidrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mickey.themaw.net (unknown [118.208.189.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 93233306005E; Fri, 8 Nov 2019 01:30:00 -0500 (EST) Message-ID: Subject: Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw() From: Ian Kent To: Dan Carpenter , "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Fri, 08 Nov 2019 14:29:56 +0800 In-Reply-To: <20191108051121.GA26279@mwanda> References: <20191108051121.GA26279@mwanda> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote: > The extra tab makes the code slightly confusing. > > Signed-off-by: Dan Carpenter > --- > fs/xfs/xfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index b3188ea49413..ede6fac47c56 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1599,7 +1599,7 @@ xfs_remount_rw( > if (error) { > xfs_err(mp, > "Error %d recovering leftover CoW allocations.", error); > - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE); > + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE); > return error; > } > xfs_start_block_reaping(mp); Indeed, my bad. Reviewed-by: Ian Kent From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Kent Date: Fri, 08 Nov 2019 06:29:56 +0000 Subject: Re: [PATCH] xfs: remove a stray tab in xfs_remount_rw() Message-Id: List-Id: References: <20191108051121.GA26279@mwanda> In-Reply-To: <20191108051121.GA26279@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, 2019-11-08 at 08:11 +0300, Dan Carpenter wrote: > The extra tab makes the code slightly confusing. > > Signed-off-by: Dan Carpenter > --- > fs/xfs/xfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index b3188ea49413..ede6fac47c56 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1599,7 +1599,7 @@ xfs_remount_rw( > if (error) { > xfs_err(mp, > "Error %d recovering leftover CoW allocations.", error); > - xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE); > + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE); > return error; > } > xfs_start_block_reaping(mp); Indeed, my bad. Reviewed-by: Ian Kent