From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3177C433EF for ; Sat, 21 May 2022 07:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241018AbiEUH2z (ORCPT ); Sat, 21 May 2022 03:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235342AbiEUH2w (ORCPT ); Sat, 21 May 2022 03:28:52 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48516166685 for ; Sat, 21 May 2022 00:28:51 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id y32so17691154lfa.6 for ; Sat, 21 May 2022 00:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7V73RXe3dU41vM2yXc5RdFK0d/D3JpjuPldiMy6fTKw=; b=Esn+ulXtp2NG4hm6JqTfL5/p0EfkrSuWUCOO9w7zITqkI+Wwl0e6DtqieOfHEaVUKT CB1xY2oebbxCY3E8LwiqBz+y2Zf2z9agssq/85w0pSqE/4dqYAPZBtarkvx2muFGrykT EZ2UKFoJT8TmJ5oJv7ZyDvNWs08PxumdZ4lgVtdlpMVYHdQqHDUZ0N02osjAQ0fSHNjw Vy049oSifghAwEI6PVkb5XQ8uUEeCz3gQ2UzxnUvmlvpcmm+yyr53Y8OHR04t0s8wPnF e7PcC3M+g8ioR3SvtmreqXQJ3ku+cu9rH1uB4Meyz3/UKxJ5w+ehGz4L4RnJmh6r52bp aosQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7V73RXe3dU41vM2yXc5RdFK0d/D3JpjuPldiMy6fTKw=; b=ZxVH0CPMCxpcpY0RsTCAxpzrnCQdtEdt3ZbWBsofCiSNqWrAA0Wgcoxk3PmffKRkaI 2swWLUf0DdtUP/FO/ASH/HgZCuFIIRuvMJQHAIQf/4giS4ySPnMfCk7DwOaxACaFgRSf HKYOjj90QJWFNxs0+LWTP5RKbQudGllgRHBCTZYwx0rfFqdW2Wnciu7eRg3WwIP3hqGg BFhIdFzJlijw4ELFUpFvUY2cFdWNYPaiXngw1+Enb9CNluInadi5GQqrwMleTUHC35LS B08g8FOPF4en4J7yE8L3KcUScqH+GXRlkdOX/LYPCgLIBEZlSTGsdMhTTSs/erZlyK1Y 0AmA== X-Gm-Message-State: AOAM533zd9PetMAoMaaUVzp13beFFc8LJmff5kAjBO0Vqr8AQwZMRnmQ BEGq4DCx7BLpOTHADzZWbK3Mgw== X-Google-Smtp-Source: ABdhPJy8dJsO28tYQXR1SlsZ1sX3R6DcdHNk1mOeJjQZ21k3u6ki9d4E/+FSVYEDZ7GwfjP8JwT2ug== X-Received: by 2002:a05:6512:31ce:b0:473:be54:ba76 with SMTP id j14-20020a05651231ce00b00473be54ba76mr9467947lfe.627.1653118129567; Sat, 21 May 2022 00:28:49 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.185]) by smtp.gmail.com with ESMTPSA id d13-20020ac24c8d000000b00477a61abff4sm953722lfl.63.2022.05.21.00.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 00:28:49 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 10:28:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/4] memcg: enable accounting for struct cgroup Content-Language: en-US To: Roman Gushchin Cc: =?UTF-8?Q?Michal_Koutn=c3=bd?= , Shakeel Butt , kernel@openvz.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org References: <20220519165325.GA2434@blackbody.suse.cz> <740dfcb1-5c5f-6a40-0f71-65f277f976d6@openvz.org> From: Vasily Averin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/22 03:55, Roman Gushchin wrote: > On Fri, May 20, 2022 at 11:16:32PM +0300, Vasily Averin wrote: >> common part: >> 16 ~ 352 5632 5632 KERNFS (*) >> 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) >> 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) >> 1 192 192 10504 (__d_alloc+0x29) >> 2 72 144 10648 (avc_alloc_node+0x27) >> 2 64 128 10776 (percpu_ref_init+0x6a) >> 1 64 64 10840 (memcg_list_lru_alloc+0x21a) >> >> 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e >> 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f >> 2 12 24 312 call_site=percpu_ref_init+0x23 >> 1 6 6 318 call_site=__percpu_counter_init+0x22 > > I'm curios, how do you generate these data? trace_cmd + awk + /dev/hand > Just an idea: it could be a nice tool, placed somewhere in tools/cgroup/... I'm agree, nice idea. I'll try to implement it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: Re: [PATCH 3/4] memcg: enable accounting for struct cgroup Date: Sat, 21 May 2022 10:28:47 +0300 Message-ID: References: <20220519165325.GA2434@blackbody.suse.cz> <740dfcb1-5c5f-6a40-0f71-65f277f976d6@openvz.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7V73RXe3dU41vM2yXc5RdFK0d/D3JpjuPldiMy6fTKw=; b=Esn+ulXtp2NG4hm6JqTfL5/p0EfkrSuWUCOO9w7zITqkI+Wwl0e6DtqieOfHEaVUKT CB1xY2oebbxCY3E8LwiqBz+y2Zf2z9agssq/85w0pSqE/4dqYAPZBtarkvx2muFGrykT EZ2UKFoJT8TmJ5oJv7ZyDvNWs08PxumdZ4lgVtdlpMVYHdQqHDUZ0N02osjAQ0fSHNjw Vy049oSifghAwEI6PVkb5XQ8uUEeCz3gQ2UzxnUvmlvpcmm+yyr53Y8OHR04t0s8wPnF e7PcC3M+g8ioR3SvtmreqXQJ3ku+cu9rH1uB4Meyz3/UKxJ5w+ehGz4L4RnJmh6r52bp aosQ== Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" To: Roman Gushchin Cc: =?UTF-8?Q?Michal_Koutn=c3=bd?= , Shakeel Butt , kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vlastimil Babka , Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 5/21/22 03:55, Roman Gushchin wrote: > On Fri, May 20, 2022 at 11:16:32PM +0300, Vasily Averin wrote: >> common part: >> 16 ~ 352 5632 5632 KERNFS (*) >> 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) >> 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) >> 1 192 192 10504 (__d_alloc+0x29) >> 2 72 144 10648 (avc_alloc_node+0x27) >> 2 64 128 10776 (percpu_ref_init+0x6a) >> 1 64 64 10840 (memcg_list_lru_alloc+0x21a) >> >> 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e >> 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f >> 2 12 24 312 call_site=percpu_ref_init+0x23 >> 1 6 6 318 call_site=__percpu_counter_init+0x22 > > I'm curios, how do you generate these data? trace_cmd + awk + /dev/hand > Just an idea: it could be a nice tool, placed somewhere in tools/cgroup/... I'm agree, nice idea. I'll try to implement it.