From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A65EC43334 for ; Wed, 15 Jun 2022 21:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d4jgxogy6WqMvJKwipAWQ0NSE1g+c7csm1Omj+6YBHo=; b=cjFbOe1df4mieW Jm3ZZ/ZVFC7TAcYXU4YUKwjHTf4ucKywCFH0kOVP+PrlnLk5n/mIlqE9t7AKfAdwDQxzQ3acJyAqP EQtNjdbTk+bmAKwnFXNlcRQSyiraaGK0w+uvyvZhqG4/XfVgkFWaHP2tupGLMAUxIRrOSsyZLqGV9 nZXitGXrQdLkiQSKlBNI+lJzzor8yENDruQXqcAebs/5504uZWfnlVNep8SIhYF8n3eS3je0qbXIi hQqz5omu3HKXh/XW756mB5Op0FiypG7kN3d0SyNvxfGTftjuN2dfGb2GIcTbIzbCGeyLJqCk9zuBn Vw4pVgo1ik1pa63gzoGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1ass-00GWT5-U4; Wed, 15 Jun 2022 21:49:07 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1asp-00GWQF-Rx for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 21:49:05 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9270A832C3; Wed, 15 Jun 2022 23:48:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655329738; bh=utBxQGEFF2PhlHa6KwIQFHTfMaYe0VZvmwFJiyjQreM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P8278tzNs9uM4Y/WpXkUuJ3ujWMjNhUOGC080BcJ/4/5SYDf0L1tb0fF0gAJYx3Kw geVFSgv3yoaaDOlDgjJbUQ6QQQy0FZdOt7zHR+pQfo/JpKX9zig0fr8v/vF1hFh5C7 N2SlQ2j1NoXwA/mPIOMv5ZhLtqr5Jn1Lvq7iWcv0kdQzwQOeYk6ro8PmkKzR9QyPJH FyKP7NEddvnANsVjSc4E8EUY4tDDZeUTtY33oJaEvCjMoVhHN8tTeUgmwx6CcL9USG srhPtb/XSu5faI/rYq3Thb+1yGXe8oN94awwn+LSOkRQcAgO85nmikYt5Dlh2RXmZT n3BpzPdqARnjA== Message-ID: Date: Wed, 15 Jun 2022 23:48:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Content-Language: en-US To: Abel Vesa Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jacky Bai , Laurent Pinchart , Lucas Stach , Michael Turquette , Shawn Guo , Stephen Boyd , linux-imx@nxp.com References: <20220504204144.442193-1-marex@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_144904_190104_0499ED8A X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/15/22 17:56, Abel Vesa wrote: > On 22-06-15 18:47:01, Abel Vesa wrote: >> On 22-06-15 17:08:28, Marek Vasut wrote: >>> On 6/15/22 16:30, Abel Vesa wrote: >>> >>> [...] >>> >>>>> +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) >>>>> +{ >>>>> + struct clk_imx8mp_audiomix_priv *priv; >>>>> + struct device *dev = &pdev->dev; >>>>> + struct resource *res; >>>>> + void __iomem *base; >>>>> + struct clk_hw *hw; >>>>> + int i; >>>>> + >>>>> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >>>>> + if (!priv) >>>>> + return -ENOMEM; >>>>> + >>>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>>> + base = devm_ioremap_resource(dev, res); >>>>> + if (IS_ERR(base)) >>>>> + return PTR_ERR(base); >>>>> + >>>> >>>> Hmm, the audiomix blk-ctl driver uses the PD for this device. >>>> That is not going to work. >>> >>> What is not going to work. Can you elaborate on your concerns ? >> >> Have a look at drivers/soc/imx/imx8m-blk-ctrl.c. >> >> As of now, there is no i.MX8MP audio blk ctrl support added there yet, >> but once that gets added, that driver will disable the PD from under >> this clock controller. > > On a second thought, I remember there was a discussion about this being > implemented entirely in imx8m-blk-ctrl.c. This is purely a clock driver within the PGC audio domain, see the DT bindings in 3/4 patch. I don't expect there to be any PD related issues. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel