All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/2] rockchip: Fix SPI boot on Pinebook Pro and RK3399-ROC-PC
Date: Thu, 19 Nov 2020 16:11:43 +0800	[thread overview]
Message-ID: <c88f3633-10ba-5cc9-dd54-49a8e06b2034@rock-chips.com> (raw)
In-Reply-To: <20201114180605.22568-1-sigmaris@gmail.com>

Hi Hugh,

 ??? After this patch set, only one board is still using the "spi0 = 
&spi1" alias, could you correct it at the same time?

rk3399-puma-haikou-u-boot.dtsi


Thanks,

- Kever

On 2020/11/15 ??2:06, Hugh Cole-Baker wrote:
> Commit c4cea2bbf995 ("rockchip: Enable building a SPI ROM image on bob")
> added an alias spi1 referring to spi at ff1d0000, however in several boards
> there was already an alias spi0 referring to the same node, and having
> both aliases present broke booting U-Boot from SPI flash.
>
> This series removes the spi0 alias from the Pinebook Pro and
> RK3399-ROC-PC and sets the default bus for SPI flash to 1, so that the
> correct device is used. The Rockpro64 board, which was also affected,
> has already had the same type of fix applied.
>
> The rk3399 Puma board also has an alias spi0 = &spi1 in its dts, but I
> haven't touched its configuration as it seems to have a more complex
> setup where spi1 is already an alias that points to &spi5. I don't
> have one of these boards to test with, but I suspect it wasn't affected
> by the addition of the spi1 alias in rk3399-u-boot.dtsi.
>
>
> Hugh Cole-Baker (2):
>    rockchip: pinebook-pro: default to SPI bus 1 for SPI-flash
>    rockchip: rk3399-roc-pc: default to SPI bus 1 for SPI-flash
>
>   arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 4 ----
>   arch/arm/dts/rk3399-roc-pc-u-boot.dtsi       | 4 ----
>   configs/pinebook-pro-rk3399_defconfig        | 2 ++
>   configs/roc-pc-mezzanine-rk3399_defconfig    | 1 +
>   configs/roc-pc-rk3399_defconfig              | 1 +
>   5 files changed, 4 insertions(+), 8 deletions(-)
>

      parent reply	other threads:[~2020-11-19  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 18:06 [PATCH 0/2] rockchip: Fix SPI boot on Pinebook Pro and RK3399-ROC-PC Hugh Cole-Baker
2020-11-14 18:06 ` [PATCH 1/2] rockchip: pinebook-pro: default to SPI bus 1 for SPI-flash Hugh Cole-Baker
2020-11-14 18:06 ` [PATCH 2/2] rockchip: rk3399-roc-pc: " Hugh Cole-Baker
2020-11-19  8:11 ` Kever Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c88f3633-10ba-5cc9-dd54-49a8e06b2034@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.