From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFA0C47082 for ; Tue, 8 Jun 2021 07:28:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3282261073 for ; Tue, 8 Jun 2021 07:28:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3282261073 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 500C482B77; Tue, 8 Jun 2021 09:28:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="BdFvJnW8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6094282B77; Tue, 8 Jun 2021 09:28:06 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BDA2C80050 for ; Tue, 8 Jun 2021 09:28:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vigneshr@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1587S1gg080971 for ; Tue, 8 Jun 2021 02:28:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623137281; bh=1/+P7G0DYOWyYCnHvL2WJRmhmUPqTWq0MNvdY0t7HHk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=BdFvJnW8c5O8WdrXBo66HrCUrHyGLw+c5m44XSI3S57GuC1s1j3ZvgTkFy09KInoT MRUGTdCvMXO/2xZFDDQiLxqYsc+idku0W4D8vcZnSnb+Q72ej0g8UtZLcwrIJdr2/2 8VaA+UdfN3kcR/h2lJxmUGBuKz/2Sc4bWkC8llg4= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1587S1Kx005866 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 8 Jun 2021 02:28:01 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 8 Jun 2021 02:28:01 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 8 Jun 2021 02:28:01 -0500 Received: from [10.250.234.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1587Rxp2121112; Tue, 8 Jun 2021 02:28:00 -0500 Subject: Re: [PATCH v2 0/7] J72xx: R5 SPL DMA support post HSM Rearch To: Lokesh Vutla CC: References: <20210607141753.28796-1-vigneshr@ti.com> From: Vignesh Raghavendra Message-ID: Date: Tue, 8 Jun 2021 12:57:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/8/21 12:35 PM, Lokesh Vutla wrote: > > > On 07/06/21 7:47 pm, Vignesh Raghavendra wrote: >> This series add DMA support for R5 SPL on J721e/J7200 SoCs post HSM >> Rearch. >> >> Depends on Tero's base HSM rearch support series. >> >> v2: >> Use IS_ENABLED() consistentially instead of #ifdef >> Reword commit msg for 5/7 as suggested by Lokesh >> Rebase on Tero's latest HSM base series. > > I see the folloiwing build warnings with this series: > > arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (reg_format): > /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:reg: property has invalid > length (80 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: Relying on default > #address-cells value > arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: Relying on default > #size-cells value > arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default > #address-cells value > arch/arm/dts/k3-j7200-common-proc-board.dtb: Warning (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default > #size-cells value > arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning (reg_format): > /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000:reg: property has invalid > length (80 bytes) (#address-cells == 2, #size-cells == 1) > arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning > (avoid_default_addr_size): /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: > Relying on default #address-cells value > arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning > (avoid_default_addr_size): /bus@100000/bus@28380000/mcu-navss/ringacc@2b800000: > Relying on default #size-cells value > arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning > (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default > #address-cells value > arch/arm/dts/k3-j7200-r5-common-proc-board.dtb: Warning > (avoid_default_addr_size): > /bus@100000/bus@28380000/mcu-navss/dma-controller@285c0000: Relying on default > #size-cells value > > Can you fix it or send me fix, Ill can squash? Hmm, weird. I had to fix #address-cells and #size-cells in k3-j7200-common-proc-board-u-boot.dtsi but they same does not seem to be needed for j721e. Anyway below diff fixes the warning Could you squash to 5/7? diff --git a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi index 41ce9fcb59..786cc48050 100644 --- a/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi +++ b/arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi @@ -43,6 +43,8 @@ mcu-navss{ u-boot,dm-spl; + #address-cells = <2>; + #size-cells = <2>; ringacc@2b800000 { reg = <0x0 0x2b800000 0x0 0x400000>, Regards Vignesh