From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbdC0JyH (ORCPT ); Mon, 27 Mar 2017 05:54:07 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35025 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbdC0JyA (ORCPT ); Mon, 27 Mar 2017 05:54:00 -0400 Cc: aviyae42@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org To: gregkh@linuxfoundation.org From: aviyae Subject: [PATCH] staging: goldfish: Fix coding style issues Message-ID: Date: Mon, 27 Mar 2017 12:53:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B5E1A4C0F558CAC0248DEDFB" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------B5E1A4C0F558CAC0248DEDFB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit fixing some coding style issues in goldfish audio driver --------------B5E1A4C0F558CAC0248DEDFB Content-Type: text/x-patch; name="0001-staging-goldfish-Fix-coding-style-issues.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-staging-goldfish-Fix-coding-style-issues.patch" >>From 8368d1b6404d63da7d502f6cd2ce6b50c7ffa9b9 Mon Sep 17 00:00:00 2001 From: Aviya Erenfeld Date: Tue, 21 Mar 2017 00:07:19 +0200 Subject: [PATCH] staging: goldfish: Fix coding style issues Fix the coding style issues that raised by checkpatch.pl in that driver. (For the eudyptula challenge) Signed-off-by: Aviya Erenfeld --- drivers/staging/goldfish/goldfish_audio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index bd55995..f1640ab 100644 --- a/drivers/staging/goldfish/goldfish_audio.c +++ b/drivers/staging/goldfish/goldfish_audio.c @@ -61,10 +61,12 @@ struct goldfish_audio { #define COMBINED_BUFFER_SIZE ((2 * READ_BUFFER_SIZE) + \ (2 * WRITE_BUFFER_SIZE)) -#define AUDIO_READ(data, addr) (readl(data->reg_base + addr)) -#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr)) +#define AUDIO_READ(data, addr) (readl((data)->reg_base + (addr))) +#define AUDIO_WRITE(data, addr, x) (writel(x, (data)->reg_base + (addr))) #define AUDIO_WRITE64(data, addr, addr2, x) \ - (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2)) + ({typeof(data) _data = (data); \ + gf_write_dma_addr((x), _data->reg_base + (addr), \ + _data->reg_base + (addr2)); }) /* * temporary variable used between goldfish_audio_probe() and -- 2.7.4 --------------B5E1A4C0F558CAC0248DEDFB--