From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>, Owen Smith <owen.smith@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch
Date: Fri, 24 Mar 2017 11:19:33 +0000 [thread overview]
Message-ID: <c8b24161f23e47dfa1289a75e790188c@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <58D50E010200007800147394@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 24 March 2017 11:16
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; Owen Smith <owen.smith@citrix.com>; Wei Liu
> <wei.liu2@citrix.com>; xen-devel@lists.xenproject.org
> Subject: RE: [PATCH v2] tools/firmware: add ACPI device for Windows
> laptop/slate mode switch
>
> >>> On 24.03.17 at 12:04, <Paul.Durrant@citrix.com> wrote:
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Sent: 24 March 2017 10:53
> >> The only other concern I have here is that the abbreviation "conv"
> >> used throughout the patch is sort of ambiguous. I think it means
> >> "convertible" here, but without knowing the context it could easily
> >> be "conventional" or "convenience". Would there be anything
> >> wrong with spelling it out wherever name length limitations don't
> >> require it to be just four characters?
> >>
> >
> > I thought that name would be ok since it is the name of the ACPI device
> > itself but I could extend the xl.cfg option, bool and flag names to
> > 'acpi_convert' to make it more obvious.
>
> Hmm, "convert" still leaves room for speculation (in particular, seeing
> an option with this name, I'd suspect it wants to convert ACPI to
> something else). Is that what "conv" stands for (and not "convertible"
> or anything else)?
>
It was chosen simply because of the name of the device. How about 'acpi_device_conv'? After all this option merely controls the inclusion of the device. Subsequent patches will have to add a PV protocol to instruct in-guest code to prod it.
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-24 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 10:10 [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch Paul Durrant
2017-03-24 10:52 ` Jan Beulich
2017-03-24 11:04 ` Paul Durrant
2017-03-24 11:16 ` Jan Beulich
2017-03-24 11:19 ` Paul Durrant [this message]
2017-03-24 11:32 ` Jan Beulich
2017-03-24 11:40 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b24161f23e47dfa1289a75e790188c@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=owen.smith@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.