From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 866D4C433F5 for ; Fri, 21 Jan 2022 16:53:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4543E811E0; Fri, 21 Jan 2022 17:53:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642783986; bh=Dnz8K2YkCvjdKFaR9m4l16TnZrX+Alp0TIq8tmhn6TI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NMqNIUUPOBk+OCR0IG0lP1h+ZUrilSmQeb3w6w7pJogD4lHNngFkjl7/n8vgcE1ph IrsLZH06l9IjGyumuwmgZ+gF03DKCY/oIaHFFyoTkWvqYxaC1uRluB7KflJQ4pFdAu nL8BfGnmcbfmhjsdJLt6t3yT5ImgETCZpR7NlkF0G9/jtU5NFSjY6+pg73yE44t0tJ Nrxy36rwIO1IOTHZ4OFxYo5BWJUEo+Tirk/KucMX3c6SotrxiaX9ElXo9ZoyQ7tUDi 9DfTzyL5hih/ymYQEtP6NbbZ3U0oL2BkJMNyiWW76S62VBkaOM0s5LimYS+JTqTXHb CrS/wouERQsQw== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 75C4E80FD6; Fri, 21 Jan 2022 17:53:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642783984; bh=Dnz8K2YkCvjdKFaR9m4l16TnZrX+Alp0TIq8tmhn6TI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=asxsfqgjztwOVsaoSCJAAZYvN6d/zUxT+5Hbq+J0mqj2ZAEh4y6l+LaiSKMyEKeEI mMgtcu+GYyen7IMb8u3mwh6F9/fLunaCdWDIOnAan88zHXHigzOA74GRrc5SfTtq87 rHcYODy0n7Jw0t6dBrT18OoJ8l0F4zDW3RLCVLBnXzD0pmTqhxp+kCy2ZmR1j7un2c Owfo9o+ZZHNwtNOfmWc1Dq9a8LxXqMFa1lzCbt4tn10iVqHjUfUmdsLiO0clnUw2tH 4HSKq+KseBKHsA/0808wJfmvZitsrZK6kPTZiXz3+QN4YwH0XmzIKvZB9zRd+WdaRR HXuWujLInZ7UQ== Message-ID: Date: Fri, 21 Jan 2022 17:53:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] vexpress64: semi_defconfig: disable CRC32 support Content-Language: en-US To: Andre Przywara , Linus Walleij , Liviu Dudau Cc: Tom Rini , Simon Glass , Ross Burton , u-boot@lists.denx.de References: <20220121163604.2503548-1-andre.przywara@arm.com> From: Marek Vasut In-Reply-To: <20220121163604.2503548-1-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/21/22 17:36, Andre Przywara wrote: > Commit 270f8710f92f ("crc32: Add crc32 implementation using > __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions > by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A > cores support the instructions, and they are mandatory starting with > architecture revision v8.1, so realistically every known hardware > implementation should support them. > > The Arm Fastmodel however defaults to the bare minimum ARMv8 feature set > by default, which means v8.0 without the CRC instructions, so U-Boot > hangs very early at the moment, without any output (the boot-wrapper or > TF-A printing the last visible lines). > > Support for those instructions can be enabled on the model command line > by either: > -C cluster0.cpu0.enable_crc32=1 (for each core) > or by using a higher architecture revision by default: > -C cluster0.has_arm_v8-1=1 (for each cluster) > Of course any arch revision higher than v8.1 would work as well. > > But for the sake of a smooth out-of-the-box experience, let's just > disable the usage of those instructions in the defconfig, to avoid > random hangs without any clues. > > Reported-by: Ross Burton > Signed-off-by: Andre Przywara Acked-by: Marek Vasut