* [PATCH] linux-user: fix O_NONBLOCK usage for hppa target
@ 2021-02-01 16:26 Helge Deller
2021-02-01 16:31 ` BALATON Zoltan
0 siblings, 1 reply; 2+ messages in thread
From: Helge Deller @ 2021-02-01 16:26 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
John Paul Adrian Glaubitz
Historically the the parisc linux port tried to be compatible with
HP-UX userspace and as such defined the O_NONBLOCK constant to 0200004
to emulate separate NDELAY & NONBLOCK values.
Since parisc was the only Linux platform which had two bits set, this
produced various userspace issues. Finally it was decided to drop the
(never completed) HP-UX compatibilty, which is why O_NONBLOCK was
changed upstream to only have one bit set in future with this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75ae04206a4d0e4f541c1d692b7febd1c0fdb814
This patch simply adjusts the value for qemu-user too.
Signed-off-by: Helge Deller <deller@gmx.de>
---
diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
index bd966a59b8..08e3a4fcb0 100644
--- a/linux-user/hppa/target_fcntl.h
+++ b/linux-user/hppa/target_fcntl.h
@@ -8,7 +8,7 @@
#ifndef HPPA_TARGET_FCNTL_H
#define HPPA_TARGET_FCNTL_H
-#define TARGET_O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */
+#define TARGET_O_NONBLOCK 000200000
#define TARGET_O_APPEND 000000010
#define TARGET_O_CREAT 000000400 /* not fcntl */
#define TARGET_O_EXCL 000002000 /* not fcntl */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] linux-user: fix O_NONBLOCK usage for hppa target
2021-02-01 16:26 [PATCH] linux-user: fix O_NONBLOCK usage for hppa target Helge Deller
@ 2021-02-01 16:31 ` BALATON Zoltan
0 siblings, 0 replies; 2+ messages in thread
From: BALATON Zoltan @ 2021-02-01 16:31 UTC (permalink / raw)
To: Helge Deller
Cc: John Paul Adrian Glaubitz, Philippe Mathieu-Daudé,
Richard Henderson, Laurent Vivier, qemu-devel
On Mon, 1 Feb 2021, Helge Deller wrote:
> Historically the the parisc linux port tried to be compatible with
Double "the the" ^
> HP-UX userspace and as such defined the O_NONBLOCK constant to 0200004
> to emulate separate NDELAY & NONBLOCK values.
>
> Since parisc was the only Linux platform which had two bits set, this
> produced various userspace issues. Finally it was decided to drop the
> (never completed) HP-UX compatibilty, which is why O_NONBLOCK was
> changed upstream to only have one bit set in future with this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75ae04206a4d0e4f541c1d692b7febd1c0fdb814
>
> This patch simply adjusts the value for qemu-user too.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -8,7 +8,7 @@
> #ifndef HPPA_TARGET_FCNTL_H
> #define HPPA_TARGET_FCNTL_H
>
> -#define TARGET_O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */
> +#define TARGET_O_NONBLOCK 000200000
> #define TARGET_O_APPEND 000000010
> #define TARGET_O_CREAT 000000400 /* not fcntl */
> #define TARGET_O_EXCL 000002000 /* not fcntl */
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-01 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 16:26 [PATCH] linux-user: fix O_NONBLOCK usage for hppa target Helge Deller
2021-02-01 16:31 ` BALATON Zoltan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.