From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75417C433DB for ; Mon, 1 Feb 2021 16:32:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDC4760235 for ; Mon, 1 Feb 2021 16:32:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDC4760235 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6c8F-0000Tr-SY for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 11:32:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6c6p-0007gd-G4 for qemu-devel@nongnu.org; Mon, 01 Feb 2021 11:31:27 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:26511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6c6l-000295-OV for qemu-devel@nongnu.org; Mon, 01 Feb 2021 11:31:26 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id DF78D7462BD; Mon, 1 Feb 2021 17:31:21 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id AAC3B7456B7; Mon, 1 Feb 2021 17:31:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id A91227456B4; Mon, 1 Feb 2021 17:31:21 +0100 (CET) Date: Mon, 1 Feb 2021 17:31:21 +0100 (CET) From: BALATON Zoltan To: Helge Deller Subject: Re: [PATCH] linux-user: fix O_NONBLOCK usage for hppa target In-Reply-To: <20210201162652.GA25611@ls3530.fritz.box> Message-ID: References: <20210201162652.GA25611@ls3530.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Paul Adrian Glaubitz , =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= , Richard Henderson , Laurent Vivier , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 1 Feb 2021, Helge Deller wrote: > Historically the the parisc linux port tried to be compatible with Double "the the" ^ > HP-UX userspace and as such defined the O_NONBLOCK constant to 0200004 > to emulate separate NDELAY & NONBLOCK values. > > Since parisc was the only Linux platform which had two bits set, this > produced various userspace issues. Finally it was decided to drop the > (never completed) HP-UX compatibilty, which is why O_NONBLOCK was > changed upstream to only have one bit set in future with this commit: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75ae04206a4d0e4f541c1d692b7febd1c0fdb814 > > This patch simply adjusts the value for qemu-user too. > > Signed-off-by: Helge Deller > > --- > > diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h > index bd966a59b8..08e3a4fcb0 100644 > --- a/linux-user/hppa/target_fcntl.h > +++ b/linux-user/hppa/target_fcntl.h > @@ -8,7 +8,7 @@ > #ifndef HPPA_TARGET_FCNTL_H > #define HPPA_TARGET_FCNTL_H > > -#define TARGET_O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */ > +#define TARGET_O_NONBLOCK 000200000 > #define TARGET_O_APPEND 000000010 > #define TARGET_O_CREAT 000000400 /* not fcntl */ > #define TARGET_O_EXCL 000002000 /* not fcntl */ > >