From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjpjz-0002ZE-E7 for qemu-devel@nongnu.org; Wed, 16 Jan 2019 13:16:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjpXW-0000CA-Lv for qemu-devel@nongnu.org; Wed, 16 Jan 2019 13:03:47 -0500 References: <20190116121350.23863-1-alex.bennee@linaro.org> From: Andrew Cooper Message-ID: Date: Wed, 16 Jan 2019 18:03:20 +0000 MIME-Version: 1.0 In-Reply-To: <20190116121350.23863-1-alex.bennee@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org Cc: Kevin Wolf , Stefano Stabellini , "open list:Block layer core" , qemu-devel@nongnu.org, Max Reitz , Paul Durrant , Anthony Perard , "open list:X86" On 16/01/2019 12:13, Alex Bennée wrote: > The %lu format string is different depending on the host architecture > which causes builds like the debian-armhf-cross build to fail. Use the > correct PRi64 format string. > > Signed-off-by: Alex Bennée > --- > hw/block/xen-block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index be28b63442..a636487b3e 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -215,7 +215,7 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) > > xen_device_backend_printf(xendev, "sector-size", "%u", > conf->logical_block_size); > - xen_device_backend_printf(xendev, "sectors", "%lu", > + xen_device_backend_printf(xendev, "sectors", "%"PRIi64, PRIu64. You've changed the signed-ness of what gets printed. ~Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] hw/block/xen: use proper format string for printing sectors Date: Wed, 16 Jan 2019 18:03:20 +0000 Message-ID: References: <20190116121350.23863-1-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gjpYS-0000Z4-51 for xen-devel@lists.xenproject.org; Wed, 16 Jan 2019 18:04:44 +0000 In-Reply-To: <20190116121350.23863-1-alex.bennee@linaro.org> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org Cc: Kevin Wolf , Stefano Stabellini , "open list:Block layer core" , qemu-devel@nongnu.org, Max Reitz , Paul Durrant , Anthony Perard , "open list:X86" List-Id: xen-devel@lists.xenproject.org T24gMTYvMDEvMjAxOSAxMjoxMywgQWxleCBCZW5uw6llIHdyb3RlOgo+IFRoZSAlbHUgZm9ybWF0 IHN0cmluZyBpcyBkaWZmZXJlbnQgZGVwZW5kaW5nIG9uIHRoZSBob3N0IGFyY2hpdGVjdHVyZQo+ IHdoaWNoIGNhdXNlcyBidWlsZHMgbGlrZSB0aGUgZGViaWFuLWFybWhmLWNyb3NzIGJ1aWxkIHRv IGZhaWwuIFVzZSB0aGUKPiBjb3JyZWN0IFBSaTY0IGZvcm1hdCBzdHJpbmcuCj4KPiBTaWduZWQt b2ZmLWJ5OiBBbGV4IEJlbm7DqWUgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGh3 L2Jsb2NrL3hlbi1ibG9jay5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9ody9ibG9jay94ZW4tYmxvY2suYyBi L2h3L2Jsb2NrL3hlbi1ibG9jay5jCj4gaW5kZXggYmUyOGI2MzQ0Mi4uYTYzNjQ4N2IzZSAxMDA2 NDQKPiAtLS0gYS9ody9ibG9jay94ZW4tYmxvY2suYwo+ICsrKyBiL2h3L2Jsb2NrL3hlbi1ibG9j ay5jCj4gQEAgLTIxNSw3ICsyMTUsNyBAQCBzdGF0aWMgdm9pZCB4ZW5fYmxvY2tfcmVhbGl6ZShY ZW5EZXZpY2UgKnhlbmRldiwgRXJyb3IgKiplcnJwKQo+ICAKPiAgICAgIHhlbl9kZXZpY2VfYmFj a2VuZF9wcmludGYoeGVuZGV2LCAic2VjdG9yLXNpemUiLCAiJXUiLAo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25mLT5sb2dpY2FsX2Jsb2NrX3NpemUpOwo+IC0gICAgeGVuX2Rl dmljZV9iYWNrZW5kX3ByaW50Zih4ZW5kZXYsICJzZWN0b3JzIiwgIiVsdSIsCj4gKyAgICB4ZW5f ZGV2aWNlX2JhY2tlbmRfcHJpbnRmKHhlbmRldiwgInNlY3RvcnMiLCAiJSJQUklpNjQsCgpQUkl1 NjQuCgpZb3UndmUgY2hhbmdlZCB0aGUgc2lnbmVkLW5lc3Mgb2Ygd2hhdCBnZXRzIHByaW50ZWQu Cgp+QW5kcmV3CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpo dHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs