From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B2972 for ; Tue, 7 Sep 2021 22:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=bxPWNII6t/NMGO1fgxjyatCVjEuxKu/pncqEFjLY/38=; b=Ui1wNMHr1qisfggLyZY6EljOSh DaWVRD0Q5qi69FfBZ0WLKQakWxLm4gU4vxPk6Vji1flAFMLNy3B8/CFNn8a6c+s1RGYuxcksZ7smS P2L/f8NMosaY0ld2cM0fVt88682m9DlkZLwEHw2a6TRCaiGTmdQJ/gG7I0BNthhEkSM5jFJQs2aC5 wFPYstbOO8DYLPxymIfy2C+443vPwmfXCwFZneCHFvwBvTP5J8E2S3DB15J1DSGYw2mH/iu0RdJ+K Gxs92jqjmNaQis/aeSs9pi+smE0kEve5rEiVsJvgfGc8QUaPRjEkCaVf/Xk04tgsm80VcTlluS4TP 2LnK2jdw==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNjea-004xPm-64; Tue, 07 Sep 2021 22:33:20 +0000 Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds" To: Linus Torvalds , Marco Elver Cc: Nick Desaulniers , llvm@lists.linux.dev, LSM List , linux-toolchains@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Kees Cook , Mark Brown , Masahiro Yamada , Nathan Chancellor , Michal Marek , Andrew Morton , Vipin Sharma , Chris Down , Rasmus Villemoes , Daniel Borkmann , Vlastimil Babka , Linux Kbuild mailing list , Linux Kernel Mailing List References: <20210907183843.33028-1-ndesaulniers@google.com> From: Randy Dunlap Message-ID: Date: Tue, 7 Sep 2021 15:33:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/7/21 3:18 PM, Linus Torvalds wrote: > On Tue, Sep 7, 2021 at 3:14 PM Marco Elver wrote: >> >> >> config WERROR >> bool "Compile the kernel with warnings as errors" >> - default y >> + default COMPILE_TEST > > That seems reasonable. It very much is about build-testing. That and 2 more things IMO: a. having developers be responsible for build warnings, not just build errors b. having maintainers merge them more like they are build errors and not just some warnings that can be overlooked. I don't see enough of a. or b. :( -- ~Randy