All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH 1/9] netconfig: Refactor setting new values to system
Date: Thu, 11 Nov 2021 14:21:02 -0600	[thread overview]
Message-ID: <c9091fe7-3d70-bce6-eefe-48cba090d0a0@gmail.com> (raw)
In-Reply-To: 0880f7a8-c889-ef01-8342-e704d8d9257e@gmail.com

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hi Andrew,

> 
> What you say is absolutely correct.  Yet still wrong ;)  Just look at what 
> happens on a 'change'.  You try to call the notifier with 'connected' event. You 
> also print a debug message saying there's no gateway in the lease.  Neither make 
> sense.
> 

Note, I'm not saying you shouldn't use 'CHANGED'.  Perhaps that is the right 
approach if netconfig would inform the backend only of the 'new' settings.  But 
the way CHANGED is being handled in this patch seems problematic.

Regards,
-Denis

             reply	other threads:[~2021-11-11 20:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 20:21 Denis Kenzior [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-13  1:15 [PATCH 1/9] netconfig: Refactor setting new values to system Andrew Zaborowski
2021-11-11 20:07 Denis Kenzior
2021-11-11 19:29 Andrew Zaborowski
2021-11-11 18:22 Denis Kenzior
2021-11-11 16:54 Andrew Zaborowski
2021-11-10 17:51 Denis Kenzior
2021-11-08 11:28 Andrew Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9091fe7-3d70-bce6-eefe-48cba090d0a0@gmail.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.