From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
Prike Liang <Prike.Liang@amd.com>,
rrangel@chromium.org, david.e.box@linux.intel.com,
Shyam-sundar S-k <Shyam-sundar.S-k@amd.com>,
Alexander Deucher <Alexander.Deucher@amd.com>,
bhelgaas@google.com
Subject: Re: [PATCH v2] nvme: Look for StorageD3Enable on companion ACPI device instead
Date: Thu, 27 May 2021 09:44:41 -0500 [thread overview]
Message-ID: <c911ed05-071f-ddcd-7f76-9cb7535dd01b@amd.com> (raw)
In-Reply-To: <20210527143548.GA32170@lst.de>
On 5/27/2021 09:35, Christoph Hellwig wrote:
> Adding Raul who has been asking for something like this as well.
>
I thought I already included him on CC. Sorry if I munged the email or
something.
> I'd also really like to move nvme_acpi_storage_d3 out of the NVMe
> driver. The Microsoft document that the original document references
> makes it very clear that this is not NVMe specific, but also covers
> at least AHCI. On top of that the platform simply can't know what kind
> of PCIe device is in any given slot. Last but not least this will also
> allow us to add quirks for devices that fail to properly mark this
> misfeature in the ACPI tables.
>
+Bjorn
Back when this feature was first submitted, that was actually the
initial way that it was done, but Bjorn had preferred to see it move
into the NVME driver directly:
https://lore.kernel.org/linux-nvme/20200625173053.GA2694537@bjorn-Precision-5520/
Bjorn, are you OK with this coming "back" to PCI based on Christoph's
comments?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-27 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 13:59 [PATCH v2] nvme: Look for StorageD3Enable on companion ACPI device instead Mario Limonciello
2021-05-27 14:35 ` Christoph Hellwig
2021-05-27 14:44 ` Limonciello, Mario [this message]
2021-05-27 15:52 ` Bjorn Helgaas
2021-05-27 16:58 ` Keith Busch
2021-05-27 17:03 ` Limonciello, Mario
2021-05-27 17:28 ` Christoph Hellwig
2021-05-27 15:53 ` Raul Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c911ed05-071f-ddcd-7f76-9cb7535dd01b@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=rrangel@chromium.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.