* [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment
@ 2022-04-03 9:20 Fabrice Fontaine
2022-04-03 9:20 ` [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++ Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2022-04-03 9:20 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Fabrice Fontaine, Asaf Kahlon
python-brotli needs C++ since its addition in commit
2f176b837bbd2eb5ab4d23b7ba0528e548287aa7 so add a comment about it
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/python-brotli/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/python-brotli/Config.in b/package/python-brotli/Config.in
index 1c09c26866..c31315392b 100644
--- a/package/python-brotli/Config.in
+++ b/package/python-brotli/Config.in
@@ -5,3 +5,6 @@ config BR2_PACKAGE_PYTHON_BROTLI
Python bindings for the Brotli compression library.
https://github.com/google/brotli
+
+comment "python-brotli needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++
2022-04-03 9:20 [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Fabrice Fontaine
@ 2022-04-03 9:20 ` Fabrice Fontaine
2022-04-09 14:02 ` Peter Korsgaard
2022-04-04 19:29 ` [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Arnout Vandecappelle
2022-04-09 14:02 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2022-04-03 9:20 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Fabrice Fontaine, Asaf Kahlon
Commit b33e39e3ea5078cc80d9658e8af63049189bd475 forgot to add C++
dependency from python-brotli
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/python-weasyprint/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/python-weasyprint/Config.in b/package/python-weasyprint/Config.in
index 4a7e5a513d..7fe99c3951 100644
--- a/package/python-weasyprint/Config.in
+++ b/package/python-weasyprint/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_PYTHON_WEASYPRINT
bool "python-weasyprint"
+ depends on BR2_INSTALL_LIBSTDCPP # python-brotli
select BR2_PACKAGE_PYTHON_BROTLI # runtime
select BR2_PACKAGE_PYTHON_CFFI # runtime
select BR2_PACKAGE_PYTHON_CSSSELECT2 # runtime
@@ -14,3 +15,6 @@ config BR2_PACKAGE_PYTHON_WEASYPRINT
The Awesome Document Factory.
https://www.courtbouillon.org/weasyprint
+
+comment "python-weasyprint needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment
2022-04-03 9:20 [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Fabrice Fontaine
2022-04-03 9:20 ` [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++ Fabrice Fontaine
@ 2022-04-04 19:29 ` Arnout Vandecappelle
2022-04-09 14:02 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2022-04-04 19:29 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: James Hilliard, Asaf Kahlon
On 03/04/2022 11:20, Fabrice Fontaine wrote:
> python-brotli needs C++ since its addition in commit
> 2f176b837bbd2eb5ab4d23b7ba0528e548287aa7 so add a comment about it
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied both to master, thanks.
Regards,
Arnout
> ---
> package/python-brotli/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/python-brotli/Config.in b/package/python-brotli/Config.in
> index 1c09c26866..c31315392b 100644
> --- a/package/python-brotli/Config.in
> +++ b/package/python-brotli/Config.in
> @@ -5,3 +5,6 @@ config BR2_PACKAGE_PYTHON_BROTLI
> Python bindings for the Brotli compression library.
>
> https://github.com/google/brotli
> +
> +comment "python-brotli needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment
2022-04-03 9:20 [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Fabrice Fontaine
2022-04-03 9:20 ` [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++ Fabrice Fontaine
2022-04-04 19:29 ` [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Arnout Vandecappelle
@ 2022-04-09 14:02 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-04-09 14:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: James Hilliard, Asaf Kahlon, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> python-brotli needs C++ since its addition in commit
> 2f176b837bbd2eb5ab4d23b7ba0528e548287aa7 so add a comment about it
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++
2022-04-03 9:20 ` [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++ Fabrice Fontaine
@ 2022-04-09 14:02 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-04-09 14:02 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: James Hilliard, Asaf Kahlon, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit b33e39e3ea5078cc80d9658e8af63049189bd475 forgot to add C++
> dependency from python-brotli
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-09 14:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-03 9:20 [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Fabrice Fontaine
2022-04-03 9:20 ` [Buildroot] [PATCH 2/2] package/python-weasyprint: needs C++ Fabrice Fontaine
2022-04-09 14:02 ` Peter Korsgaard
2022-04-04 19:29 ` [Buildroot] [PATCH 1/2] package/python-brotli: add missing C++ comment Arnout Vandecappelle
2022-04-09 14:02 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.