From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5741EC433DF for ; Thu, 4 Jun 2020 18:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41E2A20738 for ; Thu, 4 Jun 2020 18:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730384AbgFDSCa (ORCPT ); Thu, 4 Jun 2020 14:02:30 -0400 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:59524 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730055AbgFDSCa (ORCPT ); Thu, 4 Jun 2020 14:02:30 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 99980F4D1E; Thu, 4 Jun 2020 18:02:27 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sugar90_6017dc626d99 X-Filterd-Recvd-Size: 3603 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 18:02:25 +0000 (UTC) Message-ID: Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter Cc: Julia Lawall , Linus Walleij , Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Date: Thu, 04 Jun 2020 11:02:23 -0700 In-Reply-To: <20200604173500.GI22511@kadam> References: <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> <20200604173500.GI22511@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 2020-06-04 at 20:35 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 09:08:44AM -0700, Joe Perches wrote: > > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > > OK, I recall a discussion with Dan where he suggested that some things > > > > that were not actually bug fixes could also merit a Fixes tag. But it's > > > > probably better if he weighs in directly. > > > > > > I generally think Fixes should only be used for "real bug" fixes. > > > > > > The one exception is when I'm reviewing a patch that fixes an "unused > > > assignment" static checker warning is that I know which commit > > > introduced the warning. Sometimes those warnings are introduced by new compiler versions. That's why I don't care for -Werror use in Makefiles. > > > I don't have strong feelings if it's in the > > > Fixes tag or if it's just mentioned in the commit message. > > > > My view is that changes that silence compiler warnings are > > not fixing bugs and that these changes should generally not > > be backported. > > > The Fixes tag is useful for backports but that's not whole the point of > it. It's also for collecting metrics. Hmm, how are these metrics used? > Also sometimes we fix the bug > before the kernel is released so the Fixes tag means we can automatically > ignore those ones when we look at which patches to backport. > > I don't care if the "unused assignment" patches use a Fixes tag or just > mention the commit. Either way the information is there for when I > review the patch. Perhaps there could/should be some distinction between "real bug" fixes and trivialities like "unused assignment" Maybe something like: Updates: ("commit description") vs Fixes: ("commit description") From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Thu, 04 Jun 2020 18:02:23 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: List-Id: References: <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> <20200604173500.GI22511@kadam> In-Reply-To: <20200604173500.GI22511@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , Julia Lawall , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Linux ARM , Robert Jarzmik , Daniel Mack On Thu, 2020-06-04 at 20:35 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 09:08:44AM -0700, Joe Perches wrote: > > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > > OK, I recall a discussion with Dan where he suggested that some things > > > > that were not actually bug fixes could also merit a Fixes tag. But it's > > > > probably better if he weighs in directly. > > > > > > I generally think Fixes should only be used for "real bug" fixes. > > > > > > The one exception is when I'm reviewing a patch that fixes an "unused > > > assignment" static checker warning is that I know which commit > > > introduced the warning. Sometimes those warnings are introduced by new compiler versions. That's why I don't care for -Werror use in Makefiles. > > > I don't have strong feelings if it's in the > > > Fixes tag or if it's just mentioned in the commit message. > > > > My view is that changes that silence compiler warnings are > > not fixing bugs and that these changes should generally not > > be backported. > > > The Fixes tag is useful for backports but that's not whole the point of > it. It's also for collecting metrics. Hmm, how are these metrics used? > Also sometimes we fix the bug > before the kernel is released so the Fixes tag means we can automatically > ignore those ones when we look at which patches to backport. > > I don't care if the "unused assignment" patches use a Fixes tag or just > mention the commit. Either way the information is there for when I > review the patch. Perhaps there could/should be some distinction between "real bug" fixes and trivialities like "unused assignment" Maybe something like: Updates: ("commit description") vs Fixes: ("commit description") From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374ECC433E0 for ; Thu, 4 Jun 2020 18:02:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D96A8206E6 for ; Thu, 4 Jun 2020 18:02:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TnM1/wQF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D96A8206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cwbpwB8qHzzXNrAc5nbffvHFYjJ6FWsNXde5dBybaek=; b=TnM1/wQFw6IuBj Y9y6WawHS6m+QOG7wdftDrH2fO012IA6ClTEgvBmJaXp3dGjUYF3neR4VJ2xofggX4xEH6cj2PJcm aFWiKBSsfJK/Ushknyv3J1ejzawURCrh+5GvRO0UqIV0f0iX1czsznnJUcp4vEva9bOz7ysomg6lI ipijtVVbvbmk2m/KMJKsBatUJ1E+4+f5yjaAK/lTQrYVD5jYhI9CHnkl152rPEi/l6CpOAkOfC6/k 2ExEo5W2FSO5PRX2Syf1Qo8PRHZYQewitoSUoghNCjlckFd1IE0sDfLIlbTWfyIT/s9rf0oz0hty3 Iz/fmjo4P7LosnXOGSSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jguCO-0008OW-91; Thu, 04 Jun 2020 18:02:40 +0000 Received: from smtprelay0233.hostedemail.com ([216.40.44.233] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jguCG-0008FZ-9r for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 18:02:33 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 99980F4D1E; Thu, 4 Jun 2020 18:02:27 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sugar90_6017dc626d99 X-Filterd-Recvd-Size: 3603 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Jun 2020 18:02:25 +0000 (UTC) Message-ID: Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken From: Joe Perches To: Dan Carpenter Date: Thu, 04 Jun 2020 11:02:23 -0700 In-Reply-To: <20200604173500.GI22511@kadam> References: <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> <20200604123038.GG22511@kadam> <0749ac5e3868c6ba50728ced8366bfd86b0b8500.camel@perches.com> <20200604173500.GI22511@kadam> User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_110232_414233_0C7F9FC8 X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , Julia Lawall , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Linux ARM , Robert Jarzmik , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-06-04 at 20:35 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 09:08:44AM -0700, Joe Perches wrote: > > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > > OK, I recall a discussion with Dan where he suggested that some things > > > > that were not actually bug fixes could also merit a Fixes tag. But it's > > > > probably better if he weighs in directly. > > > > > > I generally think Fixes should only be used for "real bug" fixes. > > > > > > The one exception is when I'm reviewing a patch that fixes an "unused > > > assignment" static checker warning is that I know which commit > > > introduced the warning. Sometimes those warnings are introduced by new compiler versions. That's why I don't care for -Werror use in Makefiles. > > > I don't have strong feelings if it's in the > > > Fixes tag or if it's just mentioned in the commit message. > > > > My view is that changes that silence compiler warnings are > > not fixing bugs and that these changes should generally not > > be backported. > > > The Fixes tag is useful for backports but that's not whole the point of > it. It's also for collecting metrics. Hmm, how are these metrics used? > Also sometimes we fix the bug > before the kernel is released so the Fixes tag means we can automatically > ignore those ones when we look at which patches to backport. > > I don't care if the "unused assignment" patches use a Fixes tag or just > mention the commit. Either way the information is there for when I > review the patch. Perhaps there could/should be some distinction between "real bug" fixes and trivialities like "unused assignment" Maybe something like: Updates: ("commit description") vs Fixes: ("commit description") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel