From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C497C433E0 for ; Mon, 8 Feb 2021 08:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 194A264E79 for ; Mon, 8 Feb 2021 08:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbhBHIAL (ORCPT ); Mon, 8 Feb 2021 03:00:11 -0500 Received: from esa.microchip.iphmx.com ([68.232.153.233]:65131 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbhBHIAF (ORCPT ); Mon, 8 Feb 2021 03:00:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1612771204; x=1644307204; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=z+w7Mvvg6cUtm7ma3xZyXbJcjOiFh98Ub1LCtlB9I0g=; b=R3QwRI4tT5xPozXhMMVnlRanBssi0U5aJejxaOpydqUx3rfiIrpIUq9K mTnhxjegi1rLuX/9YwHrybP+JqD9ii5505Gsj8LUN+h/XDNBqx9DbaInx pyksHjIAMITN0SB415/zuwY560+NBcvdbTOcO9RKFE4r7xMweVaxx3NbA LQazpJOWUYQVo/DALa45Dr/jYwyCUE8Yi+3EjIQ1gfeMiGNhjN/q/KIIP 5zFip5Mqxamft4Ss0QY8GAx6yPyjp59IhyFbuTxFav/7hgNh37yrd4NhF GwLDsOuxHqSktouK1vtmbOFcIeLyt9Wr/VHPsknmBHWe3ECgOOI34EmvR Q==; IronPort-SDR: 3R5QdFTRqJQ1gDxGnjeDcTAQgig8r0JNc8C5/xdHrp6Lam+gW2wDgdVEuiq2xdwPoc7hjAOFBf Yet1T77N+alC+S/0oltATEDO2sMmMJBPRrsQ05p6PfO8IwCtbxkZ+kaBYRWWT/lvVYaogftOKS U9V4/OdEA6Sx/geUkXUePgaPpTnVIPK9p3jPf8Q5ZHhDsTlsFAWf+Rrc5FChGEYTAbTYoJ+WkA Uy567tlf6LT6eVOI1BouhCMsCNXy+ad7NdE5LyeofbUGAGWkcq48f4wIJK6CGZXs43MH5Ks61x 10k= X-IronPort-AV: E=Sophos;i="5.81,161,1610434800"; d="scan'208";a="108874727" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Feb 2021 00:58:42 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 8 Feb 2021 00:58:42 -0700 Received: from tyr.hegelund-hansen.dk (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 8 Feb 2021 00:58:40 -0700 Message-ID: Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver From: Steen Hegelund To: Rob Herring CC: Philipp Zabel , Andrew Lunn , Microchip Linux Driver Support , "Alexandre Belloni" , Gregory Clement , , , Date: Mon, 8 Feb 2021 08:58:40 +0100 In-Reply-To: <20210205223526.GA3869001@robh.at.kernel.org> References: <20210120081921.3315847-1-steen.hegelund@microchip.com> <20210120081921.3315847-4-steen.hegelund@microchip.com> <20210205223526.GA3869001@robh.at.kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote: > > This provides reset driver support for the Microchip Sparx5 PCB134 > > and > > PCB135 reference boards. > > This isn't a compatible change. You need an explanation why that's > okay > if that's intended. > > > > > Signed-off-by: Steen Hegelund > > --- > >  arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++--- > >  1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 380281f312d8..4edbb9fcdce0 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -132,9 +132,17 @@ mux: mux-controller { > >                       }; > >               }; > > > > -             reset@611010008 { > > -                     compatible = "microchip,sparx5-chip-reset"; > > -                     reg = <0x6 0x11010008 0x4>; > > +             gcb_ctrl: syscon@611010000 { > > +                     compatible = "microchip,sparx5-gcb-syscon", > > "syscon"; > > +                     reg = <0x6 0x11010000 0x10000>; > > +             }; > > + > > +             reset: reset-controller@0 { > > +                     compatible = "microchip,sparx5-switch-reset"; > > +                     reg = <0x6 0x0 0x0>; > > Your register length is 0? Yes, I only use the syscons. > > > +                     #reset-cells = <1>; > > +                     cpu-syscon = <&cpu_ctrl>; > > Can't you accomplish the same thing adding these to > "microchip,sparx5-chip-reset"? Or possibly as a child node. > > Define nodes based on h/w blocks, not as containers of things you > happen > to want for some driver. Yes - I think the idea of using syscons came from another reset driver, but it probably makes more sense to just use IO ranges directly. I will try that out. > > > +                     gcb-syscon = <&gcb_ctrl>; > >               }; > > > >               uart0: serial@600100000 { > > -- > > 2.29.2 > > Thanks for your comments BR Steen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81609C433DB for ; Mon, 8 Feb 2021 08:00:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1CE064E42 for ; Mon, 8 Feb 2021 08:00:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1CE064E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+Ae5RR1YBYMDxfaMjcjTavdrqSU2iYZWNm2GggpP10w=; b=lrpHLZIgluvWmCJ0VAsr6+2xf U5rBHzs2nCM5+/VFWNtJq489wieb6Yk2FH0XHhK/6OEih+48T73gVD5DDsk4naVdu24IbRG2bBcgZ MHr2Ghfwi3PbdJhtTTTtdrwRwWKY0lEJG6lsXGYreu2DvKQ9Aag+coV7Dn3wbjU87NLIoCy6Ds84s SsGTWq5eujTg82trAbWz7+YQ5lizYXLXQU3wVhuq/7IEdaycltAvjI+WRCdFgEoyEVycJv53D3VKR 1/eNS/pYJ/BGzlVLBzUGeyOuXIuJAXTk9Id/vZu3qzTJhdsvBtHTdOmOauXQHlVfnvvKSNqcV0XpM moG57Bq4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l91RX-0006BT-KQ; Mon, 08 Feb 2021 07:58:47 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l91RU-0006Ax-Rr for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 07:58:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1612771124; x=1644307124; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=z+w7Mvvg6cUtm7ma3xZyXbJcjOiFh98Ub1LCtlB9I0g=; b=eFQEYhEAEKzAXaqHlg/ibFvwMM3Uw2zcvX/AcSb10optxeF/KhHrebZP tMEmK3VbutPmf1os6tpEqoCn9wRs0F+xtcGS5/OU6MEbb/VxH/EIKr/un nkXJY3PGnscKrP6Tb8krC2V/p5fE2bR+FPAwi7JhbP1/1EWjozqkB8PCD HYD94Q87Qh7Uaj5Bu42lCwNNoom/R0xO88+2WUsQ3WwR9EfUz6OFWSR1N TaR0k9hrJOL7FiKFJl42019+9TUuvwH8LlNT0Is7PaDYgnEFRCtcDrkF2 qlW9XegLSpWOwOXst6Uz9CSXWW5wu/E0K4SXaYhl/NicCLI8alMBRu2Kk w==; IronPort-SDR: 3R5QdFTRqJQ1gDxGnjeDcTAQgig8r0JNc8C5/xdHrp6Lam+gW2wDgdVEuiq2xdwPoc7hjAOFBf Yet1T77N+alC+S/0oltATEDO2sMmMJBPRrsQ05p6PfO8IwCtbxkZ+kaBYRWWT/lvVYaogftOKS U9V4/OdEA6Sx/geUkXUePgaPpTnVIPK9p3jPf8Q5ZHhDsTlsFAWf+Rrc5FChGEYTAbTYoJ+WkA Uy567tlf6LT6eVOI1BouhCMsCNXy+ad7NdE5LyeofbUGAGWkcq48f4wIJK6CGZXs43MH5Ks61x 10k= X-IronPort-AV: E=Sophos;i="5.81,161,1610434800"; d="scan'208";a="108874727" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Feb 2021 00:58:42 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 8 Feb 2021 00:58:42 -0700 Received: from tyr.hegelund-hansen.dk (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 8 Feb 2021 00:58:40 -0700 Message-ID: Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver From: Steen Hegelund To: Rob Herring Date: Mon, 8 Feb 2021 08:58:40 +0100 In-Reply-To: <20210205223526.GA3869001@robh.at.kernel.org> References: <20210120081921.3315847-1-steen.hegelund@microchip.com> <20210120081921.3315847-4-steen.hegelund@microchip.com> <20210205223526.GA3869001@robh.at.kernel.org> User-Agent: Evolution 3.38.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_025845_093433_E13491C8 X-CRM114-Status: GOOD ( 21.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , devicetree@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Philipp Zabel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iLAoKT24gRnJpLCAyMDIxLTAyLTA1IGF0IDE2OjM1IC0wNjAwLCBSb2IgSGVycmluZyB3 cm90ZToKPiBFWFRFUk5BTCBFTUFJTDogRG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNo bWVudHMgdW5sZXNzIHlvdQo+IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+IAo+IE9uIFdlZCwg SmFuIDIwLCAyMDIxIGF0IDA5OjE5OjIxQU0gKzAxMDAsIFN0ZWVuIEhlZ2VsdW5kIHdyb3RlOgo+ ID4gVGhpcyBwcm92aWRlcyByZXNldCBkcml2ZXIgc3VwcG9ydCBmb3IgdGhlIE1pY3JvY2hpcCBT cGFyeDUgUENCMTM0Cj4gPiBhbmQKPiA+IFBDQjEzNSByZWZlcmVuY2UgYm9hcmRzLgo+IAo+IFRo aXMgaXNuJ3QgYSBjb21wYXRpYmxlIGNoYW5nZS4gWW91IG5lZWQgYW4gZXhwbGFuYXRpb24gd2h5 IHRoYXQncwo+IG9rYXkKPiBpZiB0aGF0J3MgaW50ZW5kZWQuCj4gCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IFN0ZWVuIEhlZ2VsdW5kIDxzdGVlbi5oZWdlbHVuZEBtaWNyb2NoaXAuY29tPgo+ID4g LS0tCj4gPiDCoGFyY2gvYXJtNjQvYm9vdC9kdHMvbWljcm9jaGlwL3NwYXJ4NS5kdHNpIHwgMTQg KysrKysrKysrKystLS0KPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21p Y3JvY2hpcC9zcGFyeDUuZHRzaQo+ID4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL21pY3JvY2hpcC9z cGFyeDUuZHRzaQo+ID4gaW5kZXggMzgwMjgxZjMxMmQ4Li40ZWRiYjlmY2RjZTAgMTAwNjQ0Cj4g PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21pY3JvY2hpcC9zcGFyeDUuZHRzaQo+ID4gKysr IGIvYXJjaC9hcm02NC9ib290L2R0cy9taWNyb2NoaXAvc3Bhcng1LmR0c2kKPiA+IEBAIC0xMzIs OSArMTMyLDE3IEBAIG11eDogbXV4LWNvbnRyb2xsZXIgewo+ID4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCB9Owo+ID4gCj4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJlc2V0QDYxMTAxMDAwOCB7 Cj4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb21wYXRpYmxl ID0gIm1pY3JvY2hpcCxzcGFyeDUtY2hpcC1yZXNldCI7Cj4gPiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZWcgPSA8MHg2IDB4MTEwMTAwMDggMHg0PjsKPiA+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2NiX2N0cmw6IHN5c2NvbkA2MTEwMTAwMDAgewo+ID4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJt aWNyb2NoaXAsc3Bhcng1LWdjYi1zeXNjb24iLAo+ID4gInN5c2NvbiI7Cj4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZWcgPSA8MHg2IDB4MTEwMTAwMDAgMHgx MDAwMD47Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07Cj4gPiArCj4gPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHJlc2V0OiByZXNldC1jb250cm9sbGVyQDAgewo+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJtaWNyb2No aXAsc3Bhcng1LXN3aXRjaC1yZXNldCI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCByZWcgPSA8MHg2IDB4MCAweDA+Owo+IAo+IFlvdXIgcmVnaXN0ZXIgbGVu Z3RoIGlzIDA/CgpZZXMsIEkgb25seSB1c2UgdGhlIHN5c2NvbnMuCgo+IAo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgI3Jlc2V0LWNlbGxzID0gPDE+Owo+ID4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY3B1LXN5c2NvbiA9IDwm Y3B1X2N0cmw+Owo+IAo+IENhbid0IHlvdSBhY2NvbXBsaXNoIHRoZSBzYW1lIHRoaW5nIGFkZGlu ZyB0aGVzZSB0bwo+ICJtaWNyb2NoaXAsc3Bhcng1LWNoaXAtcmVzZXQiPyBPciBwb3NzaWJseSBh cyBhIGNoaWxkIG5vZGUuCj4gCj4gRGVmaW5lIG5vZGVzIGJhc2VkIG9uIGgvdyBibG9ja3MsIG5v dCBhcyBjb250YWluZXJzIG9mIHRoaW5ncyB5b3UKPiBoYXBwZW4KPiB0byB3YW50IGZvciBzb21l IGRyaXZlci4KClllcyAtIEkgdGhpbmsgdGhlIGlkZWEgb2YgdXNpbmcgc3lzY29ucyBjYW1lIGZy b20gYW5vdGhlciByZXNldCBkcml2ZXIsCmJ1dCBpdCBwcm9iYWJseSBtYWtlcyBtb3JlIHNlbnNl IHRvIGp1c3QgdXNlIElPIHJhbmdlcyBkaXJlY3RseS4KSSB3aWxsIHRyeSB0aGF0IG91dC4KCj4g Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnY2Itc3lzY29u ID0gPCZnY2JfY3RybD47Cj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9Owo+ID4gCj4g PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1YXJ0MDogc2VyaWFsQDYwMDEwMDAwMCB7Cj4g PiAtLQo+ID4gMi4yOS4yCj4gPiAKClRoYW5rcyBmb3IgeW91ciBjb21tZW50cwoKQlIKU3RlZW4K CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=