From: "Björn Töpel" <bjorn.topel@intel.com>
To: "Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Björn Töpel" <bjorn.topel@gmail.com>
Cc: Maxim Mikityanskiy <maximmi@mellanox.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Cameron Elliott <cameron@cameronelliott.com>,
Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: Cannot run multiple 'xdpsock' concurrently?
Date: Tue, 4 Feb 2020 18:20:48 +0100 [thread overview]
Message-ID: <c92afb6b-28a3-3ec5-f358-b434d73617c4@intel.com> (raw)
In-Reply-To: <20200204094640.GA46254@ranger.igk.intel.com>
On 2020-02-04 10:46, Maciej Fijalkowski wrote:
> On Tue, Feb 04, 2020 at 04:41:31PM +0100, Björn Töpel wrote:
[...]
>
> So to summarize that:
> - return EAGAIN instead of ENETDOWN within ndo_xsk_wakeup implementations
> in i40e/ixgbe,
> - check for ENETDOWN in kick_tx() as well
>
> Do you guys agree?
>
Well, start with latter. From some perspective, changing the return
value is ABI breakage, no?
> What about timeout and syscall repetition? That's the last question.
>
Hmm, timeout in what context? When to redo the syscall?
next prev parent reply other threads:[~2020-02-04 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMyc9bVixUDEJ-WHLJaCCTF3iV4pFF2j+RPM0hM1XOKh6S2yBw@mail.gmail.com>
2020-02-03 9:53 ` Cannot run multiple 'xdpsock' concurrently? Magnus Karlsson
2020-02-03 3:11 ` Maciej Fijalkowski
2020-02-03 11:49 ` Maxim Mikityanskiy
2020-02-04 6:50 ` Maciej Fijalkowski
2020-02-04 15:41 ` Björn Töpel
2020-02-04 9:46 ` Maciej Fijalkowski
2020-02-04 17:20 ` Björn Töpel [this message]
2020-02-06 7:02 ` Magnus Karlsson
2020-01-31 2:15 Cameron Elliott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c92afb6b-28a3-3ec5-f358-b434d73617c4@intel.com \
--to=bjorn.topel@intel.com \
--cc=bjorn.topel@gmail.com \
--cc=cameron@cameronelliott.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=maximmi@mellanox.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.