Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail

From: "Kumar, Mahesh" <mahesh1.kumar@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail
Date: Tue, 3 Jul 2018 11:34:59 +0530	[thread overview]
Message-ID: <c930a5d2-4b2b-5ff4-efa7-ca912f36fbaf@intel.com> (raw)
In-Reply-To: <da51a9ab-16b2-d83b-f6e5-a7615a1b7ad2@linux.intel.com>

Hi,


On 7/2/2018 4:57 PM, Maarten Lankhorst wrote:
> Op 02-07-18 om 13:16 schreef Mahesh Kumar:
>> Now crc-core framework verifies the source string passed by the user.
>> So setting bad-source will fail. Expect file write to fail in bad-source
>> subtest of kms_pipe_crc_basic.
>>
>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
>> ---
>>   tests/kms_pipe_crc_basic.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
>> index 235fdc38..2d4dfee8 100644
>> --- a/tests/kms_pipe_crc_basic.c
>> +++ b/tests/kms_pipe_crc_basic.c
>> @@ -48,8 +48,7 @@ static struct {
>>   
>>   static void test_bad_source(data_t *data)
>>   {
>> -	igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo"));
>> -	igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1);
>> +	igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo"));
>>   }
>>   
>>   #define N_CRCS	3
> New behavior makes more sense.
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Do you have igt commit rights?
thanks for review.
I don't have commit rights
-Mahesh

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx