From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76C0C433DF for ; Fri, 5 Jun 2020 17:22:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86168206F0 for ; Fri, 5 Jun 2020 17:22:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rDwb7Nx+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RHHwqIuf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86168206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PEpNp3o9TSpQEAvR006qX5T2/ZdIOa73PYvz6CMqnu4=; b=rDwb7Nx+vMDueG Y5vwNJXQZEC5iJGA77Yop4+V4uA9+4Tdx82+TT10vfotlzL0eetAwiwV/9Yv1Abu8/aP5C14S+d3T oMR77eAKIfed3xy30Hn6ljZcKXSWQjH5ELkZFfxvu0PgDIhUCtx4YjJlXXXvmJ4NZGU+kRU6mHSmz 4ZkIGRHekzuR4VqkkADksx2x/ZvURSVAWsDTS861NLVRrwt/4oSCStLsOWiRbesjCztYuUdsJW/xl jmletvnUIoEDZH/vfYoFD0SadcCbkdaOMM0kkk/hyFV3YKuXyhIC4jKttfxYxCqCezWBXtFtzmn4L Ehau1tuFFcjWOjbDq3Bw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhG2z-0006fh-L7; Fri, 05 Jun 2020 17:22:25 +0000 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhG2x-0006f8-5E for linux-snps-arc@lists.infradead.org; Fri, 05 Jun 2020 17:22:24 +0000 Received: by mail-qv1-xf41.google.com with SMTP id fc4so5080368qvb.1 for ; Fri, 05 Jun 2020 10:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EPrN8Gy0hYJfvfB0KRGYr2I65rcOp1Mwdxm1TydNnNE=; b=RHHwqIufi0PjGAguRJZGycwjectpcbry23WkFE3zdvxDJUX30pyLJfbXpM85khsH1z lo8N5FjD1dnVxEGLltqY6BVWbKTLVrwpMWH8kI5HPBqUpr0heIQyIMdL8Vm4NCZ6J/xp 0x++YYW7HF1MnlQPap+NRS1aqkWRwL127Ixstbt7djXcwQpHUuVb3JCdJdaUyGPG0U2K PH7hz/0r8IpW/JIKNOgmU7OT/nxwVpX+TMBbq0sh2vfOWildDUUSsrpg/fXRgpQelE4N pRzrj2eAWDisuyOweD+zvHuZr2sn3KDAhsfkZnvci4UkYAfaHL12UyKhu/TPJF51O6iR O75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EPrN8Gy0hYJfvfB0KRGYr2I65rcOp1Mwdxm1TydNnNE=; b=sB4L99rdC+Zp06VAyyICpM01GhCwMuU63PZEt0UeXiR/58bf82iuRZ+GGL0XBWhaiq PzD7gMYY/fEQCWHG4jw7T5CHlUPQHpNFlBHJplDXa5MOGye5Rq493ZNYVxoFKKVMJxcs cdQWpftU9jOrAgPclNyPdf1ZRfJ1zrQO4U7g81QKe1uGFgJ3IsM2aKgNvx76JuoVdCkI EU5ZmjAaBsZHg604KJYtiUU9itkwmJ6VNstppe8kcpmTlVQChZkdz1S2egUbyoBu5Imy nVXGwNVerahtycvIvYhURpdJ9EA8oiOdxaf0+EuyzTKeWEaDj83uru/yLISs5SrMdiZM Rv6Q== X-Gm-Message-State: AOAM530cYbplrhUGfBaqCgAVi2+eiceoiofNLY5IeW1+m6zPVLuPdZtS VnI7DlWDX/51ngMBy+duiFTZaPbsKvE= X-Google-Smtp-Source: ABdhPJz8B7nbacXtM/jnO/nuNoBi0KwVE3M1JhudXPrZkkQCV5c4UghDHLPJh49yH/Mcv9m7LsfXjQ== X-Received: by 2002:a05:6214:12ec:: with SMTP id w12mr10893242qvv.107.1591377741349; Fri, 05 Jun 2020 10:22:21 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id k17sm384443qtb.5.2020.06.05.10.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2020 10:22:20 -0700 (PDT) Subject: Re: [PATCH v6 06/13] ARC: hardware floating point support To: Vineet Gupta , "libc-alpha@sourceware.org" References: <20200423014126.10417-1-vgupta@synopsys.com> <20200423014126.10417-7-vgupta@synopsys.com> <91c2aba8-bff5-5ddc-7a95-c93c90883150@synopsys.com> <5b06914d-acb3-4404-4ff2-93bb7a04f8f5@synopsys.com> <214245c7-c89b-22bf-25db-fc9148ac5f92@synopsys.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Fri, 5 Jun 2020 14:22:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <214245c7-c89b-22bf-25db-fc9148ac5f92@synopsys.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_102223_203543_BB7A5352 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-snps-arc@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 05/06/2020 01:44, Vineet Gupta wrote: > On 5/29/20 4:50 PM, Vineet Gupta via Libc-alpha wrote: >>>> Although this code follow other architectures, I think it woudl be better >>>> to move forward a macro that emulates function calls and use proper >>>> static inline function instead for _FPU_* (as for get-rounding-mode.h). >>> OK. do you have a preference for names, existing upper case names OK ? >> Something like below ? >> >> +# define _FPU_FPSR_FWE 0x80000000 >> + >> -# define _FPU_GETCW(cw) __asm__ volatile ("lr %0, [0x300]" : "=r" (cw)) >> -# define _FPU_SETCW(cw) __asm__ volatile ("sr %0, [0x300]" : : "r" (cw)) >> +static inline unsigned int arc_fpu_getcw(void) >> +{ >> + unsigned int cw; >> + __asm__ volatile ("lr %0, [0x300]" : "=r" (cw)); >> + return cw; >> +} >> + >> +static inline void arc_fpu_setcw(unsigned int cw) >> +{ >> + __asm__ volatile ("sr %0, [0x300]" : : "r" (cw)); >> +} > > It seems there is more discussiosn to be had here. Can we just punt on this > specific item and keep the status quo macros please. We are heading towards july > and I'd rather have the port go in this cycle ! I don't have a strong opinion here, it was more a suggestion. It seems to follow other architectures, although at least alpha does not provide the _FPU_GETCW macro. Another option would to just move this definition to an internal header as well. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc