All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC 0/4] media: Introduce post_register() subdev operation
Date: Fri, 18 Jun 2021 12:21:43 +0200	[thread overview]
Message-ID: <c97229bf-84a0-f5ba-b5fc-a14b563c2684@xs4all.nl> (raw)
In-Reply-To: <20210617171611.80542-1-jacopo+renesas@jmondi.org>

On 17/06/2021 19:16, Jacopo Mondi wrote:
> Hello Hans,
>    this is the result of the discussion we had yesterday, sent out just to
> have a taste of how it looks like.
> 
> I won't pretend I like the outcome: it feels a bit hackish and meant to support
> this precise use case.
> 
> Compared to the proposal to resurect 'init()' it indeed has the advantage that
> the subdevice driver works in both deffered and non-deferred mode, but the
> notifier flags seems really custom.
> 
> Also, being the new flag part of the notifier it won't be available for i2c
> subdevs.
> 
> What do you think ? Does the result match your understanding ?

That's what I came up with, yes. I think some of the names can be improved,
but otherwise the mechanism is what I had in mind.

Regards,

	Hans

> 
> Thanks
>   j
> 
> Jacopo Mondi (4):
>   media: v4l2-subdev: Introduce post_register() core op
>   media: v4l2-async: Add notifier flags
>   media: v4l2-async: Call post_register() subdev op
>   media: i2c: gmsl: Defer camera intialization
> 
>  drivers/media/i2c/max9286.c          | 21 ++++++--
>  drivers/media/i2c/rdacm20.c          | 81 ++++++++++++++++------------
>  drivers/media/v4l2-core/v4l2-async.c | 11 ++++
>  include/media/v4l2-async.h           | 10 ++++
>  include/media/v4l2-subdev.h          |  3 ++
>  5 files changed, 89 insertions(+), 37 deletions(-)
> 
> --
> 2.31.1
> 


  parent reply	other threads:[~2021-06-18 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:16 Jacopo Mondi
2021-06-17 17:16 ` [RFC 1/4] media: v4l2-subdev: Introduce post_register() core op Jacopo Mondi
2021-06-17 17:16 ` [RFC 2/4] media: v4l2-async: Add notifier flags Jacopo Mondi
2021-07-06  7:47   ` Hans Verkuil
2021-06-17 17:16 ` [RFC 3/4] media: v4l2-async: Call post_register() subdev op Jacopo Mondi
2021-06-17 17:16 ` [RFC 4/4] media: i2c: gmsl: Defer camera intialization Jacopo Mondi
2021-06-18 10:21 ` Hans Verkuil [this message]
2021-07-05 14:58   ` [RFC 0/4] media: Introduce post_register() subdev operation Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c97229bf-84a0-f5ba-b5fc-a14b563c2684@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --subject='Re: [RFC 0/4] media: Introduce post_register() subdev operation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.