All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Laura Nao <laura.nao@collabora.com>
Cc: andersson@kernel.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org,
	matthias.bgg@gmail.com, tinghan.shen@mediatek.com,
	wenst@chromium.org
Subject: Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility
Date: Thu, 21 Sep 2023 09:17:57 +0200	[thread overview]
Message-ID: <c9780f70-62b5-e151-0ac6-11d97a694439@collabora.com> (raw)
In-Reply-To: <20230920150332.318851-1-laura.nao@collabora.com>

Il 20/09/23 17:03, Laura Nao ha scritto:
> On 9/19/23 11:23, AngeloGioacchino Del Regno wrote:
>> In older devicetrees we had the ChromeOS EC in a node called "cros-ec"
>> instead of the newer "cros-ec-rpmsg", but this driver is now checking
>> only for the latter, breaking compatibility with those.
>>
>> Besides, we can check if the SCP is single or dual core by simply
>> walking through the children of the main SCP node and checking if
>> if there's more than one "mediatek,scp-core" compatible node.
>>
>> Fixes: 1fdbf0cdde98 ("remoteproc: mediatek: Probe SCP cluster on multi-core SCP")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>    drivers/remoteproc/mtk_scp.c | 18 +++++++-----------
>>    1 file changed, 7 insertions(+), 11 deletions(-)
>>
> 
> Tested on asurada (spherion) and jacuzzi (juniper). The issue was detected by KernelCI, so:
> 
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Tested-by: Laura Nao <laura.nao@collabora.com>
> 

Thanks for pointing out the correct Reported-by tag! :-)

Cheers,
Angelo


WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Laura Nao <laura.nao@collabora.com>
Cc: andersson@kernel.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org,
	matthias.bgg@gmail.com, tinghan.shen@mediatek.com,
	wenst@chromium.org
Subject: Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility
Date: Thu, 21 Sep 2023 09:17:57 +0200	[thread overview]
Message-ID: <c9780f70-62b5-e151-0ac6-11d97a694439@collabora.com> (raw)
In-Reply-To: <20230920150332.318851-1-laura.nao@collabora.com>

Il 20/09/23 17:03, Laura Nao ha scritto:
> On 9/19/23 11:23, AngeloGioacchino Del Regno wrote:
>> In older devicetrees we had the ChromeOS EC in a node called "cros-ec"
>> instead of the newer "cros-ec-rpmsg", but this driver is now checking
>> only for the latter, breaking compatibility with those.
>>
>> Besides, we can check if the SCP is single or dual core by simply
>> walking through the children of the main SCP node and checking if
>> if there's more than one "mediatek,scp-core" compatible node.
>>
>> Fixes: 1fdbf0cdde98 ("remoteproc: mediatek: Probe SCP cluster on multi-core SCP")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>    drivers/remoteproc/mtk_scp.c | 18 +++++++-----------
>>    1 file changed, 7 insertions(+), 11 deletions(-)
>>
> 
> Tested on asurada (spherion) and jacuzzi (juniper). The issue was detected by KernelCI, so:
> 
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Tested-by: Laura Nao <laura.nao@collabora.com>
> 

Thanks for pointing out the correct Reported-by tag! :-)

Cheers,
Angelo


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-09-21 20:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  9:23 [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility AngeloGioacchino Del Regno
2023-09-19  9:23 ` AngeloGioacchino Del Regno
2023-09-20 13:28 ` Mathieu Poirier
2023-09-20 13:28   ` Mathieu Poirier
2023-09-20 15:03 ` Laura Nao
2023-09-20 15:03   ` Laura Nao
2023-09-21  4:09   ` Chen-Yu Tsai
2023-09-21  4:09     ` Chen-Yu Tsai
2023-09-21  7:17   ` AngeloGioacchino Del Regno [this message]
2023-09-21  7:17     ` AngeloGioacchino Del Regno
2023-09-21 12:51 ` Mathieu Poirier
2023-09-21 12:51   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9780f70-62b5-e151-0ac6-11d97a694439@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=andersson@kernel.org \
    --cc=kernel@collabora.com \
    --cc=laura.nao@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=tinghan.shen@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.