All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, aurelien@aurel32.net,
	jiaxun.yang@flygoat.com, aleksandar.rikalo@syrmia.com,
	hpoussin@reactos.org, fthain@telegraphics.com.au
Subject: Re: [PATCH v2 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines)
Date: Fri, 2 Jul 2021 15:30:18 +0200	[thread overview]
Message-ID: <c985102d-434c-3c72-b2a6-5c29813e67fd@amsat.org> (raw)
In-Reply-To: <20210625163554.14879-1-mark.cave-ayland@ilande.co.uk>

On 6/25/21 6:35 PM, Mark Cave-Ayland wrote:
> I noticed whilst testing the previous dp8393x patchset that I would always
> get a segfault whilst attempting to migrate the MIPS magnum machine.
> 
> A bit of detective work shows that the problem is an incorrect VMStateDescription
> in the g364fb device which expects a G364State but instead receives a
> G364SysBusState.
> 
> Looking back through the git history suggests that migration for this device
> (and also the MIPS magnum machines) has been broken for several years, so patch
> 1 takes the opportunity to improve the migration stream for the framebuffer
> first whilst patch 2 contains the actual fix.
> 
> Note that I don't use the MIPS magnum machines on a regular basis but the
> patchset fixes the migration error and survives some light testing here.

> Mark Cave-Ayland (2):
>   g364fb: use RAM memory region for framebuffer
>   g364fb: add VMStateDescription for G364SysBusState
> 
>  hw/display/g364fb.c | 32 ++++++++++++++++++++------------
>  1 file changed, 20 insertions(+), 12 deletions(-)

Thanks, queued to mips-next.


      parent reply	other threads:[~2021-07-02 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 16:35 [PATCH v2 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines) Mark Cave-Ayland
2021-06-25 16:35 ` [PATCH v2 1/2] g364fb: use RAM memory region for framebuffer Mark Cave-Ayland
2021-06-25 16:35 ` [PATCH v2 2/2] g364fb: add VMStateDescription for G364SysBusState Mark Cave-Ayland
2021-06-25 17:04   ` Philippe Mathieu-Daudé
2021-07-02 13:30 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c985102d-434c-3c72-b2a6-5c29813e67fd@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=fthain@telegraphics.com.au \
    --cc=hpoussin@reactos.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.