Re: [PATCH 00/22] drm: Review of mode copies

From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Alex Deucher" <alexdeucher@gmail.com>
Cc: Emma Anholt <emma@anholt.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Xinliang Liu <xinliang.liu@linaro.org>,
	Maling list - DRI developers  <dri-devel@lists.freedesktop.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	<linux-rockchip@lists.infradead.org>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Aurabindo Pillai <aurabindo.pillai@amd.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Alain Volmat <alain.volmat@foss.st.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.se>, Leo Li <sunpeng.li@amd.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Nikola Cornij <nikola.cornij@amd.com>,
	Sean Paul <sean@poorly.run>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Tomi Valkeinen <tomba@kernel.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	Sandy Huang <hjc@rock-chips.com>,
	Robert Foss <robert.foss@linaro.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	Tian Tao <tiantao6@hisilicon.com>, Jyri Sarha <jyri.sarha@iki.fi>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 00/22] drm: Review of mode copies
Date: Wed, 23 Mar 2022 13:50:46 -0700	[thread overview]
Message-ID: <c9899a30-df55-06b1-c99d-66ccc9fa3edf@quicinc.com> (raw)
In-Reply-To: <e9937a37-70c8-cc6f-15f2-1dbbb7f1bfba@linaro.org>

On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote:
> On 22/03/2022 01:37, Ville Syrjälä wrote:
>> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote:
>>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä
>>> <ville.syrjala@linux.intel.com> wrote:
>>>>
>>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:
>>>>>    drm: Add drm_mode_init()
>>>>>    drm/bridge: Use drm_mode_copy()
>>>>>    drm/imx: Use drm_mode_duplicate()
>>>>>    drm/panel: Use drm_mode_duplicate()
>>>>>    drm/vc4: Use drm_mode_copy()
>>>> These have been pushed to drm-misc-next.
>>>>
>>>>>    drm/amdgpu: Remove pointless on stack mode copies
>>>>>    drm/amdgpu: Use drm_mode_init() for on-stack modes
>>>>>    drm/amdgpu: Use drm_mode_copy()
>>>> amdgpu ones are reviewed, but I'll leave them for the
>>>> AMD folks to push to whichever tree they prefer.
>>>
>>> I pulled patches 2, 4, 5 into my tree.
>>
>> Thanks.
>>
>>> For 3, I'm happy to have it
>>> land via drm-misc with the rest of the mode_init changes if you'd
>>> prefer.
>>
>> Either way works for me. I don't yet have reviews yet for
>> the other drivers, so I'll proably hold off for a bit more
>> at least. And the i915 patch I'll be merging via drm-intel.
>>
>>>>>    drm/radeon: Use drm_mode_copy()
>>>>>    drm/gma500: Use drm_mode_copy()
>>>>>    drm/tilcdc: Use drm_mode_copy()
>>>>>    drm/i915: Use drm_mode_copy()
>>
>> Those are now all in.
>>
>> Which leaves us with these stragglers:
>>>>>    drm/hisilicon: Use drm_mode_init() for on-stack modes
> 
>>>>>    drm/msm: Nuke weird on stack mode copy
>>>>>    drm/msm: Use drm_mode_init() for on-stack modes
>>>>>    drm/msm: Use drm_mode_copy()
> 
> These three patches went beneath my radar for some reason.
> 
> I have just sent a replacement for the first patch ([1]). Other two 
> patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next 
> development cycle if that works for you.
> 
> [1] https://patchwork.freedesktop.org/series/101682/

Agree with this approach.

We can replace the first patch with 
https://patchwork.freedesktop.org/series/101682/.

Thanks

Abhinav

> 
>>>>>    drm/mtk: Use drm_mode_init() for on-stack modes
>>>>>    drm/rockchip: Use drm_mode_copy()
>>>>>    drm/sti: Use drm_mode_copy()
>>>>>    drm: Use drm_mode_init() for on-stack modes
>>>>>    drm: Use drm_mode_copy()
>>
> 
> 