From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AA4C433EF for ; Wed, 23 Mar 2022 20:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344801AbiCWUwX (ORCPT ); Wed, 23 Mar 2022 16:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240768AbiCWUwW (ORCPT ); Wed, 23 Mar 2022 16:52:22 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02933710C6 for ; Wed, 23 Mar 2022 13:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" CC: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , , Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Chun-Kuang Hu , "Jonas Karlman" , Leo Li , Chen Feng , Intel Graphics Development , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: >> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >>> wrote: >>>> >>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>>>    drm: Add drm_mode_init() >>>>>    drm/bridge: Use drm_mode_copy() >>>>>    drm/imx: Use drm_mode_duplicate() >>>>>    drm/panel: Use drm_mode_duplicate() >>>>>    drm/vc4: Use drm_mode_copy() >>>> These have been pushed to drm-misc-next. >>>> >>>>>    drm/amdgpu: Remove pointless on stack mode copies >>>>>    drm/amdgpu: Use drm_mode_init() for on-stack modes >>>>>    drm/amdgpu: Use drm_mode_copy() >>>> amdgpu ones are reviewed, but I'll leave them for the >>>> AMD folks to push to whichever tree they prefer. >>> >>> I pulled patches 2, 4, 5 into my tree. >> >> Thanks. >> >>> For 3, I'm happy to have it >>> land via drm-misc with the rest of the mode_init changes if you'd >>> prefer. >> >> Either way works for me. I don't yet have reviews yet for >> the other drivers, so I'll proably hold off for a bit more >> at least. And the i915 patch I'll be merging via drm-intel. >> >>>>>    drm/radeon: Use drm_mode_copy() >>>>>    drm/gma500: Use drm_mode_copy() >>>>>    drm/tilcdc: Use drm_mode_copy() >>>>>    drm/i915: Use drm_mode_copy() >> >> Those are now all in. >> >> Which leaves us with these stragglers: >>>>>    drm/hisilicon: Use drm_mode_init() for on-stack modes > >>>>>    drm/msm: Nuke weird on stack mode copy >>>>>    drm/msm: Use drm_mode_init() for on-stack modes >>>>>    drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. > > [1] https://patchwork.freedesktop.org/series/101682/ Agree with this approach. We can replace the first patch with https://patchwork.freedesktop.org/series/101682/. Thanks Abhinav > >>>>>    drm/mtk: Use drm_mode_init() for on-stack modes >>>>>    drm/rockchip: Use drm_mode_copy() >>>>>    drm/sti: Use drm_mode_copy() >>>>>    drm: Use drm_mode_init() for on-stack modes >>>>>    drm: Use drm_mode_copy() >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5A8EC433EF for ; Wed, 23 Mar 2022 20:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=voDFwlg0wcjB9L4pnbuKftZRO6HoYj5BN8DSn9CRVjQ=; b=QEeScFTHY1zQqG 5ICsn3xAZSQgI50flKB6ei+jX6d8bQjgXkKxe58iz4d6LUKb2oWiGSMQlONu5GbeC31VXh3ST/DHT H1c2P20udH2G7UBJ7/dLDKhW4mvqG8lr1DczX7LZ/PlxEDRuHAQ03cPiLtYDhQkNiL4qG3lTdznDK j4tnR5iVWAfKtwjE9NFvw+GaQ+eX723uawbVaH49bobP5BQWfbN2VCoEJvv3NonZXUfcoc9DC3uGs iF0PSohv1Q+jZp9TBmLpFh0c28XmF98PKuhFvE7uLSewcnENnXQaB2EoprKrUswbm6gB+gxnjn+m/ pV6NpnOdo9J8jDIdoZiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX7wT-00EqnQ-M8; Wed, 23 Mar 2022 20:50:53 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX7wQ-00Eqmi-V1; Wed, 23 Mar 2022 20:50:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" CC: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , , Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Chun-Kuang Hu , "Jonas Karlman" , Leo Li , Chen Feng , Intel Graphics Development , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_135051_077947_08D59B17 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CgpPbiAzLzIzLzIwMjIgMzozOSBBTSwgRG1pdHJ5IEJhcnlzaGtvdiB3cm90ZToKPiBPbiAyMi8w My8yMDIyIDAxOjM3LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+IE9uIFR1ZSwgTWFyIDE1LCAy MDIyIGF0IDAyOjUyOjM4UE0gLTA0MDAsIEFsZXggRGV1Y2hlciB3cm90ZToKPj4+IE9uIE1vbiwg TWFyIDE0LCAyMDIyIGF0IDY6MTIgUE0gVmlsbGUgU3lyasOkbMOkCj4+PiA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4+Cj4+Pj4gT24gRnJpLCBGZWIgMTgsIDIwMjIg YXQgMTI6MDM6NDFQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3cm90ZToKPj4+Pj4gwqDCoCBkcm06 IEFkZCBkcm1fbW9kZV9pbml0KCkKPj4+Pj4gwqDCoCBkcm0vYnJpZGdlOiBVc2UgZHJtX21vZGVf Y29weSgpCj4+Pj4+IMKgwqAgZHJtL2lteDogVXNlIGRybV9tb2RlX2R1cGxpY2F0ZSgpCj4+Pj4+ IMKgwqAgZHJtL3BhbmVsOiBVc2UgZHJtX21vZGVfZHVwbGljYXRlKCkKPj4+Pj4gwqDCoCBkcm0v dmM0OiBVc2UgZHJtX21vZGVfY29weSgpCj4+Pj4gVGhlc2UgaGF2ZSBiZWVuIHB1c2hlZCB0byBk cm0tbWlzYy1uZXh0Lgo+Pj4+Cj4+Pj4+IMKgwqAgZHJtL2FtZGdwdTogUmVtb3ZlIHBvaW50bGVz cyBvbiBzdGFjayBtb2RlIGNvcGllcwo+Pj4+PiDCoMKgIGRybS9hbWRncHU6IFVzZSBkcm1fbW9k ZV9pbml0KCkgZm9yIG9uLXN0YWNrIG1vZGVzCj4+Pj4+IMKgwqAgZHJtL2FtZGdwdTogVXNlIGRy bV9tb2RlX2NvcHkoKQo+Pj4+IGFtZGdwdSBvbmVzIGFyZSByZXZpZXdlZCwgYnV0IEknbGwgbGVh dmUgdGhlbSBmb3IgdGhlCj4+Pj4gQU1EIGZvbGtzIHRvIHB1c2ggdG8gd2hpY2hldmVyIHRyZWUg dGhleSBwcmVmZXIuCj4+Pgo+Pj4gSSBwdWxsZWQgcGF0Y2hlcyAyLCA0LCA1IGludG8gbXkgdHJl ZS4KPj4KPj4gVGhhbmtzLgo+Pgo+Pj4gRm9yIDMsIEknbSBoYXBweSB0byBoYXZlIGl0Cj4+PiBs YW5kIHZpYSBkcm0tbWlzYyB3aXRoIHRoZSByZXN0IG9mIHRoZSBtb2RlX2luaXQgY2hhbmdlcyBp ZiB5b3UnZAo+Pj4gcHJlZmVyLgo+Pgo+PiBFaXRoZXIgd2F5IHdvcmtzIGZvciBtZS4gSSBkb24n dCB5ZXQgaGF2ZSByZXZpZXdzIHlldCBmb3IKPj4gdGhlIG90aGVyIGRyaXZlcnMsIHNvIEknbGwg cHJvYWJseSBob2xkIG9mZiBmb3IgYSBiaXQgbW9yZQo+PiBhdCBsZWFzdC4gQW5kIHRoZSBpOTE1 IHBhdGNoIEknbGwgYmUgbWVyZ2luZyB2aWEgZHJtLWludGVsLgo+Pgo+Pj4+PiDCoMKgIGRybS9y YWRlb246IFVzZSBkcm1fbW9kZV9jb3B5KCkKPj4+Pj4gwqDCoCBkcm0vZ21hNTAwOiBVc2UgZHJt X21vZGVfY29weSgpCj4+Pj4+IMKgwqAgZHJtL3RpbGNkYzogVXNlIGRybV9tb2RlX2NvcHkoKQo+ Pj4+PiDCoMKgIGRybS9pOTE1OiBVc2UgZHJtX21vZGVfY29weSgpCj4+Cj4+IFRob3NlIGFyZSBu b3cgYWxsIGluLgo+Pgo+PiBXaGljaCBsZWF2ZXMgdXMgd2l0aCB0aGVzZSBzdHJhZ2dsZXJzOgo+ Pj4+PiDCoMKgIGRybS9oaXNpbGljb246IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9uLXN0YWNr IG1vZGVzCj4gCj4+Pj4+IMKgwqAgZHJtL21zbTogTnVrZSB3ZWlyZCBvbiBzdGFjayBtb2RlIGNv cHkKPj4+Pj4gwqDCoCBkcm0vbXNtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBt b2Rlcwo+Pj4+PiDCoMKgIGRybS9tc206IFVzZSBkcm1fbW9kZV9jb3B5KCkKPiAKPiBUaGVzZSB0 aHJlZSBwYXRjaGVzIHdlbnQgYmVuZWF0aCBteSByYWRhciBmb3Igc29tZSByZWFzb24uCj4gCj4g SSBoYXZlIGp1c3Qgc2VudCBhIHJlcGxhY2VtZW50IGZvciB0aGUgZmlyc3QgcGF0Y2ggKFsxXSku IE90aGVyIHR3byAKPiBwYXRjaGVzIGNhbiBiZSBwdWxsZWQgaW4gbXNtL21zbS1uZXh0IChvciBt c20vbXNtLWZpeGVzKSBkdXJpbmcgdGhlIG5leHQgCj4gZGV2ZWxvcG1lbnQgY3ljbGUgaWYgdGhh dCB3b3JrcyBmb3IgeW91Lgo+IAo+IFsxXSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5v cmcvc2VyaWVzLzEwMTY4Mi8KCkFncmVlIHdpdGggdGhpcyBhcHByb2FjaC4KCldlIGNhbiByZXBs YWNlIHRoZSBmaXJzdCBwYXRjaCB3aXRoIApodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5v cmcvc2VyaWVzLzEwMTY4Mi8uCgpUaGFua3MKCkFiaGluYXYKCj4gCj4+Pj4+IMKgwqAgZHJtL210 azogVXNlIGRybV9tb2RlX2luaXQoKSBmb3Igb24tc3RhY2sgbW9kZXMKPj4+Pj4gwqDCoCBkcm0v cm9ja2NoaXA6IFVzZSBkcm1fbW9kZV9jb3B5KCkKPj4+Pj4gwqDCoCBkcm0vc3RpOiBVc2UgZHJt X21vZGVfY29weSgpCj4+Pj4+IMKgwqAgZHJtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1z dGFjayBtb2Rlcwo+Pj4+PiDCoMKgIGRybTogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pgo+IAo+IAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9j a2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15656C433F5 for ; Wed, 23 Mar 2022 20:50:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3549010E171; Wed, 23 Mar 2022 20:50:52 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C7AC10E121; Wed, 23 Mar 2022 20:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , Chen Feng , Alain Volmat , Chun-Kuang Hu , Jonas Karlman , Leo Li , linux-arm-msm , Intel Graphics Development , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , Jyri Sarha , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , freedreno , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: >> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >>> wrote: >>>> >>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>>>    drm: Add drm_mode_init() >>>>>    drm/bridge: Use drm_mode_copy() >>>>>    drm/imx: Use drm_mode_duplicate() >>>>>    drm/panel: Use drm_mode_duplicate() >>>>>    drm/vc4: Use drm_mode_copy() >>>> These have been pushed to drm-misc-next. >>>> >>>>>    drm/amdgpu: Remove pointless on stack mode copies >>>>>    drm/amdgpu: Use drm_mode_init() for on-stack modes >>>>>    drm/amdgpu: Use drm_mode_copy() >>>> amdgpu ones are reviewed, but I'll leave them for the >>>> AMD folks to push to whichever tree they prefer. >>> >>> I pulled patches 2, 4, 5 into my tree. >> >> Thanks. >> >>> For 3, I'm happy to have it >>> land via drm-misc with the rest of the mode_init changes if you'd >>> prefer. >> >> Either way works for me. I don't yet have reviews yet for >> the other drivers, so I'll proably hold off for a bit more >> at least. And the i915 patch I'll be merging via drm-intel. >> >>>>>    drm/radeon: Use drm_mode_copy() >>>>>    drm/gma500: Use drm_mode_copy() >>>>>    drm/tilcdc: Use drm_mode_copy() >>>>>    drm/i915: Use drm_mode_copy() >> >> Those are now all in. >> >> Which leaves us with these stragglers: >>>>>    drm/hisilicon: Use drm_mode_init() for on-stack modes > >>>>>    drm/msm: Nuke weird on stack mode copy >>>>>    drm/msm: Use drm_mode_init() for on-stack modes >>>>>    drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. > > [1] https://patchwork.freedesktop.org/series/101682/ Agree with this approach. We can replace the first patch with https://patchwork.freedesktop.org/series/101682/. Thanks Abhinav > >>>>>    drm/mtk: Use drm_mode_init() for on-stack modes >>>>>    drm/rockchip: Use drm_mode_copy() >>>>>    drm/sti: Use drm_mode_copy() >>>>>    drm: Use drm_mode_init() for on-stack modes >>>>>    drm: Use drm_mode_copy() >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FDB2C433FE for ; Wed, 23 Mar 2022 20:50:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9670910E154; Wed, 23 Mar 2022 20:50:51 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C7AC10E121; Wed, 23 Mar 2022 20:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Subject: Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , Chen Feng , Alain Volmat , Chun-Kuang Hu , Jonas Karlman , Leo Li , linux-arm-msm , Intel Graphics Development , Nikola Cornij , linux-arm-kernel , Tomi Valkeinen , Jyri Sarha , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , freedreno , Laurent Pinchart Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: >> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >>> wrote: >>>> >>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>>>    drm: Add drm_mode_init() >>>>>    drm/bridge: Use drm_mode_copy() >>>>>    drm/imx: Use drm_mode_duplicate() >>>>>    drm/panel: Use drm_mode_duplicate() >>>>>    drm/vc4: Use drm_mode_copy() >>>> These have been pushed to drm-misc-next. >>>> >>>>>    drm/amdgpu: Remove pointless on stack mode copies >>>>>    drm/amdgpu: Use drm_mode_init() for on-stack modes >>>>>    drm/amdgpu: Use drm_mode_copy() >>>> amdgpu ones are reviewed, but I'll leave them for the >>>> AMD folks to push to whichever tree they prefer. >>> >>> I pulled patches 2, 4, 5 into my tree. >> >> Thanks. >> >>> For 3, I'm happy to have it >>> land via drm-misc with the rest of the mode_init changes if you'd >>> prefer. >> >> Either way works for me. I don't yet have reviews yet for >> the other drivers, so I'll proably hold off for a bit more >> at least. And the i915 patch I'll be merging via drm-intel. >> >>>>>    drm/radeon: Use drm_mode_copy() >>>>>    drm/gma500: Use drm_mode_copy() >>>>>    drm/tilcdc: Use drm_mode_copy() >>>>>    drm/i915: Use drm_mode_copy() >> >> Those are now all in. >> >> Which leaves us with these stragglers: >>>>>    drm/hisilicon: Use drm_mode_init() for on-stack modes > >>>>>    drm/msm: Nuke weird on stack mode copy >>>>>    drm/msm: Use drm_mode_init() for on-stack modes >>>>>    drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. > > [1] https://patchwork.freedesktop.org/series/101682/ Agree with this approach. We can replace the first patch with https://patchwork.freedesktop.org/series/101682/. Thanks Abhinav > >>>>>    drm/mtk: Use drm_mode_init() for on-stack modes >>>>>    drm/rockchip: Use drm_mode_copy() >>>>>    drm/sti: Use drm_mode_copy() >>>>>    drm: Use drm_mode_init() for on-stack modes >>>>>    drm: Use drm_mode_copy() >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83B15C433F5 for ; Wed, 23 Mar 2022 20:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KtljwjU5pSSHdfvKy4jT1vPzXNcA5GjCdg5Q5ObWeIM=; b=HCKRjflbmYDVW0 aBrdxbOCt2rUC+gnxI1oOaJSjUKFj1Cnxdl7QJmdV3Lt/1xJqbfLEpyYeFe/K4KKHqFAEJm2Nr5cw Q9zpXcZNNU5T2icCN69yhPW888SBFo2uNOT+ZbWFkk89fCuPdJfixU/3WRkHcwi6XgOgDIgZeriJt yHQKuQXJUfq68e97mjKMEoqAaXQYU6BTKRqBENeODm1UkwzGQwOXRz6OgcmIqc3lLA5MOilDAsxTZ 2vlCjWVC9zyUszXCxFE6RDDGUZKsNwMzatJvVzc29uFV8ss7hblgLQzqlAFddUMHFOZe2mbDNuCCC 1qDd6BSPo4rHCvMvqiZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX7wU-00EqnU-VU; Wed, 23 Mar 2022 20:50:55 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX7wQ-00Eqmi-V1; Wed, 23 Mar 2022 20:50:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" CC: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , , Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Chun-Kuang Hu , "Jonas Karlman" , Leo Li , Chen Feng , Intel Graphics Development , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_135051_077947_08D59B17 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAzLzIzLzIwMjIgMzozOSBBTSwgRG1pdHJ5IEJhcnlzaGtvdiB3cm90ZToKPiBPbiAyMi8w My8yMDIyIDAxOjM3LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+IE9uIFR1ZSwgTWFyIDE1LCAy MDIyIGF0IDAyOjUyOjM4UE0gLTA0MDAsIEFsZXggRGV1Y2hlciB3cm90ZToKPj4+IE9uIE1vbiwg TWFyIDE0LCAyMDIyIGF0IDY6MTIgUE0gVmlsbGUgU3lyasOkbMOkCj4+PiA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4+Cj4+Pj4gT24gRnJpLCBGZWIgMTgsIDIwMjIg YXQgMTI6MDM6NDFQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3cm90ZToKPj4+Pj4gwqDCoCBkcm06 IEFkZCBkcm1fbW9kZV9pbml0KCkKPj4+Pj4gwqDCoCBkcm0vYnJpZGdlOiBVc2UgZHJtX21vZGVf Y29weSgpCj4+Pj4+IMKgwqAgZHJtL2lteDogVXNlIGRybV9tb2RlX2R1cGxpY2F0ZSgpCj4+Pj4+ IMKgwqAgZHJtL3BhbmVsOiBVc2UgZHJtX21vZGVfZHVwbGljYXRlKCkKPj4+Pj4gwqDCoCBkcm0v dmM0OiBVc2UgZHJtX21vZGVfY29weSgpCj4+Pj4gVGhlc2UgaGF2ZSBiZWVuIHB1c2hlZCB0byBk cm0tbWlzYy1uZXh0Lgo+Pj4+Cj4+Pj4+IMKgwqAgZHJtL2FtZGdwdTogUmVtb3ZlIHBvaW50bGVz cyBvbiBzdGFjayBtb2RlIGNvcGllcwo+Pj4+PiDCoMKgIGRybS9hbWRncHU6IFVzZSBkcm1fbW9k ZV9pbml0KCkgZm9yIG9uLXN0YWNrIG1vZGVzCj4+Pj4+IMKgwqAgZHJtL2FtZGdwdTogVXNlIGRy bV9tb2RlX2NvcHkoKQo+Pj4+IGFtZGdwdSBvbmVzIGFyZSByZXZpZXdlZCwgYnV0IEknbGwgbGVh dmUgdGhlbSBmb3IgdGhlCj4+Pj4gQU1EIGZvbGtzIHRvIHB1c2ggdG8gd2hpY2hldmVyIHRyZWUg dGhleSBwcmVmZXIuCj4+Pgo+Pj4gSSBwdWxsZWQgcGF0Y2hlcyAyLCA0LCA1IGludG8gbXkgdHJl ZS4KPj4KPj4gVGhhbmtzLgo+Pgo+Pj4gRm9yIDMsIEknbSBoYXBweSB0byBoYXZlIGl0Cj4+PiBs YW5kIHZpYSBkcm0tbWlzYyB3aXRoIHRoZSByZXN0IG9mIHRoZSBtb2RlX2luaXQgY2hhbmdlcyBp ZiB5b3UnZAo+Pj4gcHJlZmVyLgo+Pgo+PiBFaXRoZXIgd2F5IHdvcmtzIGZvciBtZS4gSSBkb24n dCB5ZXQgaGF2ZSByZXZpZXdzIHlldCBmb3IKPj4gdGhlIG90aGVyIGRyaXZlcnMsIHNvIEknbGwg cHJvYWJseSBob2xkIG9mZiBmb3IgYSBiaXQgbW9yZQo+PiBhdCBsZWFzdC4gQW5kIHRoZSBpOTE1 IHBhdGNoIEknbGwgYmUgbWVyZ2luZyB2aWEgZHJtLWludGVsLgo+Pgo+Pj4+PiDCoMKgIGRybS9y YWRlb246IFVzZSBkcm1fbW9kZV9jb3B5KCkKPj4+Pj4gwqDCoCBkcm0vZ21hNTAwOiBVc2UgZHJt X21vZGVfY29weSgpCj4+Pj4+IMKgwqAgZHJtL3RpbGNkYzogVXNlIGRybV9tb2RlX2NvcHkoKQo+ Pj4+PiDCoMKgIGRybS9pOTE1OiBVc2UgZHJtX21vZGVfY29weSgpCj4+Cj4+IFRob3NlIGFyZSBu b3cgYWxsIGluLgo+Pgo+PiBXaGljaCBsZWF2ZXMgdXMgd2l0aCB0aGVzZSBzdHJhZ2dsZXJzOgo+ Pj4+PiDCoMKgIGRybS9oaXNpbGljb246IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9uLXN0YWNr IG1vZGVzCj4gCj4+Pj4+IMKgwqAgZHJtL21zbTogTnVrZSB3ZWlyZCBvbiBzdGFjayBtb2RlIGNv cHkKPj4+Pj4gwqDCoCBkcm0vbXNtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBt b2Rlcwo+Pj4+PiDCoMKgIGRybS9tc206IFVzZSBkcm1fbW9kZV9jb3B5KCkKPiAKPiBUaGVzZSB0 aHJlZSBwYXRjaGVzIHdlbnQgYmVuZWF0aCBteSByYWRhciBmb3Igc29tZSByZWFzb24uCj4gCj4g SSBoYXZlIGp1c3Qgc2VudCBhIHJlcGxhY2VtZW50IGZvciB0aGUgZmlyc3QgcGF0Y2ggKFsxXSku IE90aGVyIHR3byAKPiBwYXRjaGVzIGNhbiBiZSBwdWxsZWQgaW4gbXNtL21zbS1uZXh0IChvciBt c20vbXNtLWZpeGVzKSBkdXJpbmcgdGhlIG5leHQgCj4gZGV2ZWxvcG1lbnQgY3ljbGUgaWYgdGhh dCB3b3JrcyBmb3IgeW91Lgo+IAo+IFsxXSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5v cmcvc2VyaWVzLzEwMTY4Mi8KCkFncmVlIHdpdGggdGhpcyBhcHByb2FjaC4KCldlIGNhbiByZXBs YWNlIHRoZSBmaXJzdCBwYXRjaCB3aXRoIApodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5v cmcvc2VyaWVzLzEwMTY4Mi8uCgpUaGFua3MKCkFiaGluYXYKCj4gCj4+Pj4+IMKgwqAgZHJtL210 azogVXNlIGRybV9tb2RlX2luaXQoKSBmb3Igb24tc3RhY2sgbW9kZXMKPj4+Pj4gwqDCoCBkcm0v cm9ja2NoaXA6IFVzZSBkcm1fbW9kZV9jb3B5KCkKPj4+Pj4gwqDCoCBkcm0vc3RpOiBVc2UgZHJt X21vZGVfY29weSgpCj4+Pj4+IMKgwqAgZHJtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1z dGFjayBtb2Rlcwo+Pj4+PiDCoMKgIGRybTogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pgo+IAo+IAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=